Received-SPF: pass (google.com: domain of linux-kernel+bounces-69386-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <71db0ad0-a385-8572-7bea-bb11f76a6345@oracle.com>
Date: Fri, 16 Feb 2024 14:00:31 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH v2 4/6] mm/migrate_device: convert
 __migrate_device_pages() to folios
Content-Language: en-US
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        akpm@linux-foundation.org, apopple@nvidia.com
References: <20240216211320.222431-1-sidhartha.kumar@oracle.com>
 <20240216211320.222431-4-sidhartha.kumar@oracle.com>
 <Zc_Z1PT20tNlsiFf@casper.infradead.org>
From: Sidhartha Kumar <sidhartha.kumar@oracle.com>
In-Reply-To: <Zc_Z1PT20tNlsiFf@casper.infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?cWpJYkowM1RGeW8rU0lQSXBTbk1qS0NVRTAzM0pJTTEyWmxmWDFCWi9nUkNO?=
 =?utf-8?B?ZUdZbEdDUkF6b3VuY211UkdmOW1LMlIxbTltTi9NMnU2elZsZitxZzJENDRz?=
 =?utf-8?B?a2NUQ1pHTGlGdTVER2txOE5CTmwrbnMySlBZTlRqNGdMSFJMdFFTa0xHUFkx?=
 =?utf-8?B?NzhXZktLSXVsZkRYZlZhSUh3ZVFaN25FR3FXdE1MRG55SGZ3Tkp2MWRkK1ND?=
 =?utf-8?B?dDErZjlIenhwMFM4QzBLdHNrS21LZzVpMEtkRFBTU0h1ZzVKVDlzeXpQMDg5?=
 =?utf-8?B?QmdVenZhVzhVU3Z6TTU2VG5JRisrRjNIOWFhTzlaVUtSTVBDV2JIcGlpdzYv?=
 =?utf-8?B?SlJzcFdoMjZuOGZESytwUE5aOE5TbHdnOVFOMmhCV2s0NUY5eFBkU0UvWkIv?=
 =?utf-8?B?WlZ0bzNoYXBsMGgwZzlob1VHWjB5VGc5TThzS3YyRlFiVGZlMnhLYVQ4T1dm?=
 =?utf-8?B?dXUyL1F4NnhGdDhjRitjRVBPUVphNFRHNENQaENyUGpSaytvaDFnOVRmdEFU?=
 =?utf-8?B?VkFTS1V0c3Evbk9HTkdyWjZFT0U5VEVDa25ZaXZpRXhDZThoM24yUmdqKy9X?=
 =?utf-8?B?VHoxSmNZUjZuT3ExQk1semo5VUtPTktWczNBRCt1amp2TjlaRFVteFd3cWJW?=
 =?utf-8?B?THQ2Tk1kaXlaS0xtYjYvN0VoYWxmN2I2TFNVbGowYWlyWFdQUjE0a3dXWkNs?=
 =?utf-8?B?U2VvbS90MjVuVVl5YzZoOTJmZVNoK3dpTkZOeWUyb3hMRW1GODFudHNhTnNM?=
 =?utf-8?B?a3hkV1Q1UHM5OE82SXUzTHY1U0JSNXM2bWNwazNmbEs4eCt2Rml2d3luT1FQ?=
 =?utf-8?B?aVRKQ3YyWndPdXcxUnM2WDlaTWFMYlBqd0JLMkhuYStqKytQSXVjcDhFd1h0?=
 =?utf-8?B?YkZERzdKQ2dwa29SNEpjd2YwU3Q1NXo0RjVzV1hjSXB0Q2p3TkxESVNlUTZj?=
 =?utf-8?B?SFdUZTVPV0Yzb0wySXdubU41d0lISGZZR2lNMWgyMERScTdnUitsSXBTNU5Y?=
 =?utf-8?B?TUhVQ1RTTXFhQmt3cjdXclZPL2gwVTFzN3FBcDFacmZNM1M4eGU5a3RTN0dB?=
 =?utf-8?B?Q3hSVENlNE9jTkRpZHY0N0N4YVFCUUl6MzVqUkFoT2h4V3B1dUNlQ04rQkFl?=
 =?utf-8?B?QUhEMDl6b1N3MENuaERIZWNrQ29ra0QvTlFOR1UyeVYvcFJnMWpXR2NxQ3BY?=
 =?utf-8?B?cUxrU21DZDBaNU5USXpPckp3dnRaVFVlK0hPbmJGR2szUUdaUjNac21DNlJ2?=
 =?utf-8?B?c1UzR054VjM4TXJQcDRSS1N2alFIcGp0REpJWXAvTHYvWUN5cGJOUm5mei90?=
 =?utf-8?B?TENuZHphNXc0OVRiaUJ2c1RQaGlsMkFuU1YvcUtESitXOEZZYlFOMGNuUmlj?=
 =?utf-8?B?dnJ5ejVmK3N0VVgvbnp5NklBYXRRVVptQ2tDbkE0eFNBT3lMamtPellNbFM1?=
 =?utf-8?B?Q2JTTDc1VUhudTNEeDRpSUlqZVJYaHd5clkxbDVtazc1Tysxdk5IMksvVWx4?=
 =?utf-8?B?dEQrS29SSmdYN09obW5nQll4NHQ1WkpBMW80VkJIVjlzTkw4cm5qNC91eFNP?=
 =?utf-8?B?TGd6YUlVclEwVmlEdEVrWTV2SUNPYXljcDdodnlzQ1pZaXlsTm1WRkRVbE1q?=
 =?utf-8?B?M2pyc3lTN1V6dG14a1ByZXNpT1FNU1NaZHdBZERHRnZTL1o4WitqdW10ZVJ5?=
 =?utf-8?B?RFFGSjlVUEZ1M3czZUl3SXAycGIzVWhTbE5BU0tCczhyYTNsMmpTaEI4Q3Zp?=
 =?utf-8?B?NGpQUUVQa2xFODIxazZlVjNJVFJpN1pTRVgwdzVncGNHR0wyME52UXNqZU1j?=
 =?utf-8?B?N2lxb3pqVVpGSFV6M2Y4Tms4ZmsyZVZwS3JtcGhxVC9NVWpncWpLVHlMNHdR?=
 =?utf-8?B?MUZBRHB2VHlBNjBqYTlPdlJRdTJ1NnhvYWhkR2Nza3VxY2YveXZoSkVsM1Bw?=
 =?utf-8?B?S2pNNG1lQ09idjZ4SWFvZzFrdUROUDFhRTM0MzVnNXdienFmR0xPbDBQaTJ3?=
 =?utf-8?B?ZkhpSGxJR3diL0RIcXVnZHFWR3RXWThUWDFqai82cXVYaXFsa2FSVnJQNisz?=
 =?utf-8?B?OEVYZ0Y3MkNoVCtKREd6Y1ZtRHU4eEtsY3NVUkdKOHBuS0U5SHlYL0xoa0FL?=
 =?utf-8?B?MUErRDh6WXljRG9kMmx5NncwZnF3NllSVUg3L0syOUtXUGhnaFMrSmZMZUlT?=
 =?utf-8?Q?ZVkkL1jDoByWSraXGaCtcNI=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	Qf3Zb+QK//AHyycJ9WBMewlV/+ue1I3cDai6rzY8UTPzeTaBktWuK+P/Kko63NAeZdOIeTTn8BpdOtqPquE+ZFrS23CAngl6SB35uzlAsDEL8pH7Yg1HT+NCShASYKYG0H+NJgUit77T3BANZaC1qotjpsmlU2NaQfkBy7cimrruNgR8vZ6uo01rMu2wRP/o5ObFeHfntfh7MbyJzNHmqifYhHfPz+e0B2sYtfe84MvjrEQ8xfJQDWRL2fxNnnLh+Xczo3Te281sUz+nJOk57a2xEnxTwnapY140IObsZS8l1hx/oPyl7hN0xZOH+1FGrnFDZfTkz/uYWxSu81qATQwP7hDq5BUAfRAYnnpj77EIofTD2YEEMQEmkypPVmeWyo0YaBjlZbeHi6vd25wVMZGxaO/vle4xUbp1yiVywviQq6+nUdEZhRYZtkc7r+xzkiSPmhluJbeDl5yIx9QrO0g/wQuDvoT/q5NY0yTjmZ6XzfYGgo3Hyd8Im1yzdpUdc+8kFen4myI3bLg5SA7wWvFlDXyugl+gyXi7i6k4A34dv1xyKIBlw+iSXaFPsvqfKmQGxNrJg2+YBE+1XGLR/IaC/H8a4GY12PIILXu1aDM=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3643b4d7-232b-4fe6-8a46-08dc2f3ab2bd
X-MS-Exchange-CrossTenant-AuthSource: CH0PR10MB5113.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2024 22:00:33.5095
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SaHAlwYOZB6vR4nzf5AWXUjQ4YAObS8hgrilSe+eEzA9Qt19UlQc00TuH5lumfDgdDDKZxJ8/CA0zOY1f12wA78PP1KPJRNibiOexaKzmE0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR10MB7912
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-16_21,2024-02-16_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 spamscore=0
 mlxlogscore=999 bulkscore=0 phishscore=0 mlxscore=0 suspectscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2402160173
X-Proofpoint-ORIG-GUID: Xne2anwvDyNg7ov0bASGvLVkWpXSSDUF
X-Proofpoint-GUID: Xne2anwvDyNg7ov0bASGvLVkWpXSSDUF

On 2/16/24 1:55 PM, Matthew Wilcox wrote:
> On Fri, Feb 16, 2024 at 01:13:18PM -0800, Sidhartha Kumar wrote:
>> Use migrate_pfn_to_folio() so we can work with folios directly in
>> __migrate_device_pages().
> 
> i don't understand why this would be correct if we have multipage
> folios.
> 

Alistair mentioned that he is working on order > 0 device page support so I was 
under the impression that currently device pages are only order 0.

Thanks,
Sid

>> @@ -719,33 +719,29 @@ static void __migrate_device_pages(unsigned long *src_pfns,
>>   					migrate->pgmap_owner);
>>   				mmu_notifier_invalidate_range_start(&range);
>>   			}
>> -			migrate_vma_insert_page(migrate, addr, newpage,
>> +			migrate_vma_insert_page(migrate, addr, &dst->page,
> 
> seems to me that a migration pfn is going to refer to a precise page.
> now you're telling it to insert the head page of the folio.  isn't this
> wrong?
> 
>> @@ -753,13 +749,11 @@ static void __migrate_device_pages(unsigned long *src_pfns,
>>   			continue;
>>   		}
>>   
>> -		if (migrate && migrate->fault_page == page)
>> -			r = migrate_folio_extra(mapping, page_folio(newpage),
>> -						page_folio(page),
>> -						MIGRATE_SYNC_NO_COPY, 1);
>> +		if (migrate && migrate->fault_page == &src->page)
> 
> shouldn't this rather be "page_folio(migrate->fault_page) == src"?
> ie we're looking for two pages from the same folio, rather than the page
> being the same as the head page of the folio?
>