Received-SPF: pass (google.com: domain of linux-kernel+bounces-69389-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Fri, 16 Feb 2024 23:04:44 +0100
From: Robert Richter <rrichter@amd.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Davidlohr Bueso <dave@stgolabs.net>,
	Jonathan Cameron <jonathan.cameron@huawei.com>,
	Dave Jiang <dave.jiang@intel.com>,
	Alison Schofield <alison.schofield@intel.com>,
	Vishal Verma <vishal.l.verma@intel.com>,
	Ira Weiny <ira.weiny@intel.com>, linux-cxl@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] cxl/pci: Fix disabling memory if DVSEC CXL Range does
 not match a CFMWS window
Message-ID: <Zc_b_F5TSRSBwrNZ@rric.localdomain>
References: <20240216160113.407141-1-rrichter@amd.com>
 <65cfa34b741ea_5c762946@dwillia2-mobl3.amr.corp.intel.com.notmuch>
 <Zc-k1TDk1hfvakQS@rric.localdomain>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Zc-k1TDk1hfvakQS@rric.localdomain>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Nn1zcgPQvhdjkNnG8Y3BpLcmxtpUn45DGyi+HbvPvK18bgV3Yqq8UYPNfWyP?=
 =?us-ascii?Q?pzu3X9OT2MGG2bykx4+IYVbeX2NaYAnOOzDtsH06WfulhCvu+tKCJJjTpDU3?=
 =?us-ascii?Q?klcLLEogMlezOHI0zqYevQVCbIcLFPKfbX4ir076w5qFpZMQC4U/NQjnUwRM?=
 =?us-ascii?Q?9qwMgOfpZetAyjKDT0+QeRwMVugrkzMHru4l5CwfYbuXFUsW8MR7OCO9w1vF?=
 =?us-ascii?Q?9mxrqhQ2Yio1pmPfNL/mQTHLprnqKPuGZuPzSGVgiJsQQInkQybQHp9y8BJG?=
 =?us-ascii?Q?PmB0CQSZMwOI1NHnlXzVtQbVoAncXYEX+UOY4axhch/lVoLd3bAdqpiWsVHK?=
 =?us-ascii?Q?HzQotkss3H7DpAOCUJ7Pet0IS/JTNzB1Fpt0IMt4psLa4jrj41wwLzs2wBdf?=
 =?us-ascii?Q?oErZLg7DTa+JYEoXE1P70Tp46C/F4yPh9p5irx0F0cl5pAK1DNWY9xdgjn3b?=
 =?us-ascii?Q?AXs4QFwgdFYIyzLWqvIJ50WZDA+YifsgHbCmtlTBNqSqVqXGq02Y6k/nM99K?=
 =?us-ascii?Q?QEtCIUJPyanwRGUBu3fFxfzmwkVY9x2ErcL5JN8F1+9xXwBLpL5CDHWTXpai?=
 =?us-ascii?Q?xcYOMK9VWHKZ3+zYD8bAr1WMqzwodz5/E4vK5cj5OTPnM8wKoKwA1LCBmSYV?=
 =?us-ascii?Q?DNtepQxZU0ewNju/tFci198hR67VKXrQgesapl94Z9F9Cj1FqUtURdaeyEXW?=
 =?us-ascii?Q?8OwZj1/LhDSipdLl1hw5jxqWQfMzmxJdaV2xhs6lplw/IZIvSFwZR/1iVDcY?=
 =?us-ascii?Q?Lst3VjgCr5lC137onn5IjCxDaqVKpKSeEKxS3wIMCM73XUvXWOOte9wnlMhx?=
 =?us-ascii?Q?Lok7d7TXTN9L3cKn74YAocGxKdcWXETNeA99h9UiKmbgG9flVu2Liwyk0GEQ?=
 =?us-ascii?Q?POoRSYIfDKf+hPOqryODatpydxlZT2xhIlcEvcMrHVD8hPyG8uS5sBZvgEyY?=
 =?us-ascii?Q?cCfw0YloGsBv//UaXFdp9tmjg+uPHgOEFtEtLGtmOKKZe/95nyYaKigIj+3j?=
 =?us-ascii?Q?hTeC0CVVhnX3zz2guKjST0+mR+VrgI1dmV2fogM/1l0Szj8I0eJWkqiS40O8?=
 =?us-ascii?Q?V8gjNuXDGE+Swr0AnN555YYBlUJ3znrYD5dc4xIdMgVhsimo6PRZJX4A83Qa?=
 =?us-ascii?Q?iz6ecsrHQu+goDBrHjt+Wxo5j0NF4N6ybWx8l/xWq3/hyXnpQx0QJwOQTaJX?=
 =?us-ascii?Q?ItPSuE8mLMz6rGeMke0FpQHAkQildt7jKtNUzMBF0HNPxsKYfqKbhQqNdkex?=
 =?us-ascii?Q?zCB7fAgLpnAVPEWDStpsD78lWfl6NtHaxk3WRBikLJ7msY2fKRFCRoOy7RW2?=
 =?us-ascii?Q?ljIhnfDoYmxvEXoktGT3HnKoM3IDE17hnEzGSwM/PolIyASMIt9FKYe+PTx9?=
 =?us-ascii?Q?mQ7566NPcbJmHpg3CGAb37a2aEFrtvLDzA2LuvKxoTCHI4+/Vs+aRKCMgP1o?=
 =?us-ascii?Q?X+lbrdrNIOJaSCnHS7zbn/h7Vnah7ebslm3bpXFIwo6LgU+YHOZm8kmL9GEG?=
 =?us-ascii?Q?+jQq1RA1NhoJusc8fP7x8iUG5wNU2oDbpyj9M5RxnosM1y0RwgcmIccDChNF?=
 =?us-ascii?Q?KBuTpUOPN+sNB1BZ6ASPXT56CVFnnvamFtHX5EEx?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e85f1118-8295-4d27-248c-08dc2f3b4b17
X-MS-Exchange-CrossTenant-AuthSource: CYYPR12MB8750.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2024 22:04:49.0868
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uvbCiQfMCf3SWqT4QBbd2eRBb3gZLeKDDE4c1Jrqthmhvd7Ytd1NBrpfsJYfLLxWwC0VuoxABVDN1zzJuxKt2A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5063

On 16.02.24 19:09:30, Robert Richter wrote:
> On 16.02.24 10:02:51, Dan Williams wrote:
> > Robert Richter wrote:
> > > The Linux CXL subsystem is built on the assumption that HPA == SPA.
> > > That is, the host physical address (HPA) the HDM decoder registers are
> > > programmed with are system physical addresses (SPA).
> > > 
> > > During HDM decoder setup, the DVSEC CXL range registers (cxl-3.1,
> > > 8.1.3.8) are checked if the memory is enabled and the CXL range is in
> > > a HPA window that is described in a CFMWS structure of the CXL host
> > > bridge (cxl-3.1, 9.18.1.3).
> > > 
> > > Now, if the HPA is not an SPA, the CXL range does not match a CFMWS
> > > window and the CXL memory range will be disabled then. The HDM decoder
> > > stops working which causes system memory being disabled and further a
> > > system hang during HDM decoder initialization, typically when a CXL
> > > enabled kernel boots.
> > > 
> > > Prevent a system hang and do not disable the HDM decoder if the
> > > decoder's CXL range is not found in a CFMWS window.
> > > 
> > > Note the change only fixes a hardware hang, but does not implement
> > > HPA/SPA translation. Support for this can be added in a follow on
> > > patch series.
> > > 

Fixes: 9de321e93c3b ("cxl/pci: Refactor cxl_hdm_decode_init()")
Fixes: 34e37b4c432c ("cxl/port: Enable HDM Capability after validating DVSEC Ranges")
Cc: stable@vger.kernel.org

Sorry, I forgot those tags, please add.

Thanks,

-Robert

> > > Signed-off-by: Robert Richter <rrichter@amd.com>
> > > ---
> > >  drivers/cxl/core/pci.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)