Received-SPF: pass (google.com: domain of linux-kernel+bounces-69391-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Fri, 16 Feb 2024 22:07:12 +0000
Message-Id: <CZ6UFX5R09DD.EWDFS24L16G1@seitikki>
Subject: =?utf-8?q?Re:_init=5Ftis()_takes_50_ms_on_Dell_XPS_13_9360_=E2=80=93_almo?= =?utf-8?q?st_10_%_of_whole_time_until_initrd?=
From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Paul Menzel" <pmenzel@molgen.mpg.de>, "Peter Huewe" <peterhuewe@gmx.de>
Cc: <linux-integrity@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <0eba23c7-f62a-4a85-a383-60dec9d198f9@molgen.mpg.de>
In-Reply-To: <0eba23c7-f62a-4a85-a383-60dec9d198f9@molgen.mpg.de>

On Wed Feb 14, 2024 at 3:10 PM UTC, Paul Menzel wrote:
> Dear Linux folks,
>
>
> Trying to optimize the boot time of Linux on the Dell XPS 13 9360,=20
> probing of MSFT0101:00 takes 52 ms, making `init_tis()` taking almost 10=
=20
> % alone until starting the initrd:
>
>      [    0.000000] Linux version 6.8.0-rc4=20
> (build@bohemianrhapsody.molgen.mpg.de) (gcc (Debian 13.2.0-13) 13.2.0,=20
> GNU ld (GNU Binutils for Debian) 2.42) #20 SMP PREEMPT_DYNAMIC Mon Feb=20
> 12 09:40:49 CET 2024
>      [=E2=80=A6]
>      [    0.000000] DMI: Dell Inc. XPS 13 9360/0596KF, BIOS 2.21.0=20
> 06/02/2022
>      [=E2=80=A6]
>      [    0.320057] calling  init_tis+0x0/0x100 @ 1
>      [    0.332190] tpm_tis MSFT0101:00: 2.0 TPM (device-id 0xFE, rev-id =
4)
>      [    0.372164] probe of MSFT0101:00 returned 0 after 52101 usecs
>      [    0.372186] initcall init_tis+0x0/0x100 returned 0 after 52127 us=
ecs
>      [=E2=80=A6]
>      [    0.588643] Freeing unused decrypted memory: 2036K
>      [    0.589068] Freeing unused kernel image (initmem) memory: 3976K
>      [    0.606115] Write protecting the kernel read-only data: 22528k
>      [    0.606527] Freeing unused kernel image (rodata/data gap)=20
> memory: 276K
>      [    0.652327] x86/mm: Checked W+X mappings: passed, no W+X pages=20
> found.
>      [    0.652329] x86/mm: Checking user space page tables
>      [    0.695968] x86/mm: Checked W+X mappings: passed, no W+X pages=20
> found.
>      [    0.696104] Run /init as init process
>      [=E2=80=A6]
>
> For users, where boot time is most important, can this be moved out of=20
> the hot path somehow?

It can't be IRQ probing as IRQ's are *disabled* by default. So we can
disclose that.

I think the delay is caused by tpm2_probe(), which is called by
tpm_tis_core_init(). It sends an idempotent TPM2 command to the TPM
chip to know whether it is TPM 1.x or TPM2 chip.

That detection is definitely required.

Even some other subsystems in the kernel require to know the correct
TPM version, like hwrng and IMA.

> Kind regards,
>
> Paul

BR, Jarkko