Received-SPF: pass (google.com: domain of linux-kernel+bounces-69442-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <9229efc2-832d-4b13-b3ce-8b3db22653a4@intel.com>
Date: Fri, 16 Feb 2024 14:37:45 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next 1/3] net: mdio: mdio-bcm-unimac: Manage clock
 around I/O accesses
Content-Language: en-US
To: Florian Fainelli <florian.fainelli@broadcom.com>, <netdev@vger.kernel.org>
CC: Doug Berger <opendmb@gmail.com>, Broadcom internal kernel review list
	<bcm-kernel-feedback-list@broadcom.com>, "David S. Miller"
	<davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski
	<kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Andrew Lunn
	<andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>, Russell King
	<linux@armlinux.org.uk>, open list <linux-kernel@vger.kernel.org>, "Justin
 Chen" <justin.chen@broadcom.com>
References: <20240216184237.259954-1-florian.fainelli@broadcom.com>
 <20240216184237.259954-2-florian.fainelli@broadcom.com>
From: Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20240216184237.259954-2-florian.fainelli@broadcom.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZUxScDUwdmdsQ1Q0aXhZRUxYTE9MOGM2TU5oV0tsbmdWQWtxT3c4eHI1Znhj?=
 =?utf-8?B?QXU2cEZkelZTcis5V3BaVnNjNklwT0JXRnZWQThubGpOZFBudjkyS1dVOUU5?=
 =?utf-8?B?VzdJL0lGZ2hVZks5S2FJWGpUMnZTSWRPTEYwS3haVEVQbEV4SVgxU2NWWU51?=
 =?utf-8?B?aGgyRk9yRjE4eEErcXhxUnl4VUlDTjRBUk1qTHNLbGYxRERCQWtVNmRVOFlW?=
 =?utf-8?B?dFV0SEg1SDlpSjljazN4cFkwWDlBMXU1RHFhRHFhdEIrVnJFemZ4VGl0VlJN?=
 =?utf-8?B?d0k2Ui8rc1dMTzd3Q1lldjJwM1o2VEZRMGhlMjVXenBwbVFvVUE2MzNlTE1R?=
 =?utf-8?B?Q1BWZi9tUURVWXJnSG13S0tIUHhodzNlU0FLT1E0aWt1RFFVT1NNYTFRWTVG?=
 =?utf-8?B?ZzZ4R2hVZEtpVHdodmFZcVRNUk4zSWlKaFFyU0Y3K2RiWGRhRXpWQXhxMTdD?=
 =?utf-8?B?STVncnB6eFpYVGhGeWxKZEFVUnBQZThTaDlOdTZNblRHb1JQaTNuQ0xwUytV?=
 =?utf-8?B?V3BNbkt4aU1rNjdmYUwwWmRtOEFTQ0tEdXJWL0dnN241ZTAvNlhQWHRJZDJM?=
 =?utf-8?B?eDF2WVk3ZFVWemk2ZWdjZjZBUEhkbFM2RTdldE14N1UzTnhOOW4yZDcrSmMv?=
 =?utf-8?B?MXlFaHZNNW1PYnlxUXZVS1JnajdqbktiUjJsZE93YUhrVllUSkxaTnN2Ty95?=
 =?utf-8?B?RDgySmRTd29EWGdaZmx1SG43S1VKcGpEbklLYXY4MkZEMWtjckR4OW9ETW9w?=
 =?utf-8?B?MC9IanVWdWZIZVhkNHFJSGNLSGcyVFQ5L0huYktvWC9QdnI3cGtEN0NlRWpV?=
 =?utf-8?B?TjBRMkdOOUVsdCt4VGs2R3dKVWIvY2pQMDg1V202SnZqTXp1eVUzdmk2UUxh?=
 =?utf-8?B?YWVWcjNLSW5NU1p4YWFNbmovVWZWSG56QXJNV1FpRGN1QnJUQ05ETi92TzUw?=
 =?utf-8?B?ZTh0V3lNcnFTNUZnaGJXTVlYSmloL1dJREgxZENlakJET3lpNm8rZHBoNVo4?=
 =?utf-8?B?ZGFCdWtHYzhyaTltbGRTVXUvWkl1OEhNbGJJUlZaRUZxNTg1TjgwdTF4Wm1R?=
 =?utf-8?B?RjFJRHl3RmpTbWFuWGZzalZzYjhheFJrZm5HSkkyY2w0MWxyaEFYSUdRUkJN?=
 =?utf-8?B?YnlSSDBBNjF2bG52L0J1WHNkcTFYN1UwTVMxS3ZHeVU3L2E5eXVyR0w4d25G?=
 =?utf-8?B?Wkl3VzJQRWFPQnZPNlcvSGswT2JDWjFHRHVoT0VJalljbUQ1aG5YV0FEcks1?=
 =?utf-8?B?d2dNeWVGVndxbkhmSng3eWVBQ0tEVUE1UUZxTms0QXVvYnJ6dllYQnpwazd0?=
 =?utf-8?B?dDJpQmFCR0dSZDRrV1o3bDlGSTdZbFk1akhURkxWVUo5RDRybTFiNE9tNjhV?=
 =?utf-8?B?UG53MFR6WlMzNzIzVWxuL3MxbXVvaC9pV2xxbHNheC9taEo1R1lwYmZWdWw4?=
 =?utf-8?B?MC9LQmIwWnhoRFJza2VFUGtzWk04elllSmg4NHVpb0tCdnZXVktrZmpiSkw3?=
 =?utf-8?B?anlEK09Da09VUWtGYUxZTXZjRG9la0NaZmFZQUo4aXNuZG40TFE2c1paTTZt?=
 =?utf-8?B?YjQrK04rb0NaQy9wNFNIRkdlMTZIWHBXeVVJMEI1dHFmUmp4L3lOaFdtRnhD?=
 =?utf-8?B?aHpNUWlHYUtQR3BCbGdieGd3U0FvZkxueGJYTXA2UFdmMDhCM2w0OEh3N1Jj?=
 =?utf-8?B?TGVQTFhyc1J3cGJreTlyVURZOHMrcGpqT3grUzBoUTRuTjE1d1lzaEZqRlRh?=
 =?utf-8?B?MVE2VHNMQVh4aUxud0FZeGdXYTdzMG1ianpQYzFOOGR3bzVGQWhTWFN6QzdG?=
 =?utf-8?B?ZGMxbDBvd0YvWUVpcXlLdnNZY2JsV0dzTkFtdHNHR1BWRE0wRGwvWGNCN2Fn?=
 =?utf-8?B?eHhOL0N1cFA0cGdONUZCZWVrVE0wb1I5UzU0ZzQ3dGlYYU9CZThJVVU3UnNW?=
 =?utf-8?B?MXY3cXR3TFFjTTRhZUgvNktkK1BZcGV2cUx0QzRhM2hyNkY4K2ludFpwTWgr?=
 =?utf-8?B?akM4dzRoQ2E2TlNzcVVIdWZmWFo3TmRJd2RPcDNTV3pMNldCSi9zbFBKaFVx?=
 =?utf-8?B?RllBOHMzMmY3SCtaRFU2NGRFa0JJdXorNzZSckZUVWJMbkxpNjBIZkJTQzIx?=
 =?utf-8?B?UEpaVE5kbmRtQUJNR1pnc2NYMWQ0OWY1QWRERjExekUzNmFVdmRjRm0xeC80?=
 =?utf-8?B?K3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 049fc1d5-db76-4df2-01a2-08dc2f3fe644
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2024 22:37:47.3214
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +RfVMpKyWG4yl0jJpjamEMY6GApIqU3cFZu2knlSwgbb8GEvgH1nTQBv/c8YK7Wbs2SObspkehgNqXS6Sqsk1KZHwKDuct9FTs9U4lKSZts=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB7495
X-OriginatorOrg: intel.com


On 2/16/2024 10:42 AM, Florian Fainelli wrote:
> Up until now we have managed not to have the mdio-bcm-unimac manage its
> clock except during probe and suspend/resume. This works most of the
> time, except where it does not.
> 

This made me chuckle :)

> With a fully modular build, we can get into a situation whereby the
> GENET driver is fully registered, and so is the mdio-bcm-unimac driver,
> however the Ethernet PHY driver is not yet, because it depends on a
> resource that is not yet available (e.g.: GPIO provider). In that state,
> the network device is not usable yet, and so to conserve power, the
> GENET driver will have turned off its "main" clock which feeds its MDIO
> controller.
> 
> When the PHY driver finally probes however, we make an access to the PHY
> registers to e.g.: disable interrupts, and this causes a bus error
> within the MDIO controller space because the MDIO controller clock(s)
> are turned off.
> 
> To remedy that, we manage the clock around all of the I/O accesses to
> the hardware which are done exclusively during read, write and clock
> divider configuration.
> 
> This ensures that the register space is accessible, and this also
> ensures that there are not unnecessarily elevated reference counts
> keeping the clocks active when the network device is administratively
> turned off. It would be the case with the previous way of managing the
> clock.
> 

Good description of the issues.

> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
> ---

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>