Received-SPF: pass (google.com: domain of linux-kernel+bounces-69444-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <e77b032a-42cf-43df-809a-24b36dbcb95d@intel.com>
Date: Fri, 16 Feb 2024 14:41:10 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next 2/3] net: bcmgenet: Pass "main" clock down to the
 MDIO driver
Content-Language: en-US
To: Florian Fainelli <florian.fainelli@broadcom.com>, <netdev@vger.kernel.org>
CC: Doug Berger <opendmb@gmail.com>, Broadcom internal kernel review list
	<bcm-kernel-feedback-list@broadcom.com>, "David S. Miller"
	<davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski
	<kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Andrew Lunn
	<andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>, Russell King
	<linux@armlinux.org.uk>, open list <linux-kernel@vger.kernel.org>, "Justin
 Chen" <justin.chen@broadcom.com>
References: <20240216184237.259954-1-florian.fainelli@broadcom.com>
 <20240216184237.259954-3-florian.fainelli@broadcom.com>
From: Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20240216184237.259954-3-florian.fainelli@broadcom.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MXdpeVUyUXFIby85MmhpZllURVAva0U0MEwyOG51d3hKai9KTTNLTXZnQ1NV?=
 =?utf-8?B?WFpOclA2dVk2aUNxdG5PcVcxNkZSNnhsbjllWmlNS1VRbTQ2QmJ1NlVjSCtR?=
 =?utf-8?B?djM4bG11WEFZSTlsWUpjRU9EY0NHOFBwU1laK1hNczF4S3BSUFNTV01MQmhv?=
 =?utf-8?B?d1hFK2NDQ21oNlNWc0FNM285RGxLMHVmL3lCcWJnOW92UmpEVUlMT3hybUti?=
 =?utf-8?B?ZHBHRmRsVEgzZloyYWhIdTZ0aXBvZVAweThDTy8zMEM1MFZZRGx3cXhFL1F3?=
 =?utf-8?B?eE1sSzFMSmZkMEI4ODVIV0pYQ0tHdkhGYngzeEtxMzBSTDJBRy96V1FrSmds?=
 =?utf-8?B?a2FCYmxxUWV4UGE3NzN6bEl5MVpLcWtTKzk5S0dKdWVQN1N1MnFTU0JOMVJi?=
 =?utf-8?B?S3RPZWxOR0NseEpaUUE5WnFQZEJYOXVCaW1wWkFKelp0Nm02VVJOeERKR0s5?=
 =?utf-8?B?d0JuOFZpYzl1ajcrbW9ubzlLUjJxYnlXdzB3dmhMSzNVd05nYWVpV0xsVEw5?=
 =?utf-8?B?OVJiQUJFWit0MVcvRjNldW94OXpBRk1Bak9iRkpCVEdrZERRc1FBTnphQVkr?=
 =?utf-8?B?U21TSnc5d2lraVc0NnV1aDVsbjBwNmpKRHZKUUJkYkk4dWtoaFhjN28xNFJR?=
 =?utf-8?B?cFhmamovOVNOQnJXUi9selhxc2pjRHJhV09peXp6Y2hkQ2hWbFlKa0NZR3p5?=
 =?utf-8?B?dWVsQ05CQndEYldBclBubFdXVWhHM0hZWGRPRVY0MWV3Sm1pSW9SSTJoUWZZ?=
 =?utf-8?B?aWVoR292cUhnN2FJVlFwNHJEUGRZc1QvODZEa0tBVE5RMyt4NmNoR2dYZ0pR?=
 =?utf-8?B?WXM4U0tNWG8xVVR4dnhsZWNiOU9HRXlQb2FISE4xRzdBeEdnVWZva0M0b3Vv?=
 =?utf-8?B?MFF1RExZMWYrdVY1MUF3WXFvUTZsUzVTU001MXlNMDAwZnFHS0ZvZ1RUdjUv?=
 =?utf-8?B?NDJpZUxBMHlUTnh5TGdoTWpidXBwcnc1MS9VQW8xbkNMRCs3RDlGZEVOVWxr?=
 =?utf-8?B?VnZhTmptWkxRYlRCai9GQ0FuN3hvaFFoUk5VNFd4ajJ0RnhtdUNtczBKVFJB?=
 =?utf-8?B?SzY3VzBPVkFlRGZYZE1xVWc1MEtvNDQ3NC9YNnRKV3JnMUF4aWhTN2dBU3l2?=
 =?utf-8?B?MFcrVWg0ajJvMTZ0Rk9SYlJwNHVRbXlBdGxOTXhRbXpvdExLSWpRS0s0YnND?=
 =?utf-8?B?MmoxRjFyYjVraWI0YytxOUs2eFdZVDFFVkRUdzNaejRRMWlBTnA5aVBUMkM3?=
 =?utf-8?B?aGFsN21yVno5d2lyeENOQ1RWQUZVLy8yRGlKTVd0WFMrd0ZyOFpTYTFMcmlO?=
 =?utf-8?B?azI3ZEhjMi9hUEJQTFhaU0NMRDBDNmthV3Y1VHhvaGJhNmVUNllvbkY5TW84?=
 =?utf-8?B?S3FxRmZxbXQyaTV1UTU1SlVLM1hBRm1PYjd5TGlYUXZXVUFSc2htSGNxRENR?=
 =?utf-8?B?T2I4NkM4UlU2WHlyd0pUWDB4d3habzh6ZWtZTGdRVDA3VCtIYzBtQUIyaHhC?=
 =?utf-8?B?SmdlL09pSkRsS3VqU1VFWG9uVmRvMS9oV3U4WVJCYXc5SVlMNW14cTdlcmhP?=
 =?utf-8?B?dytxT0Zma2N2a0c0R0d1QWJpWjVBQWJZQkxFTmxFcDRKSmpXWTExQ1JwSFBL?=
 =?utf-8?B?L0F3NXF3dGhQbkU4OGhZTEZFbXowZGlXVFQyU1hUTEpSb2g3U1U0WDVGUGV3?=
 =?utf-8?B?SzdFSUpVc3dpSGY3OUpwU2lDbVVnT0RIdDRRTUZiaDdLWXYyK0FpazBBSnZR?=
 =?utf-8?B?ck1SYS9nSmVRQkcrQitlQ1Y0MHhiUjB3VmxpUVRkWGdxdm8yTlc0WE1xN2Ur?=
 =?utf-8?B?ZmFoTURDQkExMmhBenAzSzhoM2Fvcy9qeUNLU0dHZHNHejU1Y3FWN3VjUnhx?=
 =?utf-8?B?YzBNeE83WDhJcDBZdlA0MUltSFZ6M1BENUhaZThDWkxHTU9OK0VJM1p1QmZw?=
 =?utf-8?B?bDRHb1FqbXhqeXlKeUE0WW5nWDE5em1vOTFqUmlBWmRQdEFVanZaUTFZeXNq?=
 =?utf-8?B?MERQTTh4OUVRZk9FRjdObHpURHlOZTNzZDYzTkRnNHVCVUFMN21LVm43dXdM?=
 =?utf-8?B?QVc3NUpGRmxnSEg0MFlUUEI5d1I3SlZ0ck9md1VXUWtWK2xlRmROV0dITmU0?=
 =?utf-8?B?bUVFVUhxenRpN0QxOXpDR0NkNWVVSHZSUGtWSkx6QXBRVm1pR2ZTOVdOVThO?=
 =?utf-8?B?M3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c5f02319-db4d-4f16-31e1-08dc2f4060c6
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2024 22:41:12.8539
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kbuDhNZDItFn2/Q5hcHiUqACFSeLU4xW/1pI1zAWdUR08GCZXQJRwt/Eys6vDmSPEon/vn2Jhgb9NQlDqLuHnFvLdsZTjDRLHt0rNQHh6Z0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB7495
X-OriginatorOrg: intel.com


On 2/16/2024 10:42 AM, Florian Fainelli wrote:
> GENET has historically had to create a MDIO platform device for its
> controller and pass some auxiliary data to it, like a MDIO completion
> callback. Now we also pass the "main" clock to allow for the MDIO bus
> controller to manage that clock adequately around I/O accesses.
> 
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
> ---
>  drivers/net/ethernet/broadcom/genet/bcmmii.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/net/ethernet/broadcom/genet/bcmmii.c b/drivers/net/ethernet/broadcom/genet/bcmmii.c
> index cbbe004621bc..7a21950da77c 100644
> --- a/drivers/net/ethernet/broadcom/genet/bcmmii.c
> +++ b/drivers/net/ethernet/broadcom/genet/bcmmii.c
> @@ -476,6 +476,10 @@ static int bcmgenet_mii_register(struct bcmgenet_priv *priv)
>  	ppd.wait_func = bcmgenet_mii_wait;
>  	ppd.wait_func_data = priv;
>  	ppd.bus_name = "bcmgenet MII bus";
> +	/* Pass a reference to our "main" clock which is used for MDIO
> +	 * transfers
> +	 */
> +	ppd.clk = priv->clk;
>  
>  	/* Unimac MDIO bus controller starts at UniMAC offset + MDIO_CMD
>  	 * and is 2 * 32-bits word long, 8 bytes total.

Is this missing a modification of the header file to add the clk field
to struct unimac_mdio_pdata? I don't see that field in the
include/linux/platform_data/mdio-bcm-unimac.h header currently...

Oh. you included that in the first patch of the series. I see.

It feels like the series would be more natural of this was 1/3 instead
of 2/3, since the current 1/3 patch depends on this clk value being set, no?

The result of the series makes sense tho:

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>