Received-SPF: pass (google.com: domain of linux-kernel+bounces-69518-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Fri, 16 Feb 2024 17:59:09 -0600
From: Bjorn Andersson <andersson@kernel.org>
To: Chukun Pan <amadeus@jmu.edu.cn>
Cc: Konrad Dybcio <konrad.dybcio@linaro.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	Rob Herring <robh+dt@kernel.org>, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, 
	devicetree@vger.kernel.org, Robert Marko <robimarko@gmail.com>
Subject: Re: [PATCH v4 1/2] arm64: dts: qcom: ipq6018: add LDOA2 regulator
Message-ID: <cliph5zxla23bgguzk52ulxh6trl4qcggjg7hqvrg2d4qdh3a7@mq6fewwjfk2m>
References: <20240130130132.9550-1-amadeus@jmu.edu.cn>
 <20240130130132.9550-2-amadeus@jmu.edu.cn>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240130130132.9550-2-amadeus@jmu.edu.cn>

On Tue, Jan 30, 2024 at 09:01:31PM +0800, Chukun Pan wrote:
> Add LDOA2 regulator of MP5496 to support SDCC voltage scaling.
> 
> Suggested-by: Robert Marko <robimarko@gmail.com>
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
> ---
>  arch/arm64/boot/dts/qcom/ipq6018.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> index 5e1277fea725..322eced0b876 100644
> --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> @@ -174,6 +174,11 @@ ipq6018_s2: s2 {
>  						regulator-max-microvolt = <1062500>;
>  						regulator-always-on;
>  					};
> +
> +					ipq6018_l2: l2 {

I still don't see a patch that does "something-supply = <&ipq6018_l2>;",
which would imply that the main thing this patch achieves is that the
regulator framework might turn the regulator off after a while.

Shouldn't there be a user of ipq6018_l2?

Regards,
Bjorn

> +						regulator-min-microvolt = <1800000>;
> +						regulator-max-microvolt = <3300000>;
> +					};
>  				};
>  			};
>  		};
> -- 
> 2.25.1
>