Received: by 2002:a05:7412:1e0b:b0:fc:a2b0:25d7 with SMTP id kr11csp1440977rdb; Fri, 16 Feb 2024 16:53:34 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCV5/jFSbz7jgDa68hOsAZaTLq18PbiZ6vqQlxeE08WV5JqXvvL5hhlybPUa3ttHcQft4Ele7d4eYok4CVOIFYyvN9fmnch4JHtXF10/Hg== X-Google-Smtp-Source: AGHT+IGUP9USwyu8LNDhgh0CkiYaZaTpYDOh1kpgNRTEitf8mEZxGP8/jkkU13P4bKsuXykDfZOy X-Received: by 2002:a17:902:690a:b0:1d9:aa51:dc30 with SMTP id j10-20020a170902690a00b001d9aa51dc30mr5642491plk.67.1708131213902; Fri, 16 Feb 2024 16:53:33 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708131213; cv=pass; d=google.com; s=arc-20160816; b=EEJOHugkXWASCygcrXKMhpujZPtci8E7BxAxAcXwCR4XRUa2hC9LLQeHlyt+3rEX6b RSAz8SK/DPCVsK8HYaQnnVLYrGoXDhO+3dmnLFl3JH+Ra0qC+CPxrxlEr+C8+qRJah40 n+0jpIYd7sY5/HhIEdQFrXKMtjeVEjj4TmIMzcLfhBBMjS9QLjSjT/yhLsMRX3WpPZ8d a0OFE4WI36A33nvgbVB5ErnmomNk7nKvHdmf29ff4giXQQ2VBEpXgXWdrdUM6UxUfvzZ 8edeGJ9pPttV76bAG9gXm2eNUautSNFd3Ztl+AbflRY33PNvJwIKH6laWM/1K62PpV6Q Dp4w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=6ImZiREhBrMq4AWnxqY5yboGSGsxPSUPiaLAI0+rRZ4=; fh=dWiF9yA75H1aqs9gWsUd3EBPP3Gm973tCc8eTJiqNVE=; b=X6bjRLaFjxDrtaBYbOTl6Jb5Rbv4YXkIBqapCNcBB6Go9gPnjLQT7S9GvDSnkPLb54 TQQulAdm9rbuAlygcecXaBt1iYcmqAO0jghjCasHjh6HPpAHKRQ1lvw+XEmpjzaj5a5S ++sjNHigrG1Wd5szV8dX1dXnKz7oD9ni4Rl9lWRhVXEWGYYk0xSK1jQYsyimBnrCXpTy q3dABluQzw4lLbehhmZrLC30l22EcwDqUVwCize7WBgZ5TfgFT9Y2OuI1Ml3pcEZiPBi Z/q+4jCjD9TjGQvMMBafnCc+vcrVi1lSG1FR5VqEaWGfxR5F71fMHEiMyIqG/eLHxHyM m+1w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=IUmM3Oul; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-69376-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-69376-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id h4-20020a170902eec400b001db29db2645si651650plb.4.2024.02.16.16.53.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Feb 2024 16:53:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-69376-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=IUmM3Oul; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-69376-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-69376-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 5E4DDB21137 for ; Fri, 16 Feb 2024 21:50:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 454A81468FE; Fri, 16 Feb 2024 21:50:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="IUmM3Oul" Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E68491D69A for ; Fri, 16 Feb 2024 21:50:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708120207; cv=none; b=Vb6PXkv2uBRXZMol6WnmNRexCZa2OaaCO20BBMVHHmRaABAx6g8tIy+6Cz1cFPpSHpTLVj3Wh4TAvauk7ESrgwvu2g++aQUezisE0nZVn0/alYavrdEChLzqTkdv9Lg2NChYSAD0+20xcJJTP9FnTSG5wpoiTv6Np3X2ZVQQ96k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708120207; c=relaxed/simple; bh=v7qFsL5MrbSJkyhmHUaQIZpBDuVCQNP5lE4kotGMMHw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cZQJkQgLpDLmV0mN6RNbxKszfTuJZMA8/v40Qn1WTGsky5zrhei2ekaSHF2nCJenG50etP0SGs/7YJprjVo34o9/Yitb9eQdQRYeLN8Nt5cVioBhCmbBA7+63O2qi37TIeZq9XrcyG36QfVtPb6BUM3uDguKStzGp1uz8M1tWhA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=IUmM3Oul; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=6ImZiREhBrMq4AWnxqY5yboGSGsxPSUPiaLAI0+rRZ4=; b=IUmM3OulO6dKlT1g/3V5IkgGUE OegQwcNeGt+ZwWOg5bUgzPREhD/4t6JHicocHj7dGDXK++NKAuYVviF4+nUQUI//1FJfzrhQ6dJk8 cU/yU8Ju9mALmHZFFixRvRuF2c45t7t0Yr9hgdlOAQ6BWXMwV+AlbOURTG0uySseoQ58P/9uGoV6r jVOdw2ERDbNe3Jz8zKW6RXZFpPavpfHX8/xzSfaWwuYbJS+7nEMQnXbRF3IgKhRiRY1VdGsjbWtxo GQ7JJlkutKfNUwCA+54iwhhYlaVSu/n9GJ01SAzU9Zk3GOdHAENpJ0LN51jMz4gugTm4k7l7D8xwh pkniriAA==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rb65p-00000005kPR-1ZGg; Fri, 16 Feb 2024 21:50:01 +0000 Date: Fri, 16 Feb 2024 21:50:01 +0000 From: Matthew Wilcox To: Sidhartha Kumar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, apopple@nvidia.com Subject: Re: [PATCH v2 1/6] mm/migrate: introduce migrate_pfn_to_folio() Message-ID: References: <20240216211320.222431-1-sidhartha.kumar@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240216211320.222431-1-sidhartha.kumar@oracle.com> On Fri, Feb 16, 2024 at 01:13:15PM -0800, Sidhartha Kumar wrote: > +static inline struct folio *migrate_pfn_to_folio(unsigned long mpfn) > +{ > + return page_folio(migrate_pfn_to_page(mpfn)); umm, no. struct page *page = migrate_pfn_to_page(mpfn); if (page) return page_folio(page); return NULL;