Received-SPF: pass (google.com: domain of linux-kernel+bounces-69633-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240216135517.2002749-1-masahiroy@kernel.org>
In-Reply-To: <20240216135517.2002749-1-masahiroy@kernel.org>
From: Masahiro Yamada <masahiroy@kernel.org>
Date: Sat, 17 Feb 2024 10:06:56 +0900
Message-ID: <CAK7LNARFNoAUUiGMP95pTi_rSxSi5Z0HJo2kBC472f0koMr2mA@mail.gmail.com>
Subject: Re: [PATCH] powerpc: remove unused *_syscall_64.o variables in Makefile
To: Michael Ellerman <mpe@ellerman.id.au>, Nicholas Piggin <npiggin@gmail.com>, 
	Christophe Leroy <christophe.leroy@csgroup.eu>, 
	"Aneesh Kumar K . V" <aneesh.kumar@kernel.org>, "Naveen N . Rao" <naveen.n.rao@linux.ibm.com>, 
	linuxppc-dev@lists.ozlabs.org, Daniel Axtens <dja@axtens.net>
Cc: linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

+To: Daniel Axtens


Maybe, we should check if the issue fixed by
2f26ed1764b42a8c40d9c48441c73a70d805decf
came back.


On Fri, Feb 16, 2024 at 10:55=E2=80=AFPM Masahiro Yamada <masahiroy@kernel.=
org> wrote:
>
> Commit ab1a517d55b0 ("powerpc/syscall: Rename syscall_64.c into
> interrupt.c") missed to update these three lines:
>
>   GCOV_PROFILE_syscall_64.o :=3D n
>   KCOV_INSTRUMENT_syscall_64.o :=3D n
>   UBSAN_SANITIZE_syscall_64.o :=3D n
>
> To restore the original behavior, we could replace them with:
>
>   GCOV_PROFILE_interrupt.o :=3D n
>   KCOV_INSTRUMENT_interrupt.o :=3D n
>   UBSAN_SANITIZE_interrupt.o :=3D n
>
> However, nobody has noticed the functional change in the past three
> years, so they were unneeded.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
>  arch/powerpc/kernel/Makefile | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/arch/powerpc/kernel/Makefile b/arch/powerpc/kernel/Makefile
> index 2919433be355..72d1cd6443bc 100644
> --- a/arch/powerpc/kernel/Makefile
> +++ b/arch/powerpc/kernel/Makefile
> @@ -191,9 +191,6 @@ GCOV_PROFILE_kprobes-ftrace.o :=3D n
>  KCOV_INSTRUMENT_kprobes-ftrace.o :=3D n
>  KCSAN_SANITIZE_kprobes-ftrace.o :=3D n
>  UBSAN_SANITIZE_kprobes-ftrace.o :=3D n
> -GCOV_PROFILE_syscall_64.o :=3D n
> -KCOV_INSTRUMENT_syscall_64.o :=3D n
> -UBSAN_SANITIZE_syscall_64.o :=3D n
>  UBSAN_SANITIZE_vdso.o :=3D n
>
>  # Necessary for booting with kcov enabled on book3e machines
> --
> 2.40.1
>


--=20
Best Regards
Masahiro Yamada