Received-SPF: pass (google.com: domain of linux-kernel+bounces-69639-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Fri, 16 Feb 2024 17:17:20 -0800
From: Dan Williams <dan.j.williams@intel.com>
To: Ira Weiny <ira.weiny@intel.com>, Jonathan Cameron
	<Jonathan.Cameron@huawei.com>, Steven Rostedt <rostedt@goodmis.org>
CC: Ira Weiny <ira.weiny@intel.com>, "Rafael J. Wysocki" <rafael@kernel.org>,
	Dan Williams <dan.j.williams@intel.com>, Smita Koralahalli
	<Smita.KoralahalliChannabasappa@amd.com>, <linux-acpi@vger.kernel.org>,
	<linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>, Dan Carpenter
	<dan.carpenter@linaro.org>, Masami Hiramatsu <mhiramat@kernel.org>, "Mathieu
 Desnoyers" <mathieu.desnoyers@efficios.com>,
	<linux-trace-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] acpi/ghes: Prevent sleeping with spinlock held
Message-ID: <65d0092079c20_6c7452946@dwillia2-xfh.jf.intel.com.notmuch>
References: <20240206-cxl-cper-smatch-v2-1-84ed07563c31@intel.com>
 <20240214121153.00005c97@huawei.com>
 <20240214102310.7ba53f3a@gandalf.local.home>
 <20240214181200.0000500b@Huawei.com>
 <65cd3c671cf86_d552e294dd@iweiny-mobl.notmuch>
 <65cd4e1f69205_d5b4829463@iweiny-mobl.notmuch>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <65cd4e1f69205_d5b4829463@iweiny-mobl.notmuch>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?v+sZR7ABC7UJUjpzZf6Fcnz87g10KtpaIGqOhwDELRsSx27rTYYGwrZoJfVv?=
 =?us-ascii?Q?K0VAYsQJ/gMZT9A7BsX/+Zo0EmZx5Ik4HWsV1oy+aZj+yeGmDHAyMPLK1Dwp?=
 =?us-ascii?Q?CukrVaDuheNksbIthxowB6la0i/IJBp1yR5/QMREvvlobNYS4bxggvshvFqY?=
 =?us-ascii?Q?iZ5hbuyZF9pptlaGTMK0kAN/33HDnEUkoiugnXLZ4W9vIPelUcVpv33GZADI?=
 =?us-ascii?Q?aP+GxosoHa3vO4TfwDTGaZJMYw6igUW/VXHT18Btd1s22+QkvKAxDKzpx1wT?=
 =?us-ascii?Q?C4PzmSWRnszuQP8JCABe5JL0/1MFOknFQn/fjWp5IC2DnDTfE0wKo50RuCKy?=
 =?us-ascii?Q?VnuZ8HMl/FryCbuVI21ndWgwfgWlyoAyJUfA3RcVPygz8VxLP5QPiPIGcV3p?=
 =?us-ascii?Q?yawDErN45iVTxqqSkxjdFmzMG7R5o/GhAxVy7bp++F5StjJz9iCLBGHH30l+?=
 =?us-ascii?Q?ya23cfnAFHlrSA6ZJ2DNvkDngdGvZn5UEZ/T5Kv250nm03eJJC0wpwfm3zLZ?=
 =?us-ascii?Q?jSgw7IZS9ocVtkG8LQGpfZoyQ3SVlStXgIkwiGFgJctjfBMvi64AZddmXF1S?=
 =?us-ascii?Q?OMsQrIKnQQvhv9GE6Zo4suKCyllKs3usFXeoCiCEoVmAouzkM6s7tBtebWlm?=
 =?us-ascii?Q?KJExdIO3vFGD64UtKbi5G+7usyAW6Wo2hhmYX2yh9gMDUwIpmkUnz0UDJIBa?=
 =?us-ascii?Q?PjzUOMbFJ93ox0g1zl4ZJt8/lHYSkYF0wnJ/8aSVdDifEWGrePcGMQZhF0nU?=
 =?us-ascii?Q?cmeHqzJZfrdlAoDaug1wNtDgvA00zNEezJ4GLrd65dR9CI1e99ge+u5BeALf?=
 =?us-ascii?Q?RI2QlBvpFsHPsk01WW2Jgiz9ydDASSV9p3Jhov2axe9DpVaZvD1ggbntB/ZV?=
 =?us-ascii?Q?kdIHZEnu7neaL98lIuZugNBizHN75g8bPCM8kGf5bdNtWVsyNi3kYGEF0Tvq?=
 =?us-ascii?Q?bPXJwJJCDqZNHJQCSvVHnZxbk3wZbVuCU02zBW3owH219JHcUr8pEbhO8dnm?=
 =?us-ascii?Q?Nz8mqty2PaINPEW6xnPqt1ms2fvnyRvtUj2IpiNgHyk34qTWfdUthzRbLmqo?=
 =?us-ascii?Q?eUOI9h9cLnyJYH7qp8HLmsWkOh3ls0/925EHptlnOSdYCrUbVI3pDCMxAxUh?=
 =?us-ascii?Q?7rwqYhwt4lKtiG4tDBoycEfM6j64nUv20GDGFSfxqEEVdbRpb67pMqyFSOgs?=
 =?us-ascii?Q?FMLDo2FKMTXxPYN2Z5FrCYt22qL0iLJkpbIvnw9QvZUy1J1eST7Q8dEyorgg?=
 =?us-ascii?Q?LvVjJkctV+d1tYy7VwJ+dOClHZScXkqLHuRwVGRa4R+dfD93pjqUsL+tE6Wr?=
 =?us-ascii?Q?8rw4pjKmO1u05DbKx0WQ2mv68TIzlvE/nlWqXeU58jmkSDov2ibSGESDGiog?=
 =?us-ascii?Q?AHGBGwudgfMP1g75L42+CbjlE10uhpa8r72cjukbG2zljlty0x6zCAHZWIjs?=
 =?us-ascii?Q?ox1JnUyn/EpFsoABc40naGTQcqeDcMMa/Ddch/CtzzVjQmITU/M34i2UDVDB?=
 =?us-ascii?Q?UIVdv2+IsdQmz0XFFeYfhPNBe2bsOM+hKQnPTarZcJUH9EMqsGRrbLzenR5u?=
 =?us-ascii?Q?fr1yyYbKp7u1YRrtXe32TvoaVtpUXi7YDgtHze7zU/6zQO+kxKOgPHC1j+3a?=
 =?us-ascii?Q?Lw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 24080ccf-f3bd-4790-5e87-08dc2f5631cc
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2024 01:17:23.0170
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0Hilr+RgviJTU5hn0IAOFHIawqZt+FWDQ8ub1NbHnXd5PQloo/aiuTlBgbYAxR2EfW89/IX6eazewTn5EorkSsANw4xvC7DBJLFso/3mYlI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5816
X-OriginatorOrg: intel.com

Ira Weiny wrote:
> Ira Weiny wrote:
> > Jonathan Cameron wrote:
> > > On Wed, 14 Feb 2024 10:23:10 -0500
> > > Steven Rostedt <rostedt@goodmis.org> wrote:
> > > 
> > > > On Wed, 14 Feb 2024 12:11:53 +0000
> > > > Jonathan Cameron <Jonathan.Cameron@huawei.com> wrote:
> > > > 
> > > > > So I'm thinking this is a won't fix - wait for the printk rework to land and
> > > > > assume this will be resolved as well?  
> > > > 
> > > > That pretty much sums up what I was about to say ;-)
> > > > 
> > > > tp_printk is more of a hack and not to be used sparingly. With the right
> > > > trace events it can hang the machine.
> > > > 
> > > > So, you can use your internal patch locally, but I would recommend waiting
> > > > for the new printk changes to land.
> > 
> > Steven, Do you think that will land in 6.9?
> > 
> > > >
> > > > I'm really hoping that will be soon!
> > > > 
> > > > -- Steve
> > > 
> > > Thanks Steve,
> > > 
> > > Ira's fix is needed for other valid locking reasons - this was 'just another'
> > > lock debugging report that came up whilst testing it.
> > > 
> > > For this patch (not a potential additional one that we aren't going to do ;)
> > > 
> > > Tested-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > 
> > Jonathan,
> > 
> > Again thanks for the testing!  However, Dan and I just discussed this and
> > he has an uneasy feeling about going forward with this for 6.8 final.
> > 
> > If we revert the following patch I can squash this fix and wait for the
> > tp_printk() fix to land in 6.9 and resubmit.
> > 
> > Dan here is the patch which backs out the actual bug:
> > 
> > 	Fixes: 671a794c33c6 ("acpi/ghes: Process CXL Component Events") 
> 
> Unfortunately this is not the only patch.
> 
> We need to revert this too:
> 
> Fixes: dc97f6344f20 ("cxl/pci: Register for and process CPER events") 
> 
> And then revert ...
> 	Fixes: 671a794c33c6 ("acpi/ghes: Process CXL Component Events") 
> 
> ... but there is a conflict.
> 
> Dan, below is the correct revert patch.  Let me know if you need more.
> 
> Ira
> 
> commit 807fbe9cac9b190dab83e3ff377a30d18859c8ab
> Author: Ira Weiny <ira.weiny@intel.com>
> Date:   Wed Feb 14 15:25:24 2024 -0800
> 
>     Revert "acpi/ghes: Process CXL Component Events"
>     
>     This reverts commit 671a794c33c6e048ca5cedd5ad6af44d52d5d7e5.

Even reverts need changelogs, I can add one. I got conflicts trying to
apply this to current fixes branch. I think I am going to just
surgically backout the drivers/acpi/apei/ghes.c changes.