Received-SPF: pass (google.com: domain of linux-kernel+bounces-69667-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Fri, 16 Feb 2024 19:07:05 -0800
From: Dan Williams <dan.j.williams@intel.com>
To: Robert Richter <rrichter@amd.com>, Dan Williams <dan.j.williams@intel.com>
CC: Davidlohr Bueso <dave@stgolabs.net>, Jonathan Cameron
	<jonathan.cameron@huawei.com>, Dave Jiang <dave.jiang@intel.com>, "Alison
 Schofield" <alison.schofield@intel.com>, Vishal Verma
	<vishal.l.verma@intel.com>, Ira Weiny <ira.weiny@intel.com>,
	<linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] cxl/pci: Fix disabling memory if DVSEC CXL Range does
 not match a CFMWS window
Message-ID: <65d022d9b02f5_5c76294ed@dwillia2-mobl3.amr.corp.intel.com.notmuch>
References: <20240216160113.407141-1-rrichter@amd.com>
 <65cfa34b741ea_5c762946@dwillia2-mobl3.amr.corp.intel.com.notmuch>
 <Zc-k1TDk1hfvakQS@rric.localdomain>
 <Zc_b_F5TSRSBwrNZ@rric.localdomain>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Zc_b_F5TSRSBwrNZ@rric.localdomain>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Op1SWHIcKRE9+jEJ/9sKhlB7jXMQGzh+wnJdUCexIxN0CobJIkbqQtcWBqij?=
 =?us-ascii?Q?mcggMJfU+DFrdB/HQDc4vgFC7rJ8bYJNuseaI7S7iUet5ZLybMFoF036NgQi?=
 =?us-ascii?Q?MwWAuX8joNNf5QVHipPJ6Gr9r21N7hQsETNJap98aOq07fxnEe8DHx+8zgY1?=
 =?us-ascii?Q?1pKk45QgXBmUvglfPq7HIwj1K3ykNNtIxEINkptnb7ff2TbApVZaxkEU6mv9?=
 =?us-ascii?Q?/2sNAYe8H7GYr4GgmdK+xlwCic3MnB94N1PI6nk48JtoqVKofpfCJszsSDXA?=
 =?us-ascii?Q?ZNLVx1aiT4t1sIK+Q86RxGjSlFqhpyFG1agnKpTXK5w4CDNQiK8qBSZSuLbc?=
 =?us-ascii?Q?VFbegylWhsYmZ1Klm++S21zHPoYfDBmP5P7ZvbfmFrxeBXvhBqk/jIlmNOwm?=
 =?us-ascii?Q?+dRYIeEmCbmo/9AFStdczZF9dGyK6w9UVF+ny1JF0csUle8Z/ZwqfjcGab5n?=
 =?us-ascii?Q?mKgVNfqTqEjvLiogMCfMDP2UT+L7OlweyVgc9pIQohSQJLTzQHMzKxsql3Jj?=
 =?us-ascii?Q?KIVcSVwqRaQtnax0cS+wZOep7KIbt9M2PTRMQyKVAzJHerSetfQAz5NytCXP?=
 =?us-ascii?Q?bxTo/veu9LCVL04cKibQj/G8TFgcEWDkUMK2FcwnfSRLTCCUQ31rqDCPZ224?=
 =?us-ascii?Q?lTs0vBY7+rinGCNsti4VfJht9L9QPtQFyRufUOSMFzlP/wuwIbIB6g179eNn?=
 =?us-ascii?Q?S6ljKQIj8ujhWfd5/qtE0tnjh1n6/mvoP5ypUe7dQ2DEa77cBPWWOR2Eigp8?=
 =?us-ascii?Q?juFWXfrzy7gqF7p1upTWO/fKS7PH6uddi6r+xsDcAQoqjGIem72u1O5KM+iy?=
 =?us-ascii?Q?hOPZyN/+eVJn8Y5zknL1nJJ/qpqRKERRQrNTudE8Ku6o6dsOPnNKIsYJZkkt?=
 =?us-ascii?Q?4Q/ZCKjxsFqHg4jvb5WxP60InYclvo+92fKvTB9T1GqfR2CmvFnroE1Nz3hs?=
 =?us-ascii?Q?svevRrNLoQHWCqOv/QzECpqxmumHYca/QrNs+rtqTky8XnW4JxMfDpkzeHR3?=
 =?us-ascii?Q?Vlr17x/AQRWJyDlGsN9+qy1bfbeZIXNKLerIzhm5sFWKvSuckD8/kpjdJ+tp?=
 =?us-ascii?Q?upU5gymom2hCJC/KmEoFXPNTrTyphXLtOVKVAQmf/uMT0AsnWQUrtp8lbYOt?=
 =?us-ascii?Q?w8rhuEvleqsiSwA/NibM0QBego+fikqz9XEjnvJdmou2/89mBuA5Ym5D35Ge?=
 =?us-ascii?Q?GrzJegsN8uK36ERxPfF5t1wsPlqNAnrbTxx+80V5tGbtL/g8fqhEOAA0TqTC?=
 =?us-ascii?Q?9yOdW4E2FMS4meXB4nHFwNiAlq6X41jKCOTkd2zSYMPE+Q1vPzkKSZd5rR4Q?=
 =?us-ascii?Q?br8kTfrLiLCJ2U/b5KsKtcuvB/So9Ma06utVD0m0OahNGFXleMLVOoPGzj7o?=
 =?us-ascii?Q?kDzs282+vcqp5XKjfEYhbQfGv1BD4Rlm1Yf3Ljsf4bGBvK2bnxi1ZzXLsAXY?=
 =?us-ascii?Q?JaPlnsKO3oTqLIbQOxbEtnI4lThsFUTaqs/feUXadKyHvl/99tNGsZOGGFKz?=
 =?us-ascii?Q?zAY9A50ji0s6as2d+yryZMBczRMiPwEcja2SJUGadE4ixkvhGLguChfP7fHw?=
 =?us-ascii?Q?rn9KgwJJJNLsgEKxThqAEfjP2N2LII2qGHD9ohtBlSMczhP4SqjM+/ALgL37?=
 =?us-ascii?Q?4w=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5fd71501-5304-4859-b2f6-08dc2f6586b6
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2024 03:07:07.9887
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1knkt/xFRhbn8HEKuHl4oNlw+dS2aLaUaa8kO5qLAcUyMbRZAB/99aVVZRygrIlmXJB6SKIglLhwcuyuZXNjTs8VBZI8G/koDdhj241/GwQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7880
X-OriginatorOrg: intel.com

Robert Richter wrote:
> On 16.02.24 19:09:30, Robert Richter wrote:
> > On 16.02.24 10:02:51, Dan Williams wrote:
> > > Robert Richter wrote:
> > > > The Linux CXL subsystem is built on the assumption that HPA == SPA.
> > > > That is, the host physical address (HPA) the HDM decoder registers are
> > > > programmed with are system physical addresses (SPA).
> > > > 
> > > > During HDM decoder setup, the DVSEC CXL range registers (cxl-3.1,
> > > > 8.1.3.8) are checked if the memory is enabled and the CXL range is in
> > > > a HPA window that is described in a CFMWS structure of the CXL host
> > > > bridge (cxl-3.1, 9.18.1.3).
> > > > 
> > > > Now, if the HPA is not an SPA, the CXL range does not match a CFMWS
> > > > window and the CXL memory range will be disabled then. The HDM decoder
> > > > stops working which causes system memory being disabled and further a
> > > > system hang during HDM decoder initialization, typically when a CXL
> > > > enabled kernel boots.
> > > > 
> > > > Prevent a system hang and do not disable the HDM decoder if the
> > > > decoder's CXL range is not found in a CFMWS window.
> > > > 
> > > > Note the change only fixes a hardware hang, but does not implement
> > > > HPA/SPA translation. Support for this can be added in a follow on
> > > > patch series.
> > > > 
> 
> Fixes: 9de321e93c3b ("cxl/pci: Refactor cxl_hdm_decode_init()")

This patch just moves the memory-disable call from one place to another.

> Fixes: 34e37b4c432c ("cxl/port: Enable HDM Capability after validating DVSEC Ranges")

This is the proper Fixes tag.

> Cc: stable@vger.kernel.org

Added.