Received-SPF: pass (google.com: domain of linux-kernel+bounces-69672-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 16 Feb 2024 20:22:58 -0800
From: Dan Williams <dan.j.williams@intel.com>
To: Robert Richter <rrichter@amd.com>, Davidlohr Bueso <dave@stgolabs.net>,
	Jonathan Cameron <jonathan.cameron@huawei.com>, Dave Jiang
	<dave.jiang@intel.com>, Alison Schofield <alison.schofield@intel.com>,
	"Vishal Verma" <vishal.l.verma@intel.com>, Ira Weiny <ira.weiny@intel.com>,
	"Dan Williams" <dan.j.williams@intel.com>
CC: Robert Richter <rrichter@amd.com>, <linux-cxl@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] cxl/pci: Fix disabling memory if DVSEC CXL Range does
 not match a CFMWS window
Message-ID: <65d034a22e258_29b129484@dwillia2-mobl3.amr.corp.intel.com.notmuch>
References: <20240216160113.407141-1-rrichter@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240216160113.407141-1-rrichter@amd.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Nee7fvRadOHY7FEcvB2KRykYJ2a5516C3hG28QiEVR150X9B1jtkdTcYf4lV?=
 =?us-ascii?Q?s5qudwQUwhqCxvMLU/u6bDcu/uvelOFGId/rp916tJmjes8qHecK/vgldPKF?=
 =?us-ascii?Q?/00bkFUFjSki7z68989bWdE/m0U0LmM8UC7AQRYBUXUZ5ddQ3z/paD1k22oW?=
 =?us-ascii?Q?anuVhv2rfrx+8I6aqZy7y+EWLfNvLoyWkKLqgVKRQPxvRLshLfFq9QHdC57o?=
 =?us-ascii?Q?Pg+YY0JrV73vkGz1rVWBm8q88+7IB6W5PuBn8YEN3pUwTVO80ramkccOswQ5?=
 =?us-ascii?Q?N6JOmebcB9LeNJosm/mNxZVlKtoE1VKHulZSGRxpnBFLpQZ3ef9nxRB+UNoB?=
 =?us-ascii?Q?/vuckwhk4VLAuOcvbsYy8yOzZPeC+I4OvrH/NiO734FKUWTAKpvGvrooCZAi?=
 =?us-ascii?Q?2Wcd1W2AoAXbxZc8e4edzQfrf5sxhexbaM5OA67NDMKDDqodeXwEdmiGyntb?=
 =?us-ascii?Q?vi/+GHlNePXapGnya8E8LRyEHhZ/RqhaBnrbU+IlFURYBQ5gCzuKn9ZhE7cJ?=
 =?us-ascii?Q?93op0yGQ/8robPLelSn+JLVt7FqZI5VpbFVCIpSOIAO0H9uuSgAEaEvE9Ceb?=
 =?us-ascii?Q?wkVAozta0c0hWEhk5ZT55fQi4qB+6dxt39twEzI1pEyEtRjJd92Vg/GVFx4V?=
 =?us-ascii?Q?9124OF/isryysNbRhhHVikJ0hE9Gntml/HAZrIJcJ2xCTLIyFftw9xESAGoK?=
 =?us-ascii?Q?R1qxS7qKxNkeWbMeHkN7UCPa14LqBGzPZZGXrHHarkFenwWh5zjidzSyGwS8?=
 =?us-ascii?Q?xMJK+D9Znw8u7t8e3bERPY6/8Onoq9Ko7x6odWBQrhUtz8XtRlQ8y8VlBeKT?=
 =?us-ascii?Q?4oBKOpIqekKl/1zsuUd16fiO60x/W4fVh8yI2VFrHqj70qDX4fKi+BHIzo3W?=
 =?us-ascii?Q?RCXFk346tQvvj5krq2lUB5xm2dp9tQiNntPVYq5Pd9mUzI3Pa1OdjEpZw8Hr?=
 =?us-ascii?Q?4044iC2kQrAggf1uGkjjfeYQ1MMHtfxy+UaEamo4fICcXrlyyoBy7jhFDZxq?=
 =?us-ascii?Q?0EK4/qJeWf7UNwTbSHlz+Kb0eaD83Guvk+OfIb6CYqerAjEcczOZaZcIWZ7j?=
 =?us-ascii?Q?avk+N9wa4bPb5MVUlVxGXCvyks85ACCCMPqqLrBzyKX/Yim49zy4Vy3ON3Uk?=
 =?us-ascii?Q?F9sslxzk3skgQk/r/Or4KwgdwuYMAHZprcAbYLlP72s1LIEt/iJaRvtF0aBU?=
 =?us-ascii?Q?gcUUQzNfZb0E88MppiYG/9/SHEAgyebESuxWJFcDHnyG31wu8xXturF+3bUz?=
 =?us-ascii?Q?4Slyn1tH953UtirfTTTj1u1fMKaBSxowAcnTuhyn3adFbJH2y0ZqbaSje5c2?=
 =?us-ascii?Q?uKBlsj/dORHOx8D3y+WQvbAb50P/rmBq0lEjbPWW+Ss/7rAKOBxwe4w6LZdf?=
 =?us-ascii?Q?nCx68guw5fnNS+rtRk5TPQNUaaQzWaJn5rwHf4UcJ3+x7zt3sqLJmP+f0kUg?=
 =?us-ascii?Q?S9IPsq0ANdiXRvWgIyJnxyeLU+uMf9ta7TxKoQttIRYnUokbxUGw6TShOSPR?=
 =?us-ascii?Q?OOodQygXu/n60Vj/0XdvD7PR8jBrMQrrjjca/cBymyWKzmjETQ5ScC/3BZzF?=
 =?us-ascii?Q?+BzNvrd23HLv7cRLnH14g8RFTiUuRgk+TLAFUq85Yp8a1xTMELZ1PmPnhD65?=
 =?us-ascii?Q?TA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 440f89b7-9a9c-4425-9592-08dc2f702072
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2024 04:23:00.8928
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: a7AZp9foDtbi+hqKuiUxyG00XBW2xc0CJ//DtQmjTtza3iPNDvWZ0nJdbG06KssduH8G/8FGgLTxfQa1nKizdS5ze+Axm7Ba55ddHqMirh8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB7647
X-OriginatorOrg: intel.com

Robert Richter wrote:
> The Linux CXL subsystem is built on the assumption that HPA == SPA.
> That is, the host physical address (HPA) the HDM decoder registers are
> programmed with are system physical addresses (SPA).
> 
> During HDM decoder setup, the DVSEC CXL range registers (cxl-3.1,
> 8.1.3.8) are checked if the memory is enabled and the CXL range is in
> a HPA window that is described in a CFMWS structure of the CXL host
> bridge (cxl-3.1, 9.18.1.3).
> 
> Now, if the HPA is not an SPA, the CXL range does not match a CFMWS
> window and the CXL memory range will be disabled then. The HDM decoder
> stops working which causes system memory being disabled and further a
> system hang during HDM decoder initialization, typically when a CXL
> enabled kernel boots.
> 
> Prevent a system hang and do not disable the HDM decoder if the
> decoder's CXL range is not found in a CFMWS window.
> 
> Note the change only fixes a hardware hang, but does not implement
> HPA/SPA translation. Support for this can be added in a follow on
> patch series.
> 
> Signed-off-by: Robert Richter <rrichter@amd.com>
> ---
>  drivers/cxl/core/pci.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/cxl/core/pci.c b/drivers/cxl/core/pci.c
> index a0e7ed5ae25f..18616ca873e5 100644
> --- a/drivers/cxl/core/pci.c
> +++ b/drivers/cxl/core/pci.c
> @@ -478,8 +478,8 @@ int cxl_hdm_decode_init(struct cxl_dev_state *cxlds, struct cxl_hdm *cxlhdm,
>  	}
>  
>  	if (!allowed) {
> -		cxl_set_mem_enable(cxlds, 0);
> -		info->mem_enabled = 0;
> +		dev_err(dev, "Range register decodes outside platform defined CXL ranges.\n");
> +		return -ENXIO;

While testing I found this needs the following fixup:

diff --git a/drivers/cxl/core/pci.c b/drivers/cxl/core/pci.c
index e24ffae8135f..e9e6c81ce034 100644
--- a/drivers/cxl/core/pci.c
+++ b/drivers/cxl/core/pci.c
@@ -477,7 +477,7 @@ int cxl_hdm_decode_init(struct cxl_dev_state *cxlds, struct cxl_hdm *cxlhdm,
                allowed++;
        }
 
-       if (!allowed) {
+       if (!allowed && info->mem_enabled) {
                dev_err(dev, "Range register decodes outside platform defined CXL ranges.\n");
                return -ENXIO;
        }


..i.e. Linux should only give up if it does not understand an active
decode region.

Now this SPA/HPA mismatch will still cause problems later in region
creation flow, but that's a separate issue.