Received-SPF: pass (google.com: domain of linux-kernel+bounces-69740-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Sat, 17 Feb 2024 09:13:50 +0100
From: Greg KH <gregkh@linuxfoundation.org>
To: Vamsi Attunuru <vattunuru@marvell.com>
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] misc: mrvl-cn10k-dpi: add Octeon CN10K dpi driver
Message-ID: <2024021713-corrode-landline-e186@gregkh>
References: <MW4PR18MB5244844411A57790287068E5A64E2@MW4PR18MB5244.namprd18.prod.outlook.com>
 <20240216103225.1255684-1-vattunuru@marvell.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240216103225.1255684-1-vattunuru@marvell.com>

On Fri, Feb 16, 2024 at 02:32:25AM -0800, Vamsi Attunuru wrote:
> Adds a driver for Marvell CN10K DPI(DMA Engine) device's physical function
> which initializes DPI DMA hardware's global configuration and enables
> hardware mailbox channels between physical function (PF) and it's virtual
> functions (VF). VF device drivers (User space drivers) use this hw mailbox
> to communicate any required device configuration on it's respective VF
> device. Accordingly, this DPI PF driver provision the VF device resources.
> 
> At the hardware level, the DPI physical function (PF) acts as a management
> interface to setup the VF device resources, VF devices are only provisioned
> to handle or control the actual DMA Engine's data transfer capabilities.
> 
> Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
> ---
> 
> Changes V1 -> V2:
> - Fixed return values and busy-wait loops
> - Merged .h file into .c file
> - Fixed directory structure
> - Removed module params
> - Registered the device as misc device

Why register as a misc device if you don't actually use it at all?  That
feels pointless and extra code and confusion for everyone as you have
created a device node in the system that will just fail all operations
made on it.

confused,

greg k-h