Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp140877rdb; Sat, 17 Feb 2024 02:18:22 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWSLLHA0Y8dRZtPXRtGsBAdQmshkHzGYNlW2iVDG0l/shJeNq1/ETAS8Rbm3jgYM98yBRR9X5dk/AvseBKgT3pXgCfNk4bzIV3DVzIglA== X-Google-Smtp-Source: AGHT+IF1TeqxyEQpPm75eMt1Cz02r1IniRUUD9GiM1GJWhnAnGiZ5ghbmyP8JaA0HJeJGAN9Ra6i X-Received: by 2002:a17:906:a40c:b0:a3e:28ae:9311 with SMTP id l12-20020a170906a40c00b00a3e28ae9311mr569631ejz.40.1708165102642; Sat, 17 Feb 2024 02:18:22 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708165102; cv=pass; d=google.com; s=arc-20160816; b=O4DoJau9F2r8mtaxs8QrFvd/8s2EOi4H2WbSFX0BBD+OTCYjhFSRF9Kvb7fFSrsWkT Jei16wj1ngZuSRWRu+FMwMGYe6OMJBCrlZgz3pscO7illB+xAeKjW4YcEjgZLvci6vRt /ynx50x9gb1aSd5gHIJE+G3R3WEXBhBnzcY2+SJUKJnSwgAXy+Tu5U8E8duC4BMTvSC2 fceXL81N1s9l8Tj8/9jfAJwNfJ40Cojl9Kkyrxcz7AHfUyZcRezXMWE0ClqtUw+zNdG0 bSudivNV2ZWrfeu3DB0dsv6GQoyYlB5EHQyK+DHUwLDA2foYGjYmyMnM057puJLYOoZA Dnjw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=G09/RC0saxXkfUZDfkgZ+GKUad7uMZWsR5uXIihK6mM=; fh=Yhr0Hp87yf1SuDH5O7HagAGDQUGeyAfj5EY1rVZkGSM=; b=wafITL6OWOdNnviLMTovvwdD1k5Uy/mTzgYOmpNijuX4vfU2P3GSUqMxQTjtf/kvFJ 2nhU9J1FJLk6A4/x/XlMsVoHacrbraXgiv5n+xCCGOS9cMevPEMaLZUTu4drN0WtOH7o 3F3wZZW7nwHsmJwGl8E4WPoKNpKH79NygrT6SPkKZdZKuli/GPw3BiH7FbjsXrijyA8x 9S8rpQZRJwfva6X/2jYGRlKuDF4reSlvTYwAf7vq+LZ+YcP1QZLZubwF41/MI1E27GTe WD2XK5DvRh/i4euQWW8mUpuO1xUchBJuF4z4iq2VPkx2Di+9hHm6Us8bky1ASHuwy4Ow LFXw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wqqnTqQI; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-69793-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-69793-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id y16-20020a1709063a9000b00a3bb8758a4dsi704310ejd.332.2024.02.17.02.18.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Feb 2024 02:18:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-69793-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wqqnTqQI; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-69793-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-69793-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 3B6C51F21DD3 for ; Sat, 17 Feb 2024 10:18:22 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C6A801DDF4; Sat, 17 Feb 2024 10:18:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wqqnTqQI" Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2657E1DA3A for ; Sat, 17 Feb 2024 10:18:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708165093; cv=none; b=RUTmpwqbz/M52LunrZLdJ/QER77ojy1se7xlYg6/je5ix/KOlX2B+Y1cnc7QP/DfKsIglYRE04CIrhZ1iAmHmf9CKBsHfaZJsReXp/viM40b6Ladv9fUNMrhRv8T+/bjqVX6tUlSy4VxhwgkR11JGB30OIDOgmtbrQC22pOaLQw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708165093; c=relaxed/simple; bh=ZAihcYyR2hiqYsP1ptzMDqCsff3CnvHyHqm6YGpJUsE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NVGLH+nR3GaHBqpzA0lBdgnTGI0VT7bKHZSoBZ82FfmgO5ZQNfAmzXnp4/FrThkRRs6S4CXe7+YRSpk/iQv8g3a2Z+JoYVxGWXuwBFdueoXO0duJvbtpWtn9+N3hK3oXpEb9Zpagm2UYpGS3qqKiCQ+nels9v09b3UiXt/hPrec= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=wqqnTqQI; arc=none smtp.client-ip=209.85.167.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-5118290fcd8so3549484e87.3 for ; Sat, 17 Feb 2024 02:18:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708165090; x=1708769890; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=G09/RC0saxXkfUZDfkgZ+GKUad7uMZWsR5uXIihK6mM=; b=wqqnTqQIPUzqtZMABx0Bhc5UPhu+gluI8s66ernP0+thgixrVCQMrzNF+C1V9IwpGU lhLXiM/3YArEzoBxe6vryUr2uVZMIL5c13yHuIjfO1ezDtXxp8MkgabvMkW3MztdPg5v u8vqPvnu33gViWbJhroCLQWfbZkmPJCAfRl0x8Y1PY86vnSW34D4mG/b0/I1g6xoKl1a mJan4yi3PkJcTvBywOmAo6g+2+T5LhHacXplHA3DqXi3oEGJiRrF6qTp6p9RTT5D8dmK Rh+e/SUxgEIcFbADL+9aI1/ynUQZAHYu+scuUclqugrSU/SVYYREBdKzt//Pdd2HJQgI F75Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708165090; x=1708769890; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=G09/RC0saxXkfUZDfkgZ+GKUad7uMZWsR5uXIihK6mM=; b=En8RubZkuZ8uiuwCgrfIhiVJPXOa1VuS1Vb/NcGJjyP1ptNONJBTpv6SqMZpzsQgrG sDHc1COmkt+94GCBl6chQkxEBIykvqbaqg/3FVU5+iu4i9rGQ674OE3cnmq9lVkXUbW8 LGpPHukvnYQEtX2ByaUbVu8uXLKr253YWYIdg4aY+ZFcoceD5y0w4nhox6FWsiM4QQuC NRbqvKjPxx2udCgt9Vafc9dGCIE5v3lvDhSP7HfT9E2RqOYAhf9GtI2cSxi9pr7XeGqq +ZYXDGD/tNKDRmlvVWeOahUQmaUM8dl4UghBtGYdE2EJTqDLT0EKYL/8PUrnBxuV/oyz xnDg== X-Forwarded-Encrypted: i=1; AJvYcCX0IWNYgsdKn6Me2bMrxz3W2+D8pmgQyPs7UtlxNhRvu4TVIVjUqHyXkWfz6fKxmEpIvuIIs7Omw6GwkSw6wBX3x+6eetpCl6Gp5Mbu X-Gm-Message-State: AOJu0Yx8yhg/TUcaVSIe87ot2RYg0L74OJsbtsA4WP2r87Ww3gl8mqhz Pv4nsxrPrUM2jKS+WyVUNenNEZtIJA707Gb2euPvF+jBCx2maq/cxbDX2dyGph4= X-Received: by 2002:ac2:41d5:0:b0:511:9fd3:b2d5 with SMTP id d21-20020ac241d5000000b005119fd3b2d5mr4695248lfi.67.1708165090255; Sat, 17 Feb 2024 02:18:10 -0800 (PST) Received: from [192.168.0.22] ([78.10.207.130]) by smtp.gmail.com with ESMTPSA id tj1-20020a170907c24100b00a3d35bccdf0sm853812ejc.139.2024.02.17.02.18.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 17 Feb 2024 02:18:09 -0800 (PST) Message-ID: Date: Sat, 17 Feb 2024 11:18:08 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 0/4] phy: hisi-inno-phy: add support for hi3798mv200-usb2-phy Content-Language: en-US To: forbidden405@outlook.com, Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jiancheng Xue , Pengcheng Li , Shawn Guo Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , David Yang References: <20240216-inno-phy-v1-0-1ab912f0533f@outlook.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20240216-inno-phy-v1-0-1ab912f0533f@outlook.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 16/02/2024 16:21, Yang Xiwen via B4 Relay wrote: > This should be considered a dirty hack. The proper solution would be > extracting write_reg logic to a separate regmap driver. Leaving only > "write BIT(2) to address 0x6" to the PHY driver. > > The initial commit is already doing things wrong. The following patches > adding hi3798mv100 support is also very confusing. The name of the > enumeration "PHY_TYPE_x" is very misleading as if it's the phy which is > different across SoCs. But actually it's the bus (i.e. how to write to a > given address) which is different, not the PHY. I have many bounces from your emails. Please do not Cc unrelated, non-working hisilicon emails. Best regards, Krzysztof