Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754279AbXL1F26 (ORCPT ); Fri, 28 Dec 2007 00:28:58 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750806AbXL1F2s (ORCPT ); Fri, 28 Dec 2007 00:28:48 -0500 Received: from gate.crashing.org ([63.228.1.57]:55078 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751075AbXL1F2s (ORCPT ); Fri, 28 Dec 2007 00:28:48 -0500 Subject: Re: [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in From: Benjamin Herrenschmidt Reply-To: benh@kernel.crashing.org To: Linus Torvalds Cc: Loic Prylli , Robert Hancock , Jeff Garzik , Arjan van de Ven , Linux Kernel Mailing List , gregkh@suse.de, linux-pci , Martin Mares , Matthew Wilcox , Kai Ruhnau In-Reply-To: References: <4773EBB4.2020805@shaw.ca> <477414C9.3040906@myri.com> Content-Type: text/plain Date: Fri, 28 Dec 2007 16:27:26 +1100 Message-Id: <1198819646.7209.23.camel@pasglop> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 944 Lines: 26 On Thu, 2007-12-27 at 13:37 -0800, Linus Torvalds wrote: > > > Does anybody knows what was the original rational to call > > pci_enable_crs() by default? > > .. another good question. I don't think anybody expected it to be > broken, > but if this turns out to be the thing that triggers it, I think we > should > disable CRS by default. Some sane archs need CRS and do a lot of HW.. However, just testing for vendor ID being 0x0001 instead of testing all bits might be a useable workaround. > The code doesn't actually do what CRS is supposed to help with (ie go > on > to probe another device and then come back to the slow one later), so > right now it's pretty much useless *anyway*. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/