Received-SPF: pass (google.com: domain of linux-kernel+bounces-69836-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240215141321.899675-1-max.kellermann@ionos.com>
In-Reply-To: <20240215141321.899675-1-max.kellermann@ionos.com>
From: Masahiro Yamada <masahiroy@kernel.org>
Date: Sat, 17 Feb 2024 21:24:17 +0900
Message-ID: <CAK7LNAT772pZEV09nEYTLOyU_og73zPkKjjL54e8yor-tnnHtw@mail.gmail.com>
Subject: Re: [PATCH] scripts/mod/modpost: fix null pointer dereference
To: Max Kellermann <max.kellermann@ionos.com>
Cc: nathan@kernel.org, nicolas@fjasle.eu, linux-kbuild@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 15, 2024 at 11:13=E2=80=AFPM Max Kellermann
<max.kellermann@ionos.com> wrote:
>
> If the find_fromsym() call fails and returns NULL, the warn() call
> will dereference this NULL pointer and cause the program to crash.
>
> This happened when I tried to build with "test_user_copy" module.


Can you describe the steps to reproduce it?


I set CONFIG_TEST_USER_COPY=3Dm, but I could not
reproduce it.


> With this fix, it prints lots of warnings like this:
>
>  WARNING: modpost: lib/test_user_copy: section mismatch in reference: (un=
known)+0x4 (section: .text.fixup) -> (unknown) (section: .init.text)
>
> Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
> ---
>  scripts/mod/modpost.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
> index bf7c4b4b5ff4..6b37039c9e92 100644
> --- a/scripts/mod/modpost.c
> +++ b/scripts/mod/modpost.c
> @@ -1050,7 +1050,9 @@ static void default_mismatch_handler(const char *mo=
dname, struct elf_info *elf,
>         sec_mismatch_count++;
>
>         warn("%s: section mismatch in reference: %s+0x%x (section: %s) ->=
 %s (section: %s)\n",
> -            modname, fromsym, (unsigned int)(faddr - from->st_value), fr=
omsec, tosym, tosec);
> +            modname, fromsym,
> +            (unsigned int)(faddr - (from ? from->st_value : 0)),
> +            fromsec, tosym, tosec);
>
>         if (mismatch->mismatch =3D=3D EXTABLE_TO_NON_TEXT) {
>                 if (match(tosec, mismatch->bad_tosec))
> --
> 2.39.2
>


--=20
Best Regards
Masahiro Yamada