Received-SPF: pass (google.com: domain of linux-kernel+bounces-69838-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Sat, 17 Feb 2024 14:35:23 +0200
From: "kirill.shutemov@linux.intel.com" <kirill.shutemov@linux.intel.com>
To: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
Cc: "debug@rivosinc.com" <debug@rivosinc.com>, 
	"luto@kernel.org" <luto@kernel.org>, "x86@kernel.org" <x86@kernel.org>, 
	"Liam.Howlett@oracle.com" <Liam.Howlett@oracle.com>, "broonie@kernel.org" <broonie@kernel.org>, 
	"keescook@chromium.org" <keescook@chromium.org>, "bp@alien8.de" <bp@alien8.de>, 
	"mingo@redhat.com" <mingo@redhat.com>, "tglx@linutronix.de" <tglx@linutronix.de>, 
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>, "linux-mm@kvack.org" <linux-mm@kvack.org>, 
	"peterz@infradead.org" <peterz@infradead.org>, "hpa@zytor.com" <hpa@zytor.com>, 
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 3/8] mm: Use get_unmapped_area_vmflags()
Message-ID: <35rzsyepg3wx5vjsyd5n5pix2c5oo6pibzfmdvlfbpmf2mvvgy@icrlxlydgs6z>
References: <20240215231332.1556787-1-rick.p.edgecombe@intel.com>
 <20240215231332.1556787-4-rick.p.edgecombe@intel.com>
 <gs2yekj24y5jedpvpwvsfdhnr23epkpcatmwhcmyaerke7ooon@55dgxhlf5llq>
 <6d034d561dcab4300a7eb66e34e2a03aaf17ea79.camel@intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <6d034d561dcab4300a7eb66e34e2a03aaf17ea79.camel@intel.com>

On Fri, Feb 16, 2024 at 10:15:05PM +0000, Edgecombe, Rick P wrote:
> On Fri, 2024-02-16 at 14:56 +0200, Kirill A. Shutemov wrote:
> > > +unsigned long
> > > +get_unmapped_area(struct file *file, unsigned long addr, unsigned
> > > long len,
> > > +???????????????unsigned long pgoff, unsigned long flags)
> > > +{
> > > +???????return __get_unmapped_area(file, addr, len, pgoff, flags,
> > > 0);
> > > +}
> > > ? EXPORT_SYMBOL(get_unmapped_area);
> > 
> > Any reason it is not a static inline function in the header file?
> 
> get_unmapped_area() doesn't seem to be referenced from any modules. I
> don't think it needs to be exported actually. Maybe it used to be?
> 
> It could be a static inline it seems. Why are you thinking it would be
> better?

That's just what I would do for legacy interface wrapper for new function
interface. And save a function call for caller (it shouldn't matter in
this case, but still).

> I think maybe get_unmapped_area() should stay as is, static-inline
> wise, but remove the export, and the newly added __get_unmapped_area()
> should be made static. Does it sound reasonable?

Up to you.

-- 
  Kiryl Shutsemau / Kirill A. Shutemov