Received-SPF: pass (google.com: domain of linux-kernel+bounces-69852-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Sat, 17 Feb 2024 14:57:44 +0200
From: "kirill.shutemov@linux.intel.com" <kirill.shutemov@linux.intel.com>
To: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
Cc: "debug@rivosinc.com" <debug@rivosinc.com>, 
	"luto@kernel.org" <luto@kernel.org>, "x86@kernel.org" <x86@kernel.org>, 
	"Liam.Howlett@oracle.com" <Liam.Howlett@oracle.com>, "broonie@kernel.org" <broonie@kernel.org>, 
	"keescook@chromium.org" <keescook@chromium.org>, "bp@alien8.de" <bp@alien8.de>, 
	"mingo@redhat.com" <mingo@redhat.com>, "tglx@linutronix.de" <tglx@linutronix.de>, 
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>, "linux-mm@kvack.org" <linux-mm@kvack.org>, 
	"peterz@infradead.org" <peterz@infradead.org>, "hpa@zytor.com" <hpa@zytor.com>, 
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 4/8] thp: Add thp_get_unmapped_area_vmflags()
Message-ID: <652xgd4wemokoomshvncmhufwkr6o4ftzg5nrhugcchbnaiaao@jjf6dfjidwvc>
References: <20240215231332.1556787-1-rick.p.edgecombe@intel.com>
 <20240215231332.1556787-5-rick.p.edgecombe@intel.com>
 <bfvjvaeuan5ojbfleq425lajj4vfgcomgubksqpxlvqdo2g5o3@44nolzrcuea2>
 <cbc567bd38931a1fba6009c97ec935fabe15a01a.camel@intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <cbc567bd38931a1fba6009c97ec935fabe15a01a.camel@intel.com>

On Fri, Feb 16, 2024 at 10:21:13PM +0000, Edgecombe, Rick P wrote:
> On Fri, 2024-02-16 at 14:59 +0200, Kirill A. Shutemov wrote:
> > On Thu, Feb 15, 2024 at 03:13:28PM -0800, Rick Edgecombe wrote:
> > > +unsigned long thp_get_unmapped_area(struct file *filp, unsigned
> > > long addr,
> > > +???????????????unsigned long len, unsigned long pgoff, unsigned
> > > long flags)
> > > +{
> > > +???????return thp_get_unmapped_area_vmflags(filp, addr, len,
> > > pgoff, flags, 0);
> > > ? }
> > > ? EXPORT_SYMBOL_GPL(thp_get_unmapped_area);
> > 
> > Again, static inline should be fine.
> 
> Not sure if the diff might be a bit misleading here, the signature of
> thp_get_unmapped_area() didn't actually change.
> 
> If thp_get_unmapped_area() is made into a static inline, then
> thp_get_unmapped_area_vmflags() would need to be exported instead so it
> could be used in some modules. Unlike get_unmapped_area()
> thp_get_unmapped_area is actually is used that way.
> 
> Better to export the more limited version?

Okay, it is a valid point.

-- 
  Kiryl Shutsemau / Kirill A. Shutemov