Received-SPF: pass (google.com: domain of linux-kernel+bounces-69880-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID:
 <SEZPR06MB695993BA7C54A2D5B19AAB7496532@SEZPR06MB6959.apcprd06.prod.outlook.com>
Date: Sat, 17 Feb 2024 21:46:16 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH RFC 1/4] dt-binding: phy: hisi-inno-usb2: convert to YAML
Content-Language: en-US
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
 Vinod Koul <vkoul@kernel.org>, Kishon Vijay Abraham I <kishon@kernel.org>,
 Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>,
 Jiancheng Xue <xuejiancheng@hisilicon.com>,
 Pengcheng Li <lpc.li@hisilicon.com>, Shawn Guo <shawn.guo@linaro.org>
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org, Kishon Vijay Abraham I <kishon@ti.com>,
 David Yang <mmyangfl@gmail.com>
References: <20240216-inno-phy-v1-0-1ab912f0533f@outlook.com>
 <20240216-inno-phy-v1-1-1ab912f0533f@outlook.com>
 <63b3eff6-49eb-46f3-a6d9-878eddf6de53@linaro.org>
 <SEZPR06MB69593B898A42192D134B01A896532@SEZPR06MB6959.apcprd06.prod.outlook.com>
 <dfecd473-dcc1-4977-901d-6c7bb615bc97@linaro.org>
 <SEZPR06MB695983231D04A2E1947AF61896532@SEZPR06MB6959.apcprd06.prod.outlook.com>
 <712f8904-4b63-4a3b-8135-f17f41bbb501@linaro.org>
From: Yang Xiwen <forbidden405@outlook.com>
In-Reply-To: <712f8904-4b63-4a3b-8135-f17f41bbb501@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SEZPR06MB6959:EE_|JH0PR06MB7054:EE_
X-MS-Office365-Filtering-Correlation-Id: e6fbe64e-63fb-406a-f3b2-08dc2fbed53e
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	hlDwM0zymNECVKF855XsazTtOBrA37vTylM5GI2x7h8Cz+NqGNHIGL+UZO4uD/qSmHFixyVfwUeHexSmISRaHGe7yJd8Jp5C0Z7QDrXS6IxA4qyCtmjs+Z8y6RvNjTMAK4ls27JJt5OVGFyiyRUZhnBYwkbKOOnsrtUYs6wYFvw+Pr+y5PrTOGWWx/xMdafLtZmAd9ikAKmtRHah3QDhNBjBtp1j1ztvA6bV0vl6HBpkoWjfkOELlAXCekH/TG0UynmCs7MpGun+1g/qU/SUEu6D8OjHRBgKrcpyi51JKZxiVG1gBG1yEKyn/qo8rA+I5tF30SImsSv8MS6anOwj4qxvWCjVMjpeLVoV2pitOOF97SLGSq54BLn9WyLtAL+Z5app7/SMaATSTY5L7QeFfgF7N9ATYt5VFWiwI6omp2ot0QN6fQq7CViICmgJtXUYFHoKSI5sUYemUiJQ/ElrBepTM+NnJGVQVSAFKlMFOs+Mf1lwaKF4OhyrYTFiN9o4331U0bsA5hVbZ0X5hdCtYAASG1lIp+p9kf+ZMgqURVqJ5k2Lu2zMBrPiADd+uCuu
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cmFNT3VHVWxNeDd5SjJac0FBVVdHQjBRM3dpam1mdE5ydWJZakFuYXhSd1E4?=
 =?utf-8?B?dXJ4Qjk2eFN1Z3dsRFU4Q3h6UG1KVG9WdVVPNEtCT08vclc5Y0t6Z3RwYjds?=
 =?utf-8?B?Mk9uYXhNb1dRaHdoVU0yUWdERWhIUXE1ckczOVNFWXA2TTdxQWJYbGJHSExE?=
 =?utf-8?B?Ry8xNk1DU00xUWRKeGNzMFBlN3B5L1oxcHY1RHBUNGhBbkNjcFhEeWhZMTE1?=
 =?utf-8?B?dTZjQTQ5WndUWWZwRG9vYnl2c2FuTDB0RlBjZVAzdkg0VEpPT1hzN1E5amxU?=
 =?utf-8?B?NHFIVTJ3Z3NabEVLZ3p3Wm1JRldPMDlnajhmVUhpdmY4L29ZWXZHWC9iaXUz?=
 =?utf-8?B?TzNTK2FSaFBlcFVybWlUMGppb2M1WTZUL2gySVh0VmpGZW9KS2xscGs0NDVZ?=
 =?utf-8?B?dVd1L2Z5QUNWN2NpUEoyaHo5MGtWNWtKSEJCZVNMclozeS9uYmt5ODRxcmZZ?=
 =?utf-8?B?TnRXT1IrZjU4STRYWklnaVVjdzBNblczajkwWVdXNDNpeDZUdm1nNXh4Y21J?=
 =?utf-8?B?c2NnajBqZnYzOGkwR3ZLWnZseW1uRUVhTDhIaFhZUXFTbjZGSXFtRk8xaUVV?=
 =?utf-8?B?VzFkL2ZoY0JTS0hwUklkaWhvQWpQM0c3MW43eHhoQVowKzlqdTk1WVF4T0JF?=
 =?utf-8?B?aUt2b2hrRHlCSWgxQlhqbVNvTGEvTmFXc3lRSzlhc1BQSzFyVkRlcHVFNEhN?=
 =?utf-8?B?NFgwZjVITnd1d2ZScWxBK0ErRU54V3gyZHhBY3cyV3NEWDdsS1NaYjhRMUlX?=
 =?utf-8?B?a09kQlBhcnZrMzBmeHphMzdtVmZRMnN0UitIUUgyTytVT0NNK05NbTc3Rkwx?=
 =?utf-8?B?NzlTKzFGcFFoSmNkaTh6RFJIaU55ZHFYMlo3ZFliNlJiVjJIT1pRajRKWjBj?=
 =?utf-8?B?cUFPcVZGUEtENjNDYW5pY0JMZ1VkU1I1bWxURE82cEdXUHVBeWJCT0RCWGRk?=
 =?utf-8?B?dERaL3lOVXpBZG9oVWFTTWczcHc5NjRFb2taUnZPK013eXpOTXVnUm8veHhP?=
 =?utf-8?B?U1VMNXZNZjZ0bFlKd1pTdEdidUpZcWJBaWtsWk1RbEJabGdESXp4UVMydlBi?=
 =?utf-8?B?NHBnaFMzY2ljUDIvNS9jaldiU2htQlp2NGRnbWw4Qmc3Y0s4aEFLeGlheTBL?=
 =?utf-8?B?YkN5bDRIdjJGeGR0dWxTMlZ0bFJRVnZ6Z3VuUWQ5YThwdGxpVWZyN0Q2M0FW?=
 =?utf-8?B?NE8wNTh2dTRSVXJDeDJLL0NzTCtneXhxNFZKOC9TSmN4ZVVMcnpZOGtvM1Zl?=
 =?utf-8?B?dXBGRWUySU1PUm95WG1kcnEwUk5ka2dWSkdETXVabXl3MDlad0xHdXhBZ0l5?=
 =?utf-8?B?blNoaTIvanVXeFNkRFVlZDd1NmlaRkw2MVhkNDQ1U1hZSmpOMHQ4WFl6M0RU?=
 =?utf-8?B?NFFyZFBXSlZ5a2NPbUVBV0thd2ZPWjV1U3NEWEl1TEtJL3k0NVQwK0sxaE5E?=
 =?utf-8?B?Q1NaM2JDU2Q4TlYxZnhjam4zby9LcDhaSXFTMnY5U3pFUGlod2lza2FNd2ho?=
 =?utf-8?B?c2ZUZFhON0ZyZGY1QWdmL3pzakRBZkhKaTZmRFUwT3dlQmV5OHJLbTVTQ0tT?=
 =?utf-8?B?SVQxMEtldTVWei9ieHJaM3JzRXJkaE96VzliWVdCbjRvZkIyL3F2UEdLZjBz?=
 =?utf-8?B?Qk1BTy9nYnBsYTJXN3VmdnNpOUhPejR4eFY5WGs0dVpJQUZDTk5wRVRMMEpV?=
 =?utf-8?B?TzFPRHl4azh3TXRicnpkcGNnZFNJbndVekZUMWl4OVBxWE4zbGtKbG1Wd0tE?=
 =?utf-8?Q?XJure9WWX3hW5MWPNfzkcNvPNqvYbjRQt956uJQ?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e6fbe64e-63fb-406a-f3b2-08dc2fbed53e
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB6959.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2024 13:46:24.9135
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: JH0PR06MB7054

On 2/17/2024 9:39 PM, Krzysztof Kozlowski wrote:
> On 17/02/2024 11:54, Yang Xiwen wrote:
>> On 2/17/2024 6:29 PM, Krzysztof Kozlowski wrote:
>>> On 17/02/2024 11:24, Yang Xiwen wrote:
>>>
>>>>>> +
>>>>>> +examples:
>>>>>> +  - |
>>>>>> +    #include <dt-bindings/clock/histb-clock.h>
>>>>>> +
>>>>>> +    peripheral-controller@8a20000 {
>>>>>> +        compatible = "hisilicon,hi3798cv200-perictrl", "syscon", "simple-mfd";
>>>>>> +        reg = <0x8a20000 0x1000>;
>>>>>> +        #address-cells = <1>;
>>>>>> +        #size-cells = <1>;
>>>>>> +        ranges = <0x0 0x8a20000 0x1000>;
>>>>> Drop the node, not related to this binding. If this binding is supposed
>>>>> to be part of other device in case of MFD devices or some tightly
>>>>> coupled ones, then could be included in the example there.
>>>> For CV200, this binding is supposed to be always inside the perictrl
>>>> device. The PHY address space are accessed from a bus implemented by
>>>> perictrl.
>>> Every node is supposes to be somewhere in something, so with this logic
>>> you would start from soc@. What's wrong in putting it in parent schema?
>> When the ports reg property only has an dummy address (no size), it must
>> be inside the perictrl node, accessed from the bus implemented by perictrl.
>>
>> But when the ports has its own MMIO address space (mv200), it should be
>> located under a simple-bus node instead.
>>
>> So it's either:
>>
>> perictrl@8a20000 {
>>
>>       usb2-phy@120: {
>>
>>           reg = <0x120 0x4>; // this is the register that controls writes
>> and reads to the phy, implemented by perictrl. (just like SPI/I2C)
>>
>>           phy@0: {
>>
>>               reg = <0>; // the reg is used as an index
>>
>>           };
>>
>>       };
>>
>> };
>>
>> or:
>>
>> soc@0 {
>>
>>       usb2-phy@f9865000 { // MMIO
>>
>>           reg = <0xf9865000 0x1000>
>>
>>           port0@0 {
>>
>>               reg = <0x0 0x400>; // used as MMIO address space
>>
>>           };
>>
>>       };
>>
>> };
>>
>> So here is why i include perictrl node in the example. If the ports are
>> not mmio, the phy must be under a perictrl node. Or if the ports has its
>> own address space, it should not be under a perictrl node, but rather an
>> simple-bus node.
> I don't understand why you keep insisting and discussing this. You are
> adding other compatibles to this schema example, which usually we try to
> avoid. You entirely ignored my comment above and pasted DTS which is no
> related to the topic we discuss here. I did not question whether this
> can be or cannot be in some node.
okay, I can remove the parent node if it's preferred. This is simply the 
most usual example that exists in real dts.
>
> Best regards,
> Krzysztof
>

-- 
Regards,
Yang Xiwen