Received-SPF: pass (google.com: domain of linux-kernel+bounces-69977-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Michael Kelley <mhklinux@outlook.com>
To: Saurabh Sengar <ssengar@linux.microsoft.com>, "kys@microsoft.com"
	<kys@microsoft.com>, "haiyangz@microsoft.com" <haiyangz@microsoft.com>,
	"wei.liu@kernel.org" <wei.liu@kernel.org>, "decui@microsoft.com"
	<decui@microsoft.com>, "linux-hyperv@vger.kernel.org"
	<linux-hyperv@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
CC: "ssengar@microsoft.com" <ssengar@microsoft.com>
Subject: RE: [PATCH] Drivers: hv: Kconfig: select CPUMASK_OFFSTACK for Hyper-V
Thread-Topic: [PATCH] Drivers: hv: Kconfig: select CPUMASK_OFFSTACK for
 Hyper-V
Thread-Index: AQHaYOHvK5zyzBkwkUeCyKTO1/OqarEOuT2w
Date: Sat, 17 Feb 2024 16:46:04 +0000
Message-ID:
 <SN6PR02MB415758508A7BE89E0CFBD976D4532@SN6PR02MB4157.namprd02.prod.outlook.com>
References: <1708092603-14504-1-git-send-email-ssengar@linux.microsoft.com>
In-Reply-To: <1708092603-14504-1-git-send-email-ssengar@linux.microsoft.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?iPCe2RQ6u9kKXuojNCjk+o7UzaqN5EYd0uDwGFhS2ziwXoYgK6kEcu3GVxQI?=
 =?us-ascii?Q?KthP/pnQYMlkx/4ZbR+PZej7bfmKKieeXwws1BkRsG5g8pKhbwtMzz4JYJTm?=
 =?us-ascii?Q?DLJi/DmDLmogIpVl3yJn51jLpfauh3Q++c5siRkUwvGDv9hN7wEYq1LPH8Zt?=
 =?us-ascii?Q?HJiCveiEDAQlNjO2dWYxpYaCQBRcuEw+GP3s7KHDIVssvml1DOphCXPcfuvw?=
 =?us-ascii?Q?mTIf5XpKpSUNWxXnnb9mlqdq64+486A0sWdg+lFDA2c2/A0f72CjJQrfSo10?=
 =?us-ascii?Q?0M0oREezrGbeyuoYJQiWc6JmB/LaBG8/7kRBcAxeF07I1K0OREkIA6SwTzH3?=
 =?us-ascii?Q?a9wOr42shRvJKTezcPeNkyWQQbdyECf0U/OgCE678vHOEz4VyW9yiCjl4kBX?=
 =?us-ascii?Q?RH6F5wdrTjSVOVuvZPLBg0zvDxhfrs9QVPrYVbdRpWSVoUiG80YQxpaUzw43?=
 =?us-ascii?Q?Tmc320bzrYWBgVArh2DF6hM6ZKoMYkxwGQZL4RPltqPycfAQJUuIzdrAifjz?=
 =?us-ascii?Q?R6oqN8HRf1GlhRyyoLU3vWM8344DoZqMlIY8mZ725R2CWz2W46OHOmEMhbna?=
 =?us-ascii?Q?uMsTwJZMtObhgd7xLKCDrnYdh8GD8iSPytXxuVCE0IFLyYv9pQLWT87yRNmX?=
 =?us-ascii?Q?G55dH11bmP8fjz4Qq7CesQrJLNzf8MVKQ6dPwO1xurh0+1gWswb1ig6sI+tF?=
 =?us-ascii?Q?+5H6QN4Fo1HNBtdKecbBKXBjBJ1q4q5cGUU5dmCRQikRnsjldI2+QsQ+7exX?=
 =?us-ascii?Q?WKUPFjBKoqibyOvkrlHkyq1TKyM+Kw+1t/FHT1sU+4Rdxz+W/Oqpz/lcl6ih?=
 =?us-ascii?Q?+Mq2wFGEASTf0JFP+deQxXDAhy3R/khEY7EeYmOvwgDDx1a7cwRqDJpctJMu?=
 =?us-ascii?Q?rI9hV4pbjZIuRsNHSIrsie2VywSSqpsfbjNZ4rAftsZmzDHhaqTWnGnJufkp?=
 =?us-ascii?Q?LaHCQRaO8yQc8mNj0lFILEJ7Ibt2mLQLq8FR9w4F+TPx0Qv2LHD2qb1CVyqz?=
 =?us-ascii?Q?x3yh4//iYCQvBIUllS3ziaF+RNEnxFTM/GLQqOkJCtMN6MhBZUeQVY5ers+6?=
 =?us-ascii?Q?T8HDOMVihLgnnIQs1+uHQrj1hHvWFRxzlBZ6iFxvUDRTA88r4YZTsdyJOLBp?=
 =?us-ascii?Q?2KqBbIPOwjIj3YNPTBI5N6wTFKsrPhA0IrxH7CgaTfI9P7websNjgl8wwlhK?=
 =?us-ascii?Q?scjoGW3qkK6esKCujofuyy6+CsPGqsQ8gx1fyA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR02MB4157.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: 75d2280d-3ca5-41f7-2d7c-08dc2fd7ee4f
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Feb 2024 16:46:04.1928
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR02MB7462

From: Saurabh Sengar <ssengar@linux.microsoft.com> Sent: Friday, February 1=
6, 2024 6:10 AM
> To: kys@microsoft.com; haiyangz@microsoft.com; wei.liu@kernel.org;
> decui@microsoft.com; linux-hyperv@vger.kernel.org; linux-kernel@vger.kern=
el.org
> Cc: ssengar@microsoft.com
> Subject: [PATCH] Drivers: hv: Kconfig: select CPUMASK_OFFSTACK for Hyper-=
V
>=20
> CPUMASK_OFFSTACK must be set to have NR_CPUS_RANGE_END value greater than
> 512, which eventually allows NR_CPUS > 512.
>=20
> CPUMASK_OFFSTACK can also be enabled by setting MAXSMP=3Dy, but that will
> set NR_CPUS=3D8192. This is not accurate for Hyper-V, because maximum num=
ber
> of vCPU supported by Hyper-V today is 2048. Thus, enabling MAXSMP increas=
e
> the vmlinux size unnecessary.

Note that these statements apply only to x86.  arm64 doesn't have MAXSMP
or NR_CPUS_RANGE_END.

>=20
> This option allows NR_CPUS=3D2048 which saves around 1MB of vmlinux size
> for Hyper-V.
>=20
> Signed-off-by: Saurabh Sengar <ssengar@linux.microsoft.com>
> ---
>  drivers/hv/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/drivers/hv/Kconfig b/drivers/hv/Kconfig
> index 0024210..bc3f496 100644
> --- a/drivers/hv/Kconfig
> +++ b/drivers/hv/Kconfig
> @@ -9,6 +9,7 @@ config HYPERV
>  	select PARAVIRT
>  	select X86_HV_CALLBACK_VECTOR if X86
>  	select OF_EARLY_FLATTREE if OF
> +	select CPUMASK_OFFSTACK
>  	help
>  	  Select this option to run Linux as a Hyper-V client operating
>  	  system.
> --
> 1.8.3.1
>=20

I'm not sure that enabling CPUMASK_OFFSTACK for Hyper-V
guests is the right thing to do, as there's additional runtime
cost when CPUMASK_OFFSTACK is enabled.  I agree that for
the most general case, you want NR_CPUS to be 2048, which
requires CPUMASK_OFFSTACK.  But it would be legitimate to
build a kernel with NR_CPUS set to something like 64 or 256
for a more limited Hyper-V guest use case, and to not want to
incur the cost of CPUMASK_OFFSTACK.

You could consider doing something like this:

	select CPUMASK_OFFSTACK if NR_CPUS > 512

But kernel builders always have the option of explicitly
enabling CPUMASK_OFFSTACK.  That's what I see in the distro
vendor arm64 images in Azure, since there's currently nothing
that automatically selects CPUMASK_OFFSTACK for arm64.
So I'm wondering if selecting CPUMASK_OFFSTACK under
HYPERV should be added at all.  The two aren't really related.

There are recent LKML threads on enabling CPUMASK_OFFSTACK
for arm64 -- see links below for some useful discussion of the
topic in general.

Michael

[1] https://lore.kernel.org/lkml/794a1211-630b-3ee5-55a3-c06f10df1490@linux=
com/
[2] https://lore.kernel.org/lkml/7ab6660e-e69f-a64b-0de3-b8dde14f79fa@linux=
com/
[3] https://lore.kernel.org/lkml/e0d41efb-a74e-6bb5-f325-63d42358c802@gentw=
o.org/