Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp345999rdb; Sat, 17 Feb 2024 10:50:37 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUgSiMAY7B7Jog569ugIU0BvJVRKpOMOoEbuwTauUm/Z3VLlYtNtJ25HwzQZ2sk4PyAmoc6dqT6udDau0lhpGxjDWo/IhwKd+wuvKtuMw== X-Google-Smtp-Source: AGHT+IGTH0iGXTAqrZfw9qicXUJ6HLgH2LuJy+7JlEov0K0m77v6KmbBk8466bmMZT7IxchyKGYB X-Received: by 2002:a05:6a00:2d1b:b0:6dd:a072:867 with SMTP id fa27-20020a056a002d1b00b006dda0720867mr9775251pfb.15.1708195837176; Sat, 17 Feb 2024 10:50:37 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708195837; cv=pass; d=google.com; s=arc-20160816; b=UnggzOReDbWMjpBP7kM9P4ezVurhpyU6d248uk2wIxBWB6SvNIzKPloSGEo0qEIKu/ K/mCaQhc640eMy1otQcj/wQH6bLhR7fF4tTu0Hx993F0qkN0Y4T0yTWorW5IqAAZVsn3 jaX+3y/xqObvfRsdulf1cRkXnUnXjajfRbGrQt9VhgdrkAL6FwGxdyNp8FKJpqoG5Q5P 70d+P+DAL/Z7775orobR9RwPZu/21IpD9hBVo+tYJHruNcUqT759+IfKIP89n4MlD4oP giTrq4Wdn1UVkk4y+ma0B6wnge24X6FTybRbvuRtNe4wLsjcHOvsWQOkkTo8Q8aaspBR avnQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=PRXFYnP9bqBoO+cJ/HGdnYyZsgtyIdGQWvm9L/dO4p0=; fh=w5ok93khmGV7v1K7EqO4o2hifXsr4lI7ZIlmA3JDzEM=; b=mdn8ua/6zOkJoXo+leAJ2M1GlfLyx+uNUqraqqpj3SVGxPHSouM9Kj77Uz4iOEKz1S +eq6Fs0G7L03+kVb+KBeOHVNeusnFHI5OP5wE4+beK1Ijkc6UYDp/bfjffM0GB24rvWn M525J5/u7w8vuxdgsIz2t0hV2RG/y2N826LfkBLYIqcWgy/8cmJiKrOlWJTiRvEBnVwg mEbTWnQrG/7wbdMGYyMapJc1HalocLcojMMk+0e52EGq82jnxcI2cv4E+J0bigrQQAPq 4uJ6Z1UwfJR8CX6RdSRbXSBuzj+dcb8om8QIj/5gnDCYEhXJVGIHTDkqQL3kkWE/yfjU m1wQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@xff.cz header.s=mail header.b=p0kanJWR; arc=pass (i=1 spf=pass spfdomain=xff.cz dkim=pass dkdomain=xff.cz dmarc=pass fromdomain=xff.cz); spf=pass (google.com: domain of linux-kernel+bounces-70020-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-70020-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=xff.cz Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id n10-20020aa7984a000000b006e13d669353si1824250pfq.194.2024.02.17.10.50.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Feb 2024 10:50:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-70020-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@xff.cz header.s=mail header.b=p0kanJWR; arc=pass (i=1 spf=pass spfdomain=xff.cz dkim=pass dkdomain=xff.cz dmarc=pass fromdomain=xff.cz); spf=pass (google.com: domain of linux-kernel+bounces-70020-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-70020-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=xff.cz Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id B2D4A282305 for ; Sat, 17 Feb 2024 18:49:59 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7F5257E11B; Sat, 17 Feb 2024 18:49:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=xff.cz header.i=@xff.cz header.b="p0kanJWR" Received: from vps.xff.cz (vps.xff.cz [195.181.215.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1A3341A91; Sat, 17 Feb 2024 18:49:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.181.215.36 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708195790; cv=none; b=cEzZ3uvTlx905hAhzHyc9yJXkNOfQiNUksYwld/LsvjW3TP530tqMLujJH+x/LEtIVy4j7VNUny5vpkSfXNNnbKk0jlPS++i71rWYG2tcWXeZZYv2yppQMojcoLEVnyG0ZMSd914nMgmOebPq++rpF8VmEDrLhCuwSVc/OlsWQo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708195790; c=relaxed/simple; bh=P6v2JvS1OzYzht9jsA5pBiVpyCWfx3yjVjiid49u5/w=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=JTNpqS3+ro6XkZD+EHmu+S2iokblpYxJwW8U8cRk2Xs9KLOCevjiiNIwn0jLtXyaR5ccHLH27eBDlDoQ+16d40C6YO1vXPnsJYJYO8jnG36XX4tY42xiWfijPl/Up2/2qTa8gJ6CFS3BtsnRn7l2znPgsQQQ7/s+hihUi5YFf2k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=xff.cz; spf=pass smtp.mailfrom=xff.cz; dkim=pass (1024-bit key) header.d=xff.cz header.i=@xff.cz header.b=p0kanJWR; arc=none smtp.client-ip=195.181.215.36 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=xff.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=xff.cz DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xff.cz; s=mail; t=1708195786; bh=P6v2JvS1OzYzht9jsA5pBiVpyCWfx3yjVjiid49u5/w=; h=From:To:Cc:Subject:Date:From; b=p0kanJWRFlJOStFcRZd6OHuJj8qJIcMfZFEEegxQq5DwKlImYdrK+uyJIBAOKgqXr 03UvSjh3i3+1kZSwf3EDN4AEQFQxOPsfC1Ybw8wh34Bhxj83nAaSwO78S58+OSZRWQ tZRVXXOf5Dc7WiKU8u6JwRQG1rJtTgw4DynssOP4= From: =?UTF-8?q?Ond=C5=99ej=20Jirman?= To: linux-kernel@vger.kernel.org Cc: Ondrej Jirman , Sakari Ailus , Mauro Carvalho Chehab , linux-media@vger.kernel.org (open list:V4L2 LENS DRIVERS) Subject: [PATCH] media: i2c: dw9714: Fix occasional probe errors Date: Sat, 17 Feb 2024 19:49:11 +0100 Message-ID: <20240217184926.1754245-1-megi@xff.cz> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Ondrej Jirman The powerup delay was not observed during probe, leading to occasional I2C communication failures in RPM suspend callback. Power delay is properly observed in resume callback already. Signed-off-by: Ondrej Jirman --- drivers/media/i2c/dw9714.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/i2c/dw9714.c b/drivers/media/i2c/dw9714.c index cc09b32ede60..84d29bcf0ccd 100644 --- a/drivers/media/i2c/dw9714.c +++ b/drivers/media/i2c/dw9714.c @@ -157,6 +157,8 @@ static int dw9714_probe(struct i2c_client *client) return rval; } + usleep_range(1000, 2000); + v4l2_i2c_subdev_init(&dw9714_dev->sd, client, &dw9714_ops); dw9714_dev->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE | V4L2_SUBDEV_FL_HAS_EVENTS; -- 2.43.0