Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp346083rdb; Sat, 17 Feb 2024 10:50:54 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVCUGmmF+tVAoGIvpvEuSk9wFNnvB69I4O9A1K81kOq0xZ+vPsPrxbFrHujpHgnlmuIgVc6mbPnCs01w/4KqNzjVT+xjQgdNDJoadjapQ== X-Google-Smtp-Source: AGHT+IEMNRs2tQQcaQA27BOIi1fRny19nKolsTTfg2NSTu7nP+S4awLwl3ybtP3rJgzoFKTjaDaD X-Received: by 2002:a05:620a:9d4:b0:785:41a6:72c5 with SMTP id y20-20020a05620a09d400b0078541a672c5mr7905561qky.64.1708195854542; Sat, 17 Feb 2024 10:50:54 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708195854; cv=pass; d=google.com; s=arc-20160816; b=ppmxgMwGLpHLax8C6WDts3+z+LIPsja3xKLF9jXmFQGrnfkECM98DAn1q2I4hGvBj1 iO1vWRBcA2yx67rQF/QZgPvXALOUCd0ANMBecHqXEhb2kV5IAkNYbJnIY51hSD1RJVpW lsmM8MiYkLOQ/wB65p+e8S6WngBfOKbY+lPdsMJ/Sinik0WKW2aHqPK46cO3cnK8ckJ/ WWF3jwKdxusPvC4+ijj2qjYWTGlkg/mnMo7fnH2p+QTHGDGNloLfygHm5BSkO5Yjoju8 7f4Iz0XV+P/wTMEssGgRHNmhH4zEgP05cX0TXfLrMq4jU01RkitlIaUYZ5fBNVggk9jK Vvbg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:date:message-id:from:subject :content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=q7MKqP6WJR7N5/JMF5Ce5PZO+JRASR6U8oHekx5viO0=; fh=00gT1KC00gIFmFvU3oOc3VOmDltLu0SSkn6k5a07uSA=; b=SyJIL1gS4wqLDhotKJRu+a9fSMynMxwNkiHEMBMzphxExQd5YmCE+3BIgsDJ8L3bD1 l+X7oPgoMCK3YIC8YXRd6Hyx37Sx17PKMCgOXqds+7vg5OLtXlXkIr+OJWC/JEGl2nc7 OakGw2IAi+diSJCuWGD0/v4w9BXT3iXz2k5bNfRvnQxdnrzFS9f7/BiN546jOgiHADlL OSv2ho9MZuXvfshajeapnAYQOv+8iiAwpiHY1mDgTfZmG6CM9e3JEC2yqEBlYgZOFCBx 92LRJKmAKVl3RHTNKxRyifkPRRs0+YlvekDpIYvKx1yZXshKeBANaYbrssCx/tlxAidc wruQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uUcVBUDU; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-70021-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-70021-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id br19-20020a05620a461300b00786ae5c2189si2916912qkb.704.2024.02.17.10.50.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Feb 2024 10:50:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-70021-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uUcVBUDU; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-70021-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-70021-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 8977B1C22158 for ; Sat, 17 Feb 2024 18:50:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 766387E119; Sat, 17 Feb 2024 18:50:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="uUcVBUDU" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A8241E498; Sat, 17 Feb 2024 18:50:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708195826; cv=none; b=ZFqowSjlb8AOYpMVNxYOyPfWp0sIdQgjLW9M8k1EQY5znYZKECfFTpzAFZax/J4HJ6hHmT4U8NJzVEbWlZrud78/f2Yd/1yUIgWc0fi4IEkAmd1MZJ0j8IOpNF1piTunAGr4BMzRMFml7sc5mKeEv3fqNQZwDW5n6xdQa4e4F98= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708195826; c=relaxed/simple; bh=tDHoBtrkxZ/0jzu6S3iKZ2VIA9W0xR3UxtvM71RgyeQ=; h=Content-Type:MIME-Version:Subject:From:Message-Id:Date:References: In-Reply-To:To:Cc; b=jPrUpynPYWcwCNKkHg04fNyHEMfi4UZabVjjUUcOsElJtNFHoroPQTMJedCLVK45VA5y4dappYxSwSsM24vZh+Uaqu7P1bkkjsnpe+GBiSfaqUg8/gT5RKyAWWKLzfFDkMsGwDfS8rLIHfRTAmVL4TN7Mzj835PbNkW7y1lKj9Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=uUcVBUDU; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPS id C59E3C43390; Sat, 17 Feb 2024 18:50:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708195825; bh=tDHoBtrkxZ/0jzu6S3iKZ2VIA9W0xR3UxtvM71RgyeQ=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=uUcVBUDUh/5Qu6NcsXej5qk2ggMnUtyzEFashF4WpcCPX9ABF2o6VQkc/gokvfcRk Lq07Ojgiy2ippKfN+pgDxJbpF0w861xfTYr80XgImvSESf7CXpzdk/g9B+UrNtf7MX 5PO2EqNj+0X9AqmGDItvvGHZb9l2Q/TWMNImwHmwrVgIDYqo36AEZ6azuR7x4UlQZa uhcDpUVRbkEmsmJgROzGJGWs+Sgil+JonBoKxUrpP0Cl5pCmEeUgF1vvGoWTx/fyFx p9CkdaG6Lpx7vkKWBqMrbTRfRCg6Uz/kt6F7g/THmw0hZeMuiNhPil78Dso/36mRG3 lbzoMRS9bvBGg== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id ADF62C04E24; Sat, 17 Feb 2024 18:50:25 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net v2] net: stmmac: Fix incorrect dereference in interrupt handlers From: patchwork-bot+netdevbpf@kernel.org Message-Id: <170819582570.11703.17257609518253001084.git-patchwork-notify@kernel.org> Date: Sat, 17 Feb 2024 18:50:25 +0000 References: <20240214092718.331891-1-p.sakharov@ispras.ru> In-Reply-To: <20240214092718.331891-1-p.sakharov@ispras.ru> To: Pavel Sakharov Cc: horms@kernel.org, alexandre.torgue@foss.st.com, fancer.lancer@gmail.com, joabreu@synopsys.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, mcoquelin.stm32@gmail.com, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org, khoroshilov@ispras.ru Hello: This patch was applied to netdev/net.git (main) by David S. Miller : On Wed, 14 Feb 2024 12:27:17 +0300 you wrote: > If 'dev' or 'data' is NULL, the 'priv' variable has an incorrect address > when dereferencing calling netdev_err(). > > Since we get as 'dev_id' or 'data' what was passed as the 'dev' argument > to request_irq() during interrupt initialization (that is, the net_device > and rx/tx queue pointers initialized at the time of the call) and since > there are usually no checks for the 'dev_id' argument in such handlers > in other drivers, remove these checks from the handlers in stmmac driver. > > [...] Here is the summary with links: - [net,v2] net: stmmac: Fix incorrect dereference in interrupt handlers https://git.kernel.org/netdev/net/c/97dde8402633 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html