Received-SPF: pass (google.com: domain of linux-kernel+bounces-70040-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <102e5c65e07ebdade5400ca711fba131a37027a8.camel@perches.com>
Subject: mediatek: media: Missing alloc null test
From: Joe Perches <joe@perches.com>
To: Tiffany Lin <tiffany.lin@mediatek.com>, Andrew-CT Chen
	 <andrew-ct.chen@mediatek.com>, Yunfei Dong <yunfei.dong@mediatek.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>, Matthias Brugger
	 <matthias.bgg@gmail.com>, AngeloGioacchino Del Regno
	 <angelogioacchino.delregno@collabora.com>, linux-media@vger.kernel.org, 
	linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, 
	linux-mediatek <linux-mediatek@lists.infradead.org>
Date: Sat, 17 Feb 2024 11:44:56 -0800
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
Precedence: bulk
MIME-Version: 1.0

There's a missing NULL alloc test here:

It doesn't appear obvious what a proper fix is.

diff -u -p ./drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_fw_sc=
p.c /tmp/nothing/drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_f=
w_scp.c
--- ./drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_fw_scp.c
+++ /tmp/nothing/drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_f=
w_scp.c
@@ -79,7 +79,6 @@ struct mtk_vcodec_fw *mtk_vcodec_fw_scp_
 	}
=20
 	fw =3D devm_kzalloc(&plat_dev->dev, sizeof(*fw), GFP_KERNEL);
-	fw->type =3D SCP;
 	fw->ops =3D &mtk_vcodec_rproc_msg;
 	fw->scp =3D scp;