Received-SPF: pass (google.com: domain of linux-kernel+bounces-70132-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID:
 <MA0P287MB28223C65C1355D74E1348854FE522@MA0P287MB2822.INDP287.PROD.OUTLOOK.COM>
Date: Sun, 18 Feb 2024 09:22:21 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH RFC] riscv: dts: sophgo: add sdcard support for milkv duo
To: Jisheng Zhang <jszhang@kernel.org>, Ulf Hansson <ulf.hansson@linaro.org>,
 Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>, Adrian Hunter <adrian.hunter@intel.com>,
 Inochi Amaoto <inochiama@outlook.com>
Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
References: <20240217144826.3944-1-jszhang@kernel.org>
From: Chen Wang <unicorn_wang@outlook.com>
In-Reply-To: <20240217144826.3944-1-jszhang@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: MA0P287MB2822:EE_|PN0P287MB0921:EE_
X-MS-Office365-Filtering-Correlation-Id: b14ec5f8-79e3-475f-7d06-08dc30200fbd
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	zeXnT2RCA6Nt5aRuGC2rhDyha/ZQ7ot1ScGATX3DpxeS3yNtn4cAUs5xtJqGmA23MmBk+QDGDh8R/c7nJstiSJPomCFv68Tdo4rDTMTA6ka2Cvne7iPzXZYhFuJsdXo3qygNDcxHvJZtnLiFXuKZfqpFg1alc7QwYdp9eB2lUho37STHPF3bFoF6gdXapJPevQhPRh7YcDKHBJous5y0L3jtJadcR0r9RYpG11k66UQ8tSCUuTdyhpoqsHqrwjh/1URi/wnpDPNYCyqAIahc1qUmb8HusVAMRBSKRUqD0XQ7UtOyS7XBMpJtfhxEXna5bIoIUaNkpz4HKhJVCkxwTbwrYp31RIPhfghbrGOCAO8HkAOx6QnEuuJS2IpyvJFB0j56tBqhmqQOCeJ/8xGuwNzv4oPsdhXgrwPNCiDw/26UWxdGC0i88Rqkby7BcGbtZ0ekhGHaT+uPaHjokA6e8V3fm4In8uboO2s5dJF16Trjz3g3GKC4llbhdbKhGG0yGBhWrTVgiRpQ+rB/1dhedASMF6X+7e0j79cGG2obdQHYVOs3A2Qe3UI99Lgvdv2bpyWAjyy+tfHtigvEqCQNI32mqQL0t68rwPJCfFjW//8=
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WGw3b0ZES1hGWUdXdnl3VmdEVWMrb0JIZmIvOHJMTzV2T0hDRXdMbVRrNFFv?=
 =?utf-8?B?SXJXUXZmOUhrSW1oYUZhTVpFdzJOclV4STV5TTRhbThnOHhIdG00SmRLVmFH?=
 =?utf-8?B?eXR0UlpzaGtDV2I5bGxOaFY5OE9lWFNoZFVqU0I0R0x4K3pGMXpka21sL1Ez?=
 =?utf-8?B?ZDJ6clV5ck8xTjNtM0EyR1UwWnREbUNNVytxV3pmWmxwejFldUdxNmRKOFk5?=
 =?utf-8?B?Q3VsVTFxSmFjZXBvUXZaYkRoTzNJUElxTWh5Q2JhUFJaWmxEd2tkMHlPOHh4?=
 =?utf-8?B?RzdNMmRUckZyT3FzemtPZmlJSnFIZkNtdWtRczZmc3p4UFJFelEwU0xtVTBY?=
 =?utf-8?B?ZFVPRlJJb1BoV0hNWjAwK3RjYWFlREJLMVZlaElCRGttOElRTEJoeUJFQ3pl?=
 =?utf-8?B?aG9Sa1RRb0cxWjRabjZwUWgzTlZxcjFOQVVXdVRFQ25CNTgxWGZ2SitiYkZX?=
 =?utf-8?B?NU9iRkE3S01TUkYwczI0Q09uUWpmOVEycDhUM3BlUkNTQldBQThtaDIyeHd3?=
 =?utf-8?B?ZTJnQUhtUDhVK0RkcWIwQWtjeGNNblB0cnFrWWNvYWlNUEhpZERQbzBjSmh6?=
 =?utf-8?B?aHR4aWdRUjByVytSQkxzRnhMNE5IZzljQ0RmY05Mb3c5R3REOVQvaFlITzRq?=
 =?utf-8?B?b2NETEZqMThCMWRjM1QxdnIwc1FtSWM5eDNYR0k0UkkyTjNPb1JVZ3RhOTh6?=
 =?utf-8?B?WEFQZFFHeFQvcUNqNzFVOHRKM29Fb2V5S1E2WFVRVnZ3MHQxZithRVorMUN3?=
 =?utf-8?B?SEdsWXZJRWltVEtmcXFNemtLbElZOERSb3FXa25HVVJaTWYxOVVzL1VPMzZZ?=
 =?utf-8?B?NUxXVzBTcG9BVGhBb0lqSGl4UzRUOTZPZ1RqblkrVG91RFVaTFJpTHRHVndX?=
 =?utf-8?B?MUZvY2IxajRrQnFuRkphbXB2eFk1Ni9sQnRyWnkzWENteStRQlhoRTJHNTFz?=
 =?utf-8?B?dHhmeGFmVVFVZEhXWHc0L1JkYk1SeEljTGVQY3ZOOFN1S1dlajIzVkhwWW90?=
 =?utf-8?B?NGdVelJmUTU4Y1ZpSnR5TUgrSkt4Mi9KeUQ3YjBTcjNxMk50alc5dEluc1F5?=
 =?utf-8?B?TmZlWCtxSmV0Q2FyanVHdlppWVI0bkxnN1doOEdGTGwveStjTzhEeWoybDND?=
 =?utf-8?B?WXJFaVQ1cm9yay9TSHBGUDdseVdaNFk0b2dlWS9XNFQwcFhxQkR1NnZSMTlP?=
 =?utf-8?B?N1RIZGw1bG1wKzZsNGUyVXFMRERGbnhNaXIyTG5QREpKZHpkUkFzSUo5WVNX?=
 =?utf-8?B?UXVoQVBZNHdWUHpQT2lYVzY2Mzl2eGlkeWVUSXo4eCt5bTNkOURKeGlET0ZH?=
 =?utf-8?B?RzQ2eFA5RmtHZ0RFWWUwU0M3SkltbTFmaDFxbGY4TnRhcjB5N2pvdlBKU1ZW?=
 =?utf-8?B?Nk02NG51SzJRYnpkRHBiV0kwMjFGcXhqNzIvZ2xlbzg3T2Z3MVc1N1ZvaTU2?=
 =?utf-8?B?c2ExaWJvRm00bEs3eUtXMXVnYU1TVDhmRXRxeTdDZUZJZmJWbWZtcHJFdzFJ?=
 =?utf-8?B?N1FmM1M2YUdCYVl2STJWQ0lQclZxZFJQNGF3djJ4cndZYmZKWUtoSVlKOTVE?=
 =?utf-8?B?S3cwc01rcXorcWpnaG9vclFITW0rSzN2QzIraERDYk9XRmJZNGlnZTZDdkk2?=
 =?utf-8?B?M0pOOXhzcmlwV2I4ejcxN2NUcWRreWNocXlUa1VFQmxmK2NBSnRlNmR6eEFV?=
 =?utf-8?Q?/UCB4uauvmPcSCZrdvEv?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b14ec5f8-79e3-475f-7d06-08dc30200fbd
X-MS-Exchange-CrossTenant-AuthSource: MA0P287MB2822.INDP287.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2024 01:22:25.7692
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PN0P287MB0921

Adding Inochia.

hi, Jisheng,

For changes under arch/riscv/boot/dts/sophgo/, please looping Inochia 
and me.

FYI: 
https://lore.kernel.org/linux-riscv/IA1PR20MB4953B158F6F575840F3D4267BB7D2@IA1PR20MB4953.namprd20.prod.outlook.com/

Thanks,

Chen

On 2024/2/17 22:48, Jisheng Zhang wrote:
> Add sdhci dt node in SoC dtsi and enable it in milkv duo dts.
>
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> ---
> Since cv1800b's clk support isn't in, this patch uses fixed dummy clk
> and just RFC, I will send formal patch after clk support is ready.
>
>   .../riscv/boot/dts/sophgo/cv1800b-milkv-duo.dts |  8 ++++++++
>   arch/riscv/boot/dts/sophgo/cv18xx.dtsi          | 17 +++++++++++++++++
>   2 files changed, 25 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/sophgo/cv1800b-milkv-duo.dts b/arch/riscv/boot/dts/sophgo/cv1800b-milkv-duo.dts
> index 3af9e34b3bc7..94e64ddce8fa 100644
> --- a/arch/riscv/boot/dts/sophgo/cv1800b-milkv-duo.dts
> +++ b/arch/riscv/boot/dts/sophgo/cv1800b-milkv-duo.dts
> @@ -33,6 +33,14 @@ &osc {
>   	clock-frequency = <25000000>;
>   };
>   
> +&sdhci0 {
> +	status = "okay";
> +	bus-width = <4>;
> +	no-1-8-v;
> +	no-mmc;
> +	no-sdio;
> +};
> +
>   &uart0 {
>   	status = "okay";
>   };
> diff --git a/arch/riscv/boot/dts/sophgo/cv18xx.dtsi b/arch/riscv/boot/dts/sophgo/cv18xx.dtsi
> index 2d6f4a4b1e58..405f4ba18392 100644
> --- a/arch/riscv/boot/dts/sophgo/cv18xx.dtsi
> +++ b/arch/riscv/boot/dts/sophgo/cv18xx.dtsi
> @@ -4,6 +4,7 @@
>    * Copyright (C) 2023 Inochi Amaoto <inochiama@outlook.com>
>    */
>   
> +#include <dt-bindings/gpio/gpio.h>
>   #include <dt-bindings/interrupt-controller/irq.h>
>   
>   / {
> @@ -45,6 +46,13 @@ osc: oscillator {
>   		#clock-cells = <0>;
>   	};
>   
> +	sdhci_clk: sdhci-clock {
> +		compatible = "fixed-clock";
> +		clock-frequency = <375000000>;
> +		clock-output-names = "sdhci_clk";
> +		#clock-cells = <0>;
> +	};
> +
>   	soc {
>   		compatible = "simple-bus";
>   		interrupt-parent = <&plic>;
> @@ -175,6 +183,15 @@ uart4: serial@41c0000 {
>   			status = "disabled";
>   		};
>   
> +		sdhci0: mmc@4310000 {
> +			compatible = "sophgo,cv1800b-dwcmshc";
> +			reg = <0x4310000 0x1000>;
> +			interrupts = <36 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&sdhci_clk>;
> +			clock-names = "core";
> +			status = "disabled";
> +		};
> +
>   		plic: interrupt-controller@70000000 {
>   			reg = <0x70000000 0x4000000>;
>   			interrupts-extended = <&cpu0_intc 11>, <&cpu0_intc 9>;