Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp457663rdb; Sat, 17 Feb 2024 17:46:47 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCU3klUjOCBRQ3gIRimo/Vpn7oBjeCGeFOaafGLM4HgZV3CF45uvVuQylm3yZ8KFZbPyF0xYohjJU6ex2Husvw7Yrn7V5M2it8G+H3hQcA== X-Google-Smtp-Source: AGHT+IHSbr3qcu+NJMSfMLC188o5z9s2yEJZSfGf045KKcSUQlKwJfoEfmybz6+mBgdK03bdx0RU X-Received: by 2002:a05:6a21:3417:b0:1a0:9394:1e9a with SMTP id yn23-20020a056a21341700b001a093941e9amr1680151pzb.25.1708220807549; Sat, 17 Feb 2024 17:46:47 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708220807; cv=pass; d=google.com; s=arc-20160816; b=Bjm4MMfN05nX/PXDsGKuvi71X/v8Kopg16IR/7vKC/T9ff2CBc9BBQJlW286IeMYeQ cB+sMSslSIHa7Fhcxjl9B5yBGudaoWj88DzM/FS+zWCG06TJR77ngGUzo0QYgbcV5g9y +j8DF+ajXC881iNNl/AxpuK+INVJVcLI0b8f5BycV1rhFwMmeocueieKFOYmy0HLMFAr o7rd9oDH1uNDF3Kw2ORFE2eQyuTyGPfCx38UV6ji/ykKXDDduCQzHzOkm2cjNIhtrZKG rX2rK2aVuvitbVjDTho/kchVa1tktTqTLwsTFdROctvb4q0uQqmmK1udk5resK1Zyxgg bLQg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:user-agent:date:message-id:from :references:cc:to:subject; bh=UWu2/+2dWSlcqdCh6i9R6Wz33B+sYIjP917mKOKeic8=; fh=hpgXmDcHmoAP7QiZFPl4dBcSK4LHxEp3OCRhZY9sl74=; b=ua7OXnaFyBqnU0kRp6aFm71Gox0uRgq6p97QnOA93eEyUUOMkU9g0TbG2VjYeWOeo9 XTatPHR4GYSJxF814PsSSfO2/Y4NpjfMiNNVcOiMtYZJlFXrU+yOJtnjsSudZ7x+uBTt YMqtXP9Vs76AvrVabEU6b2MbUux/5mIKBs8Ql4hN3RHJj9dq+kLanJaXrLafRs7mMY5m kfFXqK6Is67SEK78FGAeRPgNPQ3qlNK7pLmyRsXCbezgJr4ugybaXh2XafsIN4JUOkY7 PcEpDGpWuwt1nZjb+ggwTnn2a3HpLwd08d53ifGNgZath9FOqYToCMPJdLBKxcHIRpY9 Sbqw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=huaweicloud.com); spf=pass (google.com: domain of linux-kernel+bounces-70141-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-70141-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id u14-20020a170902e80e00b001d720fa139esi2228635plg.17.2024.02.17.17.46.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Feb 2024 17:46:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-70141-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=huaweicloud.com); spf=pass (google.com: domain of linux-kernel+bounces-70141-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-70141-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 1ADF5281215 for ; Sun, 18 Feb 2024 01:46:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D6A49184D; Sun, 18 Feb 2024 01:46:36 +0000 (UTC) Received: from dggsgout12.his.huawei.com (unknown [45.249.212.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10488139B; Sun, 18 Feb 2024 01:46:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708220796; cv=none; b=ozxPjlZ624F6AoQtZ177bph78ZwlrT9q7pKukH7mAEUjCtKGt1Qrxy/mCqDJft2YrjT7Z4gBNEOXe2+l4MULRX2QbhGvDwl1VrDXfE5jHBnu7fk0S/7ySZC06nQQeEitwLkgftDrFUMgOoZkPzfkIEENbMohYUwVwToxIQxZPb4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708220796; c=relaxed/simple; bh=UWu2/+2dWSlcqdCh6i9R6Wz33B+sYIjP917mKOKeic8=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=qQqK5AFdXMex6VbRkNxMKflF+6StxtbewbfJ+WsclRgxY9+6gncECHeCUQs1+BRgehkQstDtQo9Edp1YEcEfpZBueaJGDwVBq5XY5rxyEhxyQHthDK0hRY+qkHg5am5BqGVRqNSQEDTBXhmbifU/txtnzbuuZJpuuxMb8ot15ko= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com; spf=pass smtp.mailfrom=huaweicloud.com; arc=none smtp.client-ip=45.249.212.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huaweicloud.com Received: from mail.maildlp.com (unknown [172.19.163.216]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4TcpRj410Lz4f3jXS; Sun, 18 Feb 2024 09:46:25 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.112]) by mail.maildlp.com (Postfix) with ESMTP id 673291A0199; Sun, 18 Feb 2024 09:46:30 +0800 (CST) Received: from [10.174.176.73] (unknown [10.174.176.73]) by APP1 (Coremail) with SMTP id cCh0CgAX5g50YdFlQPNmEQ--.14444S3; Sun, 18 Feb 2024 09:46:30 +0800 (CST) Subject: Re: [PATCH v5 01/14] md: don't ignore suspended array in md_check_recovery() To: Xiao Ni , Yu Kuai Cc: mpatocka@redhat.com, heinzm@redhat.com, blazej.kucman@linux.intel.com, agk@redhat.com, snitzer@kernel.org, dm-devel@lists.linux.dev, song@kernel.org, jbrassow@f14.redhat.com, neilb@suse.de, shli@fb.com, akpm@osdl.org, linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, yi.zhang@huawei.com, yangerkun@huawei.com, "yukuai (C)" References: <20240201092559.910982-1-yukuai1@huaweicloud.com> <20240201092559.910982-2-yukuai1@huaweicloud.com> <64d27757-9387-09dc-48e8-a9eedd67f075@huaweicloud.com> From: Yu Kuai Message-ID: Date: Sun, 18 Feb 2024 09:46:28 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-CM-TRANSID:cCh0CgAX5g50YdFlQPNmEQ--.14444S3 X-Coremail-Antispam: 1UD129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UjIYCTnIWjp_UUUYk7AC8VAFwI0_Xr0_Wr1l1xkIjI8I6I8E 6xAIw20EY4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM28Cjx kF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW5JVW7JwA2z4x0Y4vE2Ix0cI8I cVCY1x0267AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87 Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE 6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72 CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7M4II rI8v6xkF7I0E8cxan2IY04v7Mxk0xIA0c2IEe2xFo4CEbIxvr21l42xK82IYc2Ij64vIr4 1l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK 67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r4a6rW5MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI 8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r4j6F4UMIIF0xvE42xK8VAv wI8IcIk0rVWrJr0_WFyUJwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I 0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjfUOmhFUUUUU X-CM-SenderInfo: 51xn3trlr6x35dzhxuhorxvhhfrp/ Hi, 在 2024/02/18 9:33, Xiao Ni 写道: > The deadlock problem mentioned in this patch should not be right? No, I think it's right. Looks like you are expecting other problems, like mentioned in patch 6, to be fixed by this patch. Noted that this patch just fix one case that MD_RECOVERY_RUNNING can't be cleared, I you are testing this patch alone, please make sure that you still triggered the exactly same case: - MD_RCOVERY_RUNNING can't be cleared while array is suspended. Thanks, Kuai