Received-SPF: pass (google.com: domain of linux-kernel+bounces-70150-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Peng Fan <peng.fan@nxp.com>
To: Sudeep Holla <sudeep.holla@arm.com>, "Peng Fan (OSS)"
	<peng.fan@oss.nxp.com>, "sboyd@kernel.org" <sboyd@kernel.org>
CC: "cristian.marussi@arm.com" <cristian.marussi@arm.com>,
	"mturquette@baylibre.com" <mturquette@baylibre.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-clk@vger.kernel.org"
	<linux-clk@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH V4 2/2] clk: scmi: support state_ctrl_forbidden
Thread-Topic: [PATCH V4 2/2] clk: scmi: support state_ctrl_forbidden
Thread-Index: AQHaTFmmql8ovfOyiECAB0+XRIDNZrDnQZ8AgChHR/A=
Date: Sun, 18 Feb 2024 02:19:45 +0000
Message-ID:
 <DU0PR04MB941784A5A667756BD1CC584288522@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20240121110901.1414856-1-peng.fan@oss.nxp.com>
 <20240121110901.1414856-2-peng.fan@oss.nxp.com> <Za-fTES4owsmmxgO@bogus>
In-Reply-To: <Za-fTES4owsmmxgO@bogus>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?D8JflmW59l9yVHdTsCwkFBiEFQ2bNvQ3l7i0oApOncJq+AMN8ACRZp0f7/tZ?=
 =?us-ascii?Q?hH31AUyl/kc/Nl/QGo8ao/o2aw7NZ3ooFX+cPoDn2L5YP9XYYabdKUArprVL?=
 =?us-ascii?Q?vjLdmhkqXwbBMDdEITXYFzg7QQnlSBcwpBe2+QhJqcQMQniL6XEkbZSvV3NY?=
 =?us-ascii?Q?EUUIC3rm73RZ+O/2NYeLDrSSXQqdwm8/DD8z2w76iHMu0YGbNLFzoiSFkUQb?=
 =?us-ascii?Q?ohmb5vaL+VC0uzoyl98929vG1TAhAyCT/2lz6UEfMhRyhnHhPYTBoaM/0wRm?=
 =?us-ascii?Q?zYYAmrKhrgHdZSW1kdp1atMZsCzIja0nq7hQi3f/gpkeQcc9d/3kSMiuyjRY?=
 =?us-ascii?Q?m+FW+AxXvbqIzI3OayBfmHRJzqRcJgj2G/ZKe4owiU86tvQq+4rIurQhVHJn?=
 =?us-ascii?Q?u5fBJNIzwcd/O87bUswS//xZRot4EFfkBm06UcvOLTKg6sQNLMQj5onRytGb?=
 =?us-ascii?Q?vt5yN1czd/F1bQ2Huv9ZPLlZLnk5ka7dgUbDQBSqcia+QUAEEGwNtb3I1VXq?=
 =?us-ascii?Q?5eVTr2Y61Wv5wqJ8gH561yrzr1tMTxEoEqytxrc3Zwewzou++puKG33r5ap5?=
 =?us-ascii?Q?xe/7K77P58VblyTAATJ8f7KIDqYkB2tvx8CVTfTPchpx7NJu30ih6a+zKGAa?=
 =?us-ascii?Q?zCsT+tKPckcyxzyEpoJez4b+0fl9/mz4a7X8oBFluLEZTGfRMtGkJDyPgaG2?=
 =?us-ascii?Q?6cGa1WXgejmbrLDv/lAtXQ5foSN/lJ1MDrX9sHaycd/MdqXxkYGg2EDX+H0D?=
 =?us-ascii?Q?DCFLS7rGfHQvivAuK4jhGmqI83ExF0lhOt0uh1Z8mC0G1VYUe/CnpRFDgb+Y?=
 =?us-ascii?Q?vI2yo+ZsMggVa6eNg12LkBRf3KGrqGk7lVGmzvSLAngPFCEU9pmhSM/WfTNY?=
 =?us-ascii?Q?mh05KImWRz8dcqC5W2P9YKnJuYydVFSSTUPWL1iqP3a7Dj84Dd3YwVSqRhG0?=
 =?us-ascii?Q?s708ThR6XQdlWKbl4dz6eJJenM6LVmqqO4T2/DScegfcPPDiAFLDTMmX4uhg?=
 =?us-ascii?Q?L9oL7f0kPixqEYA9ZIvLiew26LeQwH3OqBKIcbW3ke88/HLqBDU+mdnPhsD6?=
 =?us-ascii?Q?UdcoTKfNd+3wsmL++EceJ7OBGGjMGjy9lWun9PLY9OUMA9MPohJJcyV38/Mb?=
 =?us-ascii?Q?+wPLQj/naV1HIvA++f0JYnwJiV+LAxe07Hp/4870C+HvQk7D98i3ItnKVaqx?=
 =?us-ascii?Q?oFQ3WW84AvQ/z5Nd7zVh93mK3i96I9Il8Pc7HPF/P4j+NUcgzlZ8QEkPqW+8?=
 =?us-ascii?Q?rzUvSs3g9HbQEjXJr7TbR86FwsJJEcGz0ONW18jrpdm0vYZOJMt4ZXmkAEbc?=
 =?us-ascii?Q?/L6wkrvqh7B3G8q9r1RU+BH0Z7fvWP98/LTJ5I5tJnY9zzVETH/xIN1NLHrf?=
 =?us-ascii?Q?Q3+S9a8RwGzOYAem7LpG3UqXGXc1KCWgmm6Zfhf168R+4cg20EAOH4Xlk5r1?=
 =?us-ascii?Q?pgcnuGR6QLwSltzokkFcEQOA631Pg7CdSMzlPU3zvz6kB1oW+p0LyHQU03EK?=
 =?us-ascii?Q?KEsVAHSwS4QzNM/f9P8hNBthfSX7AXuNHoSeLpM2Qa67A8Edc62QJ4CDt3ML?=
 =?us-ascii?Q?JdTb/eqOIhoNJCdYLEs=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 69ef42ce-36cc-4296-0dc2-08dc302812d9
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2024 02:19:45.2275
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: p5qefS9uQ3YiQRZAyiSdx+IY0xIMy6wb9X22oISyb+/Y3OXzeRjQQzpNDUfz0o5CnKD2ui9X0A1LuGw0MOIkIA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8763

> Subject: Re: [PATCH V4 2/2] clk: scmi: support state_ctrl_forbidden
>=20
> On Sun, Jan 21, 2024 at 07:09:01PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > Some clocks may exported to linux, while those clocks are not allowed
> > to configure by Linux. For example:
> >
> > SYS_CLK1-----
> >              \
> > 	     --MUX--->MMC1_CLK
> >              /
> > SYS_CLK2-----
> >
> > MMC1 needs set parent, so SYS_CLK1 and SYS_CLK2 are exported to Linux,
> > then the clk propagation will touch SYS_CLK1 or SYS_CLK2.
> > So we need bypass the failure for SYS_CLK1 or SYS_CLK2 when enable the
> > clock of MMC1, adding scmi_no_state_ctrl_clk_ops to use software
> > enable counter, while not calling scmi api.
> >
>=20
> I would rewrite the commit message something like:
> "
>     clk: scmi: Add support for forbidden clock state controls
>=20
>     Some clocks may be exported to OS agent, while certain configurations=
/
>     access to those clocks are restricted to the OS agent by the SCMI pla=
tform
>     firmware. For example:
>=20
>     SYS_CLK1-----
>                  \
>                  --MUX--->MMC1_CLK
>                  /
>     SYS_CLK2-----
>=20
>     MMC1_CLK needs to set parent as part of it initialisation and enablin=
g.
>     SYS_CLK1 and SYS_CLK2 are exported to the OS agent. The clk propagati=
on
>     will access SYS_CLK1 or SYS_CLK2 based on the configuration. However,
>     we need bypass the failure to access SYS_CLK1 or SYS_CLK2 when
> MMC1_CLK
>     is accessed and enabled.
>=20
>     Add a separate scmi_no_state_ctrl clk_ops where the calls to the SCMI
>     platform firmware are avoided if the access is not permitted.
> "
> No need to repost.
>=20
> I need Stephen's ack to take this together with scmi clk changes.

Stephen,=20

would you please ack if you are ok?

Thanks,
Peng.

>=20
> --
> Regards,
> Sudeep