Received-SPF: pass (google.com: domain of linux-kernel+bounces-70171-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: "chenjun (AM)" <chenjun102@huawei.com>
To: Thomas Gleixner <tglx@linutronix.de>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
CC: "xuqiang (M)" <xuqiang36@huawei.com>
Subject: Re: [PATCH] irqchip/mbigen: Fix incorrect null pointer check
Thread-Topic: [PATCH] irqchip/mbigen: Fix incorrect null pointer check
Thread-Index: AQHaUrPy4yFabhAFLUSb7iNXYyazpg==
Date: Sun, 18 Feb 2024 03:13:05 +0000
Message-ID: <45fe193a87fc4a5cb2e3233386b47dc7@huawei.com>
References: <20240129130003.18181-1-chenjun102@huawei.com>
 <874jecisku.ffs@tglx>
Accept-Language: zh-CN, en-US
Content-Language: en-US
Content-Type: text/plain; charset="iso-2022-jp"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0

=1B$B:_=1B(B 2024/2/13 18:09, Thomas Gleixner =1B$B<LF;=1B(B:=0A=
> On Mon, Jan 29 2024 at 21:00, Chen Jun wrote:=0A=
> =0A=
> That's not about an incorrect NULL pointer check. That's about using a=0A=
> function which is guaranteed to return NULL on your platform, no?=0A=
> =0A=
>> bus_get_dev_root(&platform_bus_type) always returns NULL.=0A=
> =0A=
> Lacks an explanation why this always returns NULL.=0A=
> =0A=
=0A=
Thank you for the reply.=0A=
=0A=
bus_get_dev_root returns sp->dev_root set in subsys_register.=0A=
And subsys_register is not called by platform_bus_init.=0A=
=0A=
So, for platform_bus_type, bus_get_dev_root always returns NULL.=0A=
=0A=
> Thanks=0A=
> =0A=
>          tglx=0A=
> =0A=
> =0A=
=0A=