Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp551085rdb; Sun, 18 Feb 2024 00:18:14 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVYXspKgSvUEurpoBS8Hq29z+/njq/d3OBleXWUH7AUVJ4+mlkB4FQZbVxnKas71VqHGQuqsdAGlv7ish8k6xxskDxdt/7JvqmNQJXPYQ== X-Google-Smtp-Source: AGHT+IGm70siAZ2IX9oXIhS4IFOhMKQXtx4ZdqOyPgjTcGOqUNb5vlyp8ZL+TJKSVHp3B4A408xD X-Received: by 2002:a05:6a20:438a:b0:19e:b6da:da1b with SMTP id i10-20020a056a20438a00b0019eb6dada1bmr18801051pzl.4.1708244294713; Sun, 18 Feb 2024 00:18:14 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708244294; cv=pass; d=google.com; s=arc-20160816; b=R5l6k0CMKVUX+V/2liPH02f99XGra64H6CUOM5UBVg84q0qJuEAkQLfB5X0EOMDExC iJj/lNcf1obaUQiOkEmvN2BNjmzgEaFelrkZgHkMjSV19rL7LccwbHvjeYd84f+PAAe9 01MxTm29gSalk2sSCfKwfbpxcloBmL1LydJ7NJDRaOXG1lfFeu012M7e4paqKgR7mBgq G0ThX563H29aLmo8qM6Pom+hJ2aFqqcfz4O6RYGoZaXvfgwBn5t2Qks6fo6edrS5Fjxh FBjxcYONilKnKnfimgU+WXZGex8a6Nta8ByvKsEF4XzU4/s1yIGz/+qrvE/ZwI/36LSk QR4g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:references:message-id:in-reply-to:subject:cc:to:from :date:dkim-signature; bh=TbmdbBSVviIHkden+8PwXOmL2cJJEkvmat341wz5Mec=; fh=91Vlw+UT9Ajh6776bI9zBmGAqzKidV6BDCGAscXv97c=; b=sT8QbKe9NVlEE2kyjjFvq7GpvhqYd8rTX6nKU8AOP2UjjE+Fxt/dJmUBJ5lLNHaQY5 etRHQlJPTmUu+xUWiZFWHD9zYDPC6rnGTQnDg3Qx49bt4Tr1XTNcMKPemB1WfzR3s1Nj oIAQXtUc3Wf2PqXR/YlmjQM/StAw2IY9pzyGJjhL31YwckvfOtZy8bX4MpiyDtvfS3Ak EXTxmyRCiaVsTaFBFGY9jmYdlQgylutArhPz5Uc/Ie16Q3i/XwWzQVOSzTS4ACuNzIeO obeL+C1vH977x5X4rmqQago/3wrWwWUUOSbKyDo6Bs4R5/yt05XTdajoUl90onFaIaLs PfgQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@inria.fr header.s=dc header.b="Jq//bwLz"; arc=pass (i=1 spf=pass spfdomain=inria.fr dkim=pass dkdomain=inria.fr dmarc=pass fromdomain=inria.fr); spf=pass (google.com: domain of linux-kernel+bounces-70283-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-70283-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=inria.fr Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id s30-20020a63925e000000b005dc504b9628si2575339pgn.113.2024.02.18.00.18.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Feb 2024 00:18:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-70283-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@inria.fr header.s=dc header.b="Jq//bwLz"; arc=pass (i=1 spf=pass spfdomain=inria.fr dkim=pass dkdomain=inria.fr dmarc=pass fromdomain=inria.fr); spf=pass (google.com: domain of linux-kernel+bounces-70283-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-70283-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=inria.fr Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 0972FB2156D for ; Sun, 18 Feb 2024 08:18:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A2CECF4FB; Sun, 18 Feb 2024 08:18:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=inria.fr header.i=@inria.fr header.b="Jq//bwLz" Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 179BC3229 for ; Sun, 18 Feb 2024 08:18:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.134.164.104 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708244283; cv=none; b=l11n5br61eumHUWo/D175ddthEZhUXrjo5aBdHdLtBHm5hKh0HF3HQjA8njaXNtN34kG3uHtFv/S6oFui2rKLuafzz5Y35GbNwPXLp/I25T6pbZk5na1JX86XDNPRVouz1KwxbmxCeeTO3enmVr8AZ3mtcNqu98jfpwqnAYGcaE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708244283; c=relaxed/simple; bh=jxB5mtxUClEyeYhl6ALYiu3s4Ee9DZ8cHj61SqjPJGg=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=Qh5mBMdgvKie1AggvWS5kqBY3pQguXHYpu1bzYv/CqsFbNbNljpvweaEWAJaMxVC9ovGa4Be3EkGf7NxOU+G2eoj5rB+SVgo3MZq0AxUTwo3y4+M17OpUcnATh1Gee9TikVKgG/eFre+655KaUXHU8z3vV+hTTytr4CI5ZSIuG8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=inria.fr; spf=pass smtp.mailfrom=inria.fr; dkim=pass (1024-bit key) header.d=inria.fr header.i=@inria.fr header.b=Jq//bwLz; arc=none smtp.client-ip=192.134.164.104 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=inria.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=inria.fr DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=TbmdbBSVviIHkden+8PwXOmL2cJJEkvmat341wz5Mec=; b=Jq//bwLzhgBvbsqBjUGJY9ON/bmAoi0QCjuyyOEyyK5SEAdZWt9+vR83 UTjE/qMsY1YB7Ufzcu060MEMNWM30E/+FY1YiPfdAOKAkXEDxmPQcTg1H XJ5wBI5Vsrxwt7KXbysrEooLeq+XO58wisnJeqwLgbeJUjMz3CCtIIXNC U=; Authentication-Results: mail3-relais-sop.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=julia.lawall@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="6.06,168,1705359600"; d="scan'208";a="79934373" Received: from 231.85.89.92.rev.sfr.net (HELO hadrien) ([92.89.85.231]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2024 09:17:53 +0100 Date: Sun, 18 Feb 2024 09:17:52 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Li Zhijian cc: linux-kernel@vger.kernel.org, Nicolas Palix , cocci@inria.fr Subject: Re: [PATCH v2] coccinelle: device_attr_show: Remove useless expression STR In-Reply-To: <20240218080054.719008-1-lizhijian@fujitsu.com> Message-ID: References: <20240218080054.719008-1-lizhijian@fujitsu.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Sun, 18 Feb 2024, Li Zhijian wrote: > Commit ff82e84e80fc ("coccinelle: device_attr_show: simplify patch case") > simplifies the patch case, as a result, STR is no longer needed. > > This also helps to fix below coccicheck warning: > > warning: rp: metavariable STR not used in the - or context code > > CC: Julia Lawall > CC: Nicolas Palix > CC: cocci@inria.fr > Fixes: ff82e84e80fc ("coccinelle: device_attr_show: simplify patch case") > Signed-off-by: Li Zhijian Applied to my tree > --- > scripts/coccinelle/api/device_attr_show.cocci | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/coccinelle/api/device_attr_show.cocci b/scripts/coccinelle/api/device_attr_show.cocci > index 550d1d2fc02a..dfcf9304195f 100644 > --- a/scripts/coccinelle/api/device_attr_show.cocci > +++ b/scripts/coccinelle/api/device_attr_show.cocci > @@ -28,7 +28,7 @@ ssize_t show(struct device *dev, struct device_attribute *attr, char *buf) > > @rp depends on patch@ > identifier show, dev, attr, buf; > -expression BUF, SZ, FORMAT, STR; > +expression BUF, SZ, FORMAT; > @@ > > ssize_t show(struct device *dev, struct device_attribute *attr, char *buf) > -- > 2.29.2 > >