Received-SPF: pass (google.com: domain of linux-kernel+bounces-70287-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID:
 <SEZPR06MB695945299705B6E8BF0E326296522@SEZPR06MB6959.apcprd06.prod.outlook.com>
Date: Sun, 18 Feb 2024 16:21:13 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/3] mmc: dw_mmc: add support for hi3798mv200
Content-Language: en-US
To: kernel test robot <lkp@intel.com>,
 Yang Xiwen via B4 Relay <devnull+forbidden405.outlook.com@kernel.org>,
 Ulf Hansson <ulf.hansson@linaro.org>, Jaehoon Chung
 <jh80.chung@samsung.com>, Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzk@kernel.org>, Conor Dooley <conor+dt@kernel.org>
Cc: oe-kbuild-all@lists.linux.dev, Igor Opaniuk <igor.opaniuk@linaro.org>,
 tianshuliang <tianshuliang@hisilicon.com>, David Yang <mmyangfl@gmail.com>,
 linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
 devicetree@vger.kernel.org
References: <20240216-b4-mmc-hi3798mv200-v1-1-7d46db845ae6@outlook.com>
 <202402181540.H4Ose96P-lkp@intel.com>
From: Yang Xiwen <forbidden405@outlook.com>
In-Reply-To: <202402181540.H4Ose96P-lkp@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SEZPR06MB6959:EE_|SI2PR06MB5113:EE_
X-MS-Office365-Filtering-Correlation-Id: 69453715-b438-4816-03f3-08dc305a945c
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	zgkTp04Di8CfwwkE3lZANwKSYZqNbGB2lARIQSsyTrMIXhJJB/tKfsPGTy/zz5WG7xSfm/1DyrLffMeYY58uxeDfJAGUXiy76Ksk0ZFHeB1758L6vtaHC7ONRu17h20W1gDDLj7xjYi8/M6nlIymeoIxsdc6+pBGG4GohVB1fxyAbIpiprog9MnxlNhHCYb2TohB5nIsUrMqYZX0T9jfp1l2ghdxjUNcy3gdDynEemrzkyAF/+DHjpyeC5V9seLTHB0DA2ThxLFR31X9186LC2EtNFANGlWEFhnOqJAwpZbUIyffOEt/XD2Ml8NIgQ/Mc/InnGwiyyYOoMQkyYsQqkP9ieVPz46T3181LpIbUr6i9EmscOWMvg0ugWededMdJr0GSvNvnrucRN5APsa2wO/7kbiOLHnXFGLzvl9HQJW3HdHCre0G4AinHU1XtF05JerakBgUf04a5qaPEs5CV13IaezM84DYYpNhu2PLuXn525tA7rK55cV2okPiH4O13wjG+rWIYgRXCXaGjS7Anb+pdB094QaLCoaUBRcO/E0wJCdDig+4DMayMHKNNP6TxrzpYnEMiQb6rxrnIBP1Ai8ApRChiefHNMjw5UvLX+Gtg/Pfa4PH7V3bKNdvwh2IeiAavAcG7hjvWx0MfiA/Xw==
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dlJYK1Jwdis4dnFrQzRXVlp1bjl6dHlqZkJnem5lSTBXU01ad3hQOU5aaW9r?=
 =?utf-8?B?eThHSWxHL05aUTErSExIWTEySDMrMUtJNVpZWVJLUHhNaVBIZXUzS0FkTnhn?=
 =?utf-8?B?NVJTMFZ4ZFAwcUhSTzJHdVJvQVRyenNpaGx2Qi8wZVgvd3NCRklNK2FDN0FU?=
 =?utf-8?B?MkJkNThRczREem9ZYTNFbTFCM0tYSFpEVGNrcTB5Wk5OWk9FMU9ZaFZrTmx2?=
 =?utf-8?B?N0pQQllsUEgrM1hpL2h3S3JJOUgwOTlxTUlnRUNKQlY4ZE83TWdpS1BVQVJm?=
 =?utf-8?B?QUVRVXVOeXhSM1IrSEtaZmxibUdua210UExqSlZOVC95SFNxeElodUJBVnk2?=
 =?utf-8?B?aVNwM2xkODFsZE1wOUhBRm5nT1ZneEdtWm5kVzZGc0V6V3IyUFY3dlFFZXhj?=
 =?utf-8?B?VTY5L0RKL2hSNHJvQU5JUEx1ZEdkckhOMDBOeDVVTHNpUlY2U1pNNUM3Y2lZ?=
 =?utf-8?B?akkrWnF3dndxVU5yNTRDMTgzZ0ZWWDdTRVNDaFYrTUEvZkVCbWpPT3RHVHRX?=
 =?utf-8?B?MHZ1UEtsVlNRZjYvUE1UaHZxdlBNdmR3ZEVjckFPK3V3Rm5wQmI1Zm9kdWtI?=
 =?utf-8?B?eXNYYkppNEdmL0xrVjRnUkF1bFJjbzFmdlJEd0FoZzNnbU1oYW1peUZyL2cv?=
 =?utf-8?B?eTI3YXR0MmJOU0JHOEpLWU8yd0JibzFEZGlqZWF5RXZ0cTZnSU41S1BqcENT?=
 =?utf-8?B?RjlPV1BLdGxvWU8zSWR3L3hnRmVvVG9vMURlU2JaTVc0NktwdzdUZVVZNllH?=
 =?utf-8?B?NXVsUVczcUhERzZoT0RldzhYT0hocUE0aE1vUjZmY1F3MmxpTGtJYUZsVWpZ?=
 =?utf-8?B?ZFlUQVlLN25iQ1FsLzlBMmZWOUhxRWpvZWpHT0lBdEV5T2EvSWdaOFhzWnVu?=
 =?utf-8?B?M2MxVkVJczZGNW1aTzlpeWtOQkJuVmJpWWdUbHYzbkE1SDBCOUtQWmovWlRz?=
 =?utf-8?B?MjNVRjZwOEE4UXZEWlNnNnkrWTRZZ212MXZrVUg0RHoyS2h5VkxsN0RJR2Mw?=
 =?utf-8?B?VGtXSm91M2MvcjhCOTZ6eFpFTURVNHRJd0tWVjhuRzBWRFg2eENiT2tPdWFV?=
 =?utf-8?B?NHF2VVdLYmZkTGdRbnJmS0tNWi9TcTFPaEpDVDJaVkxRckNZdXhXSUt0MEN4?=
 =?utf-8?B?b21Xcm5od09hc3A0RHhMaVFqQkhFbGZBOEdaUjF5VUhBUVVFTzl4Skxpb21x?=
 =?utf-8?B?eExUSjdrU054MCt1eGcrNDZxMlFnZU9SZ3ZBekIwNUp0OXZoZDArWlRLejYy?=
 =?utf-8?B?YXJLS1R4UmFjZ0dQeldkdjEyZjQzOVlsazZsR3FLMFQxNDRLTndwSFVub1JN?=
 =?utf-8?B?ZlFRYkZTand5a0lKb01UOWxwT0ZWcDNLTGQyR3o0SE5tSTF0eVV0ZGMrWXVK?=
 =?utf-8?B?UHNxR09PY1lKcXlhT3BHYVZBdk9jY0IzSWlMZWs0dk4xVStnV2oxN0lhd3kv?=
 =?utf-8?B?czY2dzl6QmlaUCtva01YNmlWeFNGZkc2RmtMTXQzSy8vbXQybmJyTTBSZitp?=
 =?utf-8?B?N0wyMERHZllpNkdGampmb1hRV2phek1QR3FDUndFUzIxM3RrOTYwaGZNT3lK?=
 =?utf-8?B?Tk5NTVludVJzQUdMOW53VmtLU2puYkEzcUtJR0dNYUVYZmdZZ1Nhc2VoUnZR?=
 =?utf-8?B?amZsc1AvYkhWV3FTSWNCQTdJOXhCZ0szQnVJb2dwNnIyQ25wMThvUktEVnJB?=
 =?utf-8?B?cU5wbjJOUHFTWXN1OEZWQ1MxcEZIUjluUWNOc0EzZWF1SE43RC9ST3VCOWRl?=
 =?utf-8?Q?cNOgjUuPkV5IExzVDbtJBUhHgtH+a4idmksqWx8?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 69453715-b438-4816-03f3-08dc305a945c
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB6959.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2024 08:21:17.5484
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB5113

On 2/18/2024 4:03 PM, kernel test robot wrote:
> Hi Yang,
>
> kernel test robot noticed the following build errors:
>
> [auto build test ERROR on 8d3dea210042f54b952b481838c1e7dfc4ec751d]
>
> url:    https://github.com/intel-lab-lkp/linux/commits/Yang-Xiwen-via-B4-Relay/mmc-dw_mmc-add-support-for-hi3798mv200/20240216-014744
> base:   8d3dea210042f54b952b481838c1e7dfc4ec751d
> patch link:    https://lore.kernel.org/r/20240216-b4-mmc-hi3798mv200-v1-1-7d46db845ae6%40outlook.com
> patch subject: [PATCH 1/3] mmc: dw_mmc: add support for hi3798mv200
> config: parisc-allyesconfig (https://download.01.org/0day-ci/archive/20240218/202402181540.H4Ose96P-lkp@intel.com/config)
> compiler: hppa-linux-gcc (GCC) 13.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240218/202402181540.H4Ose96P-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202402181540.H4Ose96P-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
>     drivers/mmc/host/dw_mmc-hi3798mv200.c: In function 'dw_mci_hi3798mv200_init':
>>> drivers/mmc/host/dw_mmc-hi3798mv200.c:178:36: error: passing argument 1 of 'mmc_of_parse_clk_phase' from incompatible pointer type [-Werror=incompatible-pointer-types]
>       178 |         mmc_of_parse_clk_phase(host->dev, &priv->phase_map);
>           |                                ~~~~^~~~~
>           |                                    |
>           |                                    struct device *
>     In file included from drivers/mmc/host/dw_mmc-hi3798mv200.c:11:
>     include/linux/mmc/host.h:542:46: note: expected 'struct mmc_host *' but argument is of type 'struct device *'
>       542 | void mmc_of_parse_clk_phase(struct mmc_host *host,
>           |                             ~~~~~~~~~~~~~~~~~^~~~
>     cc1: some warnings being treated as errors
>
>
> vim +/mmc_of_parse_clk_phase +178 drivers/mmc/host/dw_mmc-hi3798mv200.c
>
>     168	
>     169	static int dw_mci_hi3798mv200_init(struct dw_mci *host)
>     170	{
>     171		struct dw_mci_hi3798mv200_priv *priv;
>     172		struct device_node *np = host->dev->of_node;
>     173	
>     174		priv = devm_kzalloc(host->dev, sizeof(*priv), GFP_KERNEL);
>     175		if (!priv)
>     176			return -ENOMEM;
>     177	
>   > 178		mmc_of_parse_clk_phase(host->dev, &priv->phase_map);

Please note that this patch is depending on another patch[1].

[1]: 
https://lore.kernel.org/linux-mmc/ae876e697ba16ba2925ec217c6b4e3d8ffea4ab3.camel@codeconstruct.com.au/T/#t


Ulf, what do think about picking that patch in this patch set? So that 
the dependencies can be resolved.

>     179	
>     180		priv->sample_clk = devm_clk_get_enabled(host->dev, "ciu-sample");
>     181		if (IS_ERR(priv->sample_clk)) {
>     182			dev_err(host->dev, "failed to get enabled ciu-sample clock\n");
>     183			return PTR_ERR(priv->sample_clk);
>     184		}
>     185	
>     186		priv->drive_clk = devm_clk_get_enabled(host->dev, "ciu-drive");
>     187		if (IS_ERR(priv->drive_clk)) {
>     188			dev_err(host->dev, "failed to get enabled ciu-drive clock\n");
>     189			return PTR_ERR(priv->drive_clk);
>     190		}
>     191	
>     192		priv->sap_dll_reg = syscon_regmap_lookup_by_phandle(np, "hisilicon,sap-dll-reg");
>     193		if (IS_ERR(priv->sap_dll_reg)) {
>     194			dev_err(host->dev, "failed to get sap-dll-reg\n");
>     195			return PTR_ERR(priv->sap_dll_reg);
>     196		}
>     197	
>     198		host->priv = priv;
>     199		return 0;
>     200	}
>     201	
>

-- 
Regards,
Yang Xiwen