Received-SPF: pass (google.com: domain of linux-kernel+bounces-70392-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <522c03d9-a8ba-459d-9f7c-dfbf461dcf6b@kernel.dk>
Date: Sun, 18 Feb 2024 06:00:08 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v8] io_uring: Statistics of the true utilization of sq
 threads.
Content-Language: en-US
To: Xiaobing Li <xiaobing.li@samsung.com>, asml.silence@gmail.com
Cc: linux-kernel@vger.kernel.org, io-uring@vger.kernel.org,
 kun.dou@samsung.com, peiwei.li@samsung.com, joshi.k@samsung.com,
 kundan.kumar@samsung.com, wenwen.chen@samsung.com, ruyi.zhang@samsung.com,
 cliang01.li@samsung.com, xue01.he@samsung.com
References: <CGME20240206024726epcas5p1d90e29244e62ede67813da5fcd582151@epcas5p1.samsung.com>
 <20240206023910.11307-1-xiaobing.li@samsung.com>
From: Jens Axboe <axboe@kernel.dk>
In-Reply-To: <20240206023910.11307-1-xiaobing.li@samsung.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 2/5/24 7:39 PM, Xiaobing Li wrote:
> Count the running time and actual IO processing time of the sqpoll
> thread, and output the statistical data to fdinfo.
> 
> Variable description:
> "work_time" in the code represents the sum of the jiffies of the sq
> thread actually processing IO, that is, how many milliseconds it
> actually takes to process IO. "total_time" represents the total time
> that the sq thread has elapsed from the beginning of the loop to the
> current time point, that is, how many milliseconds it has spent in
> total.
> 
> The test tool is fio, and its parameters are as follows:
> [global]
> ioengine=io_uring
> direct=1
> group_reporting
> bs=128k
> norandommap=1
> randrepeat=0
> refill_buffers
> ramp_time=30s
> time_based
> runtime=1m
> clocksource=clock_gettime
> overwrite=1
> log_avg_msec=1000
> numjobs=1
> 
> [disk0]
> filename=/dev/nvme0n1
> rw=read
> iodepth=16
> hipri
> sqthread_poll=1
> 
> ---

If you put --- in here, then the rest of the commit message disappears.
The way you format commit messages it to put things you don't want in
the git log below it... This one should not be here.

> 
> ---
> The test results corresponding to different iodepths are as follows:

Same with this one...

> |-----------|-------|-------|-------|------|-------|
> |   iodepth |   1   |   4   |   8   |  16  |  64   |
> |-----------|-------|-------|-------|------|-------|
> |utilization| 2.9%  | 8.8%  | 10.9% | 92.9%| 84.4% |
> |-----------|-------|-------|-------|------|-------|
> |    idle   | 97.1% | 91.2% | 89.1% | 7.1% | 15.6% |
> |-----------|-------|-------|-------|------|-------|
> 
> changes?
> v8:

Here you need it, the changelog should be below the one and only --- you
put in the commit message.

>  - Get the work time of the sqpoll thread through getrusage
> 
> v7:
>  - Get the total time of the sqpoll thread through getrusage
>  - The working time of the sqpoll thread is obtained through ktime_get()
> 
> v6:
>  - Replace the percentages in the fdinfo output with the actual running
> time and the time actually processing IO
> 
> v5?
>  - list the changes in each iteration.
> 
> v4?
>  - Resubmit the patch based on removing sq->lock
> 
> v3?
>  - output actual working time as a percentage of total time
>  - detailed description of the meaning of each variable
>  - added test results
> 
> v2?
>  - output the total statistical time and work time to fdinfo
> 
> v1?
>  - initial version
>  - Statistics of total time and work time
> 
> Signed-off-by: Xiaobing Li <xiaobing.li@samsung.com>

And since your Signed-off-by is here, it also does not go into the
commit message, which it must.

> index 976e9500f651..18c6f4aa4a48 100644
> --- a/io_uring/fdinfo.c
> +++ b/io_uring/fdinfo.c
> @@ -64,6 +64,7 @@ __cold void io_uring_show_fdinfo(struct seq_file *m, struct file *f)
>  	unsigned int sq_shift = 0;
>  	unsigned int sq_entries, cq_entries;
>  	int sq_pid = -1, sq_cpu = -1;
> +	u64 sq_total_time = 0, sq_work_time = 0;
>  	bool has_lock;
>  	unsigned int i;
>  
> @@ -147,10 +148,17 @@ __cold void io_uring_show_fdinfo(struct seq_file *m, struct file *f)
>  
>  		sq_pid = sq->task_pid;
>  		sq_cpu = sq->sq_cpu;
> +		struct rusage r;

Here, and in one other spot, you're mixing variable declarations and
code. Don't do that, they need to be top of that scope and before any
code.

> diff --git a/io_uring/sqpoll.c b/io_uring/sqpoll.c
> index 65b5dbe3c850..9155fc0b5eee 100644
> --- a/io_uring/sqpoll.c
> +++ b/io_uring/sqpoll.c
> @@ -251,6 +251,9 @@ static int io_sq_thread(void *data)
>  		}
>  
>  		cap_entries = !list_is_singular(&sqd->ctx_list);
> +		struct rusage start, end;
> +
> +		getrusage(current, RUSAGE_SELF, &start);

Ditto, move the variables to the top of the scope.

>  		list_for_each_entry(ctx, &sqd->ctx_list, sqd_list) {
>  			int ret = __io_sq_thread(ctx, cap_entries);
>  
> @@ -260,6 +263,11 @@ static int io_sq_thread(void *data)
>  		if (io_run_task_work())
>  			sqt_spin = true;
>  
> +		getrusage(current, RUSAGE_SELF, &end);
> +		if (sqt_spin == true)
> +			sqd->work_time += (end.ru_stime.tv_sec - start.ru_stime.tv_sec) *
> +					1000000 + (end.ru_stime.tv_usec - start.ru_stime.tv_usec);
> +

and this should go in a helper instead. It's trivial code, but the way
too long lines makes it hard to read. Compare the above to eg:

static void io_sq_update_worktime(struct io_sq_data *sqd, struct rusage *start)
{
       struct rusage end;

       getrusage(current, RUSAGE_SELF, &end);
       end.ru_stime.tv_sec -= start->ru_stime.tv_sec;
       end_ru_stime.tv_usec -= start->ru_stime.tv_usec;

       sqd->work_time += end.ru_stime.tv_usec + end.ru_stime.tv_sec * 1000000;
}

which is so much nicer to look at.

We're already doing an sqt_spin == true check right below, here:

>  		if (sqt_spin || !time_after(jiffies, timeout)) {
>  			if (sqt_spin)
>  				timeout = jiffies + sqd->sq_thread_idle;

why not just put io_sq_update_worktime(sqd, &start); inside this check?

> diff --git a/io_uring/sqpoll.h b/io_uring/sqpoll.h
> index 8df37e8c9149..e99f5423a3c3 100644
> --- a/io_uring/sqpoll.h
> +++ b/io_uring/sqpoll.h
> @@ -16,6 +16,7 @@ struct io_sq_data {
>  	pid_t			task_pid;
>  	pid_t			task_tgid;
>  
> +	u64					work_time;
>  	unsigned long		state;
>  	struct completion	exited;
>  };

Not sure why this addition is indented differently than everything else
in there?

-- 
Jens Axboe