Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp632777rdb; Sun, 18 Feb 2024 05:02:07 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCW/jZnFe8Nlx/qZ2JRE/rcilzoZ4L9Y/JcuaRYD1MSSHa6PY3pr1Thkj5aNxjNwvVYVXy4IU97hxyoLSIBYn8XWSYbyZWcKMd/VWrinYg== X-Google-Smtp-Source: AGHT+IF1HLlxzT9z5/r+hblRBX3rHHIyHt2pyvdLaxoHS/BX/u6PLl4YfxoemsW1QRjHYXtv7S7F X-Received: by 2002:a17:902:aa91:b0:1d8:eb2b:7b26 with SMTP id d17-20020a170902aa9100b001d8eb2b7b26mr8287397plr.49.1708261327250; Sun, 18 Feb 2024 05:02:07 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708261327; cv=pass; d=google.com; s=arc-20160816; b=dx7LVmviStuTALnHgZ+ub4HV6tXEFJF7cLl6tcpv6+YwbnFb5fU61v5IH5Y820HGaK XcpeB2CM35gUUyZqiB7W0cyz4dtvDkyz12Orgdw3aUop1be8tMYoEeweu1nCstXGzrFO wAmj0L8eHTbOrsJ6c17Kg/E0sXfSR7fitLqvDBgzPgZgPrzrLUSqLewZt5UovlJMIW4t wp+yLMIFohReOlPwhPXoRXFsruO2NrQPKYltFUCkcKC5WZT73wBKagwC4NplwFApXUpR ONqB0VqJlg+SlsWNLFqhj8Vur5RagyUAKCuiPtZPVOCwsHYW+qQJ9d2eSy1+LHL8VQnm UnMw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:cc:to:from:dkim-signature; bh=iIYyy/W1tr/0bAEhThJxXh8k4ZWLMBlLPwt2pJ+jp6Y=; fh=xvzQYAvt46UKDGiR1S7K7Po3GWf8TsK9BjhQNCtIdmc=; b=zSiSNLQyaXw3U5yS3g59RbKMI62rGvnZi3lSkzaInK4NCCW70DbuiFvwl+ydBcvj8z z0Fa69L8FA1HBycH8ZezU0oDHLReHydyczuVlQqLgRQFBCJhXBAVvQDNbY4sF5yyqe/+ hWy9sAsknpM/k/4QshWWoRAoaSVZwL7TAV/KpsTtp8I/KRoWH5qUBN2/9iTqbJMdnsEs WMcDmlEWKOaQYClsCTjUnL3UHCn7/fBoxvuacivEX3oTFPeR3l7uZUt6KT74XgMJki/l XFewcTJfbxoUbaFHOjFIg0qk47srgm0EsQJFhdNvbTgkAMGgoM/ZrvVvt8yRa+o6cqgK umvA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=JhVbExaK; arc=pass (i=1 spf=pass spfdomain=kernel.dk dkim=pass dkdomain=kernel-dk.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-70394-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-70394-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id l13-20020a170903120d00b001da1fe7cacasi2887762plh.370.2024.02.18.05.02.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Feb 2024 05:02:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-70394-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=JhVbExaK; arc=pass (i=1 spf=pass spfdomain=kernel.dk dkim=pass dkdomain=kernel-dk.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-70394-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-70394-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id F0D5A281FC4 for ; Sun, 18 Feb 2024 13:02:06 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 29EAF6BB5F; Sun, 18 Feb 2024 13:02:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="JhVbExaK" Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2143A4EB41 for ; Sun, 18 Feb 2024 13:01:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708261319; cv=none; b=EG+Q52nx+fvLvfs6AauUBb5hVMvXcaMUcsdNIzzWOpwqC9tBI/7k2rj//Nxc0Iw59XMh+sM8FZgk1jbDB1Xv1ziTEu841LbnVgng3pkuC+qAVaBprra35CQAm6E2Dq9MuBWpycn4XJYRvu+zwUd9Z829jkrfth0X9IDcuK6xirI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708261319; c=relaxed/simple; bh=CArwFe0qu0rUAkzUEv7P8qSaBIOWCLLpZlpvdXeYt0g=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=kpgt4itUl8O82QZf2xzMpUiJJcnJwVbb/ohkYM/VrS8MPuW0s5BbNT+VtUoHPcJEvF6jOhWUNUzu3OEB7IkUSmQUVyOUZ3WOWyWBE9jeVBxZ8D2zNcFKyrBKG4caBR7PmXG2vAWUs2b8Cxg7rd4uV6qf+0j/e1mFjFtp2Z4NOxs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=JhVbExaK; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-2866b15b013so994141a91.0 for ; Sun, 18 Feb 2024 05:01:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1708261317; x=1708866117; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iIYyy/W1tr/0bAEhThJxXh8k4ZWLMBlLPwt2pJ+jp6Y=; b=JhVbExaKZAiiOrbb7iq5oKT+m7TBI48oaaFxNzw5jUtVohmspPtBQEtdabTwMWaWXK xxhsWqfEuWeab9foLvASxXZxlnsbOuRePBQVlfRdlJsm07Y8v2mbct2j2O/3YO0+M91W fAY8AqC6yjSvJ8rUrkXCMMsWTVHdGE3gUCTMdW4M5MQ1NkSZaRZ3oPnbkRYK1scD5fpk jSXDckj0opFoK4QV088xAW2wiLTiTrpNnwIZXoV6o5+HTfHf2W7L7bY1C+Bpj2e4kypA syWWSNbMYvyvOMXk7vYO6/fyBJbm4agCqTHbtWiR/YdjXbH3WOwTtgz52yU+WdY8Z5xJ uKGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708261317; x=1708866117; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iIYyy/W1tr/0bAEhThJxXh8k4ZWLMBlLPwt2pJ+jp6Y=; b=m9VRgVfIx/+FMMRejDhkVAMRPXszr55lkQi/vHQ2CxyudqZfKYR4NMFEDwkk4MY5aE NrQwjFxpNPMdT45tkl06TerTanEUgQVinjZhltrmfjcRLTE2vdJipp1/vJ8kf5Cr6zew Gj0nl+8Wdw3OkmfreWAnRd+LSnprGuf5EOgL5Xy64PzM5C4mvtDgaAJy/jVkns7TC/g8 yRINvG+sN5yKEb5gT8ERvWX/8msdwcNLjPmDaYMafkTqYEZZ6uDXco0qzXKIASkzJODc zW5ctJ8noINWwMHlpSNjDe8+3B9HSgCreqc9BZaYRX616oGw71Fi2BqmVwO/ZuHIbJWO qL3A== X-Forwarded-Encrypted: i=1; AJvYcCXyc+SMQEdr92J3V0MlM2oUOIW7nGV0ffBG8ZhlAP3GyJ/5edf47iQr51sU2j2jreR6IdT62yhw6LwibPALpn1gObY0KZbZOP6UDrnP X-Gm-Message-State: AOJu0Yyo99SNgkWxiEheOUS/GDnhtN+o8xgLvGH7zuH+zM9fIkIZOPNN A0Vjt1MwxdcbfKat6lRk2FymywVCa2M5zHn+z3SakZH0345Q4k26rsqHqHtWwjo= X-Received: by 2002:a17:902:bb81:b0:1d8:ca3a:9d2a with SMTP id m1-20020a170902bb8100b001d8ca3a9d2amr10414358pls.4.1708261317334; Sun, 18 Feb 2024 05:01:57 -0800 (PST) Received: from [127.0.0.1] ([198.8.77.194]) by smtp.gmail.com with ESMTPSA id kn14-20020a170903078e00b001d9a91af8a4sm2685725plb.28.2024.02.18.05.01.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Feb 2024 05:01:56 -0800 (PST) From: Jens Axboe To: Josef Bacik , Kees Cook Cc: Navid Emamdoost , Michal Kubecek , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, nbd@other.debian.org, linux-hardening@vger.kernel.org In-Reply-To: <20240218042534.it.206-kees@kernel.org> References: <20240218042534.it.206-kees@kernel.org> Subject: Re: [PATCH v4] nbd: null check for nla_nest_start Message-Id: <170826131614.3482432.1638173744340292313.b4-ty@kernel.dk> Date: Sun, 18 Feb 2024 06:01:56 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.12.5-dev-2aabd On Sat, 17 Feb 2024 20:25:38 -0800, Kees Cook wrote: > nla_nest_start() may fail and return NULL. Insert a check and set errno > based on other call sites within the same source code. > > Applied, thanks! [1/1] nbd: null check for nla_nest_start commit: 31edf4bbe0ba27fd03ac7d87eb2ee3d2a231af6d Best regards, -- Jens Axboe