Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp690020rdb; Sun, 18 Feb 2024 07:19:14 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXd1EeZcH+3HqwboaErOTtpiEa6BTv3ry+efFSSvONWTgyHdsgTIpJXTJPsK7gnlhpi4Nowhfb9MnJxoEoj08n5TfEzAAyxl/2HA+a6ZQ== X-Google-Smtp-Source: AGHT+IFMyZtLxGUp5v6vgpBeUif6CEggnMvP05rz3lYJcPs8h23RnpXPl/ieW2SJAR0t6rlcNNDS X-Received: by 2002:a05:620a:1019:b0:785:a968:8c5c with SMTP id z25-20020a05620a101900b00785a9688c5cmr10633113qkj.67.1708269553951; Sun, 18 Feb 2024 07:19:13 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708269553; cv=pass; d=google.com; s=arc-20160816; b=0cBMG/1w1PYuIhY6WHgab3ixUFlIlNP7RNRgHYv63kEsjlThNV8nKX3eOFVI6QN42y 032TM0RtFo6lFW4pFnPdmUm3RB11lGdDse05AFdzCP+sJXXqa6jpBTJf7omlIEo972ea JkamD4dYnxSGaowHm83LXmEUfWpw4wfDOfJq9SgHQQeY6YDDOod0s+h11dM26WiLGjiR e5Yuw4s+4cZJAkzzuV5IbUfhV9svFDkuq90bA7/D8um6xUg4nGc0ydmw1FxjJVJb+Wle clkE6SapoaXswioX1Cv397Lz7qWPeWGja5dg+hnP9CaAPBJ/v1oHvJNVcLlMOWPXqhcL MJ+g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:references:to:subject:cc:from:message-id:date :content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=oAxZkLmX1aRHRUsZ0ExGlhAyhq9nsWkycT8rOvRVdsU=; fh=9pGKW/MbqGFG1+MBikQXGf8ubEqAus2Maeygq4yb9VY=; b=mk9W3khLtr8dTB/NkOZb4Y9S2whPtL97toJxUhXqCGaIeaGXmugZwSj2skqa1sF0Fx rCLQ87zca3UwtIYyvT/0ZBFzew2Isaaq08qi4qZ5yN3n/3yB3acPlXhFpUcyUxel4szS 3p4MX8Cdx3K8sgqhaNzgjxdcpyLCrUXzq9MugEqFFtNXIUmmMFvmi2hiUQDkn5kwpBfU UsqjCxMu0ZxFIioNgrdDn8i5vIMyAOjKoCoJR4xOUedjcrqjQ9ysoa6q5umk8xTAGTND WsNfiJGPEYwOBfTIp3XzMlJQMPWP4koG2WHZTV8JBv8cuD9Hab9IopNExamKM95gdRbQ 7qYg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gimli.ms.mff.cuni.cz header.s=gen1 header.b=jR35gko6; arc=pass (i=1 spf=pass spfdomain=gimli.ms.mff.cuni.cz dkim=pass dkdomain=gimli.ms.mff.cuni.cz dmarc=pass fromdomain=gimli.ms.mff.cuni.cz); spf=pass (google.com: domain of linux-kernel+bounces-70427-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-70427-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gimli.ms.mff.cuni.cz Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id u22-20020a05620a455600b007815c7aa50bsi4618029qkp.263.2024.02.18.07.19.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Feb 2024 07:19:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-70427-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@gimli.ms.mff.cuni.cz header.s=gen1 header.b=jR35gko6; arc=pass (i=1 spf=pass spfdomain=gimli.ms.mff.cuni.cz dkim=pass dkdomain=gimli.ms.mff.cuni.cz dmarc=pass fromdomain=gimli.ms.mff.cuni.cz); spf=pass (google.com: domain of linux-kernel+bounces-70427-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-70427-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gimli.ms.mff.cuni.cz Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id A75D01C20B8A for ; Sun, 18 Feb 2024 15:19:13 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E2F6C6D1A9; Sun, 18 Feb 2024 15:19:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=gimli.ms.mff.cuni.cz header.i=@gimli.ms.mff.cuni.cz header.b="jR35gko6" Received: from nikam.ms.mff.cuni.cz (nikam.ms.mff.cuni.cz [195.113.20.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4225D1E48A; Sun, 18 Feb 2024 15:19:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.113.20.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708269544; cv=none; b=WCOMWBE1BLQ9TOM2EvWhlmmHSqvi+DqjoEJYNLM80w+yezfe3n+vekMOsovnN+dQKGthiFDjNnowYq3E5bjlSyBKakYpLTGeVi8/CPGalBkUUTdTc+CnFIpmluxY5grnbCmLBUzuDZ2hNFWttYC3UxQJEWMBr8rihZ+nYTaMj6A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708269544; c=relaxed/simple; bh=dHAGCgeVmGjm43yn4Gqxh+5WsKjJyWWIZnh1ext83uM=; h=Mime-Version:Content-Type:Date:Message-Id:From:Cc:Subject:To: References:In-Reply-To; b=pnWq5XG+zYx5loX37zAO5A+hY3/DGaxvFWnOSx3afVwaQwTyAJC6BolwXdUeOamQrs5F+eAYX0cfLD0c8JKPPWi/CluytK5vXmCMLKtKxQKkv5IB6oshNNAg/17ykTBjuSNmwuJAXnEJEwwUmtk4TMTqD0Dgo7hfaqK1WXHfE44= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gimli.ms.mff.cuni.cz; spf=pass smtp.mailfrom=gimli.ms.mff.cuni.cz; dkim=pass (1024-bit key) header.d=gimli.ms.mff.cuni.cz header.i=@gimli.ms.mff.cuni.cz header.b=jR35gko6; arc=none smtp.client-ip=195.113.20.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gimli.ms.mff.cuni.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gimli.ms.mff.cuni.cz Received: from gimli.ms.mff.cuni.cz (gimli.ms.mff.cuni.cz [195.113.20.176]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by nikam.ms.mff.cuni.cz (Postfix) with ESMTPS id 7B0142807E0; Sun, 18 Feb 2024 16:09:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gimli.ms.mff.cuni.cz; s=gen1; t=1708268977; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oAxZkLmX1aRHRUsZ0ExGlhAyhq9nsWkycT8rOvRVdsU=; b=jR35gko6R0Gi7XNdojRdFa5sTNjDxzgE8LriPPgFpACmMlg5qfwiU5T2JrgbSIqhVDxpYo I1lkkmwo7c9tx+KGWuv2n2Fd9y1lPIUeOLIXPSlE5BQr8qvJ3MTLBWNw1QEe0Tymwxpd7T Lwyg69c5f7FQ1wcGo4p+8wZik0daxw4= Received: from localhost (internet5.mraknet.com [185.200.108.250]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: karelb) by gimli.ms.mff.cuni.cz (Postfix) with ESMTPSA id 415C24570C6; Sun, 18 Feb 2024 16:09:37 +0100 (CET) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sun, 18 Feb 2024 16:10:10 +0100 Message-Id: From: "Karel Balej" Cc: "Dmitry Torokhov" , "Krzysztof Kozlowski" , "Conor Dooley" , "Lee Jones" , "Liam Girdwood" , "Mark Brown" , , , , =?utf-8?q?Duje_Mihanovi=C4=87?= , <~postmarketos/upstreaming@lists.sr.ht>, Subject: Re: [RFC PATCH v2 1/6] dt-bindings: mfd: add entry for Marvell 88PM886 PMIC To: "Rob Herring" References: <20240211094609.2223-1-karelb@gimli.ms.mff.cuni.cz> <20240211094609.2223-2-karelb@gimli.ms.mff.cuni.cz> <20240215142052.GA4180777-robh@kernel.org> In-Reply-To: <20240215142052.GA4180777-robh@kernel.org> Rob Herring, 2024-02-15T08:20:52-06:00: > > .../bindings/mfd/marvell,88pm88x.yaml | 74 +++++++++++++++++++ > > Filename should match the compatible. > > In general, drop the 'x' wildcard. By "in general", do you mean for the drivers code also? As I have mentioned in the commit message for the driver, the other device is very similar and if the support for it was ever to be added (which I personally currently have no interest in), I believe it would make sense to extend this driver. Is it then still prefered to call it all just 88pm886 now? > > +properties: > > + compatible: > > + const: marvell,88pm886-a1 So the file should be called marvell,88pm886-a1.yaml, correct? Again, is it prefered to call it like this even if the other revision could eventually be added (again, I am not interested in that right now personally)? I mean, if I was implementing support for both revisions right now, it would make sense to name it just marvell,88pm886.yaml, no? Thank you, kind regards, K. B.