Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp712316rdb; Sun, 18 Feb 2024 08:15:02 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUIFD7QY88s0T4206D4l/87F6lJtiCJPa/DYRIhLrAleAmwyin5/9x11y1m8pfJFFiQmMfaPABKbixPf0gjPsLXRn4cKZPt/gNemR3joQ== X-Google-Smtp-Source: AGHT+IHiDF0eTShJYl62Samzqmozw6DPTxqT/OGCGmWgfXn6bs4MLdaXlf/uLzdLiGgloOFh0ayd X-Received: by 2002:a05:620a:13db:b0:787:4b3f:a1a0 with SMTP id g27-20020a05620a13db00b007874b3fa1a0mr5374062qkl.60.1708272902672; Sun, 18 Feb 2024 08:15:02 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708272902; cv=pass; d=google.com; s=arc-20160816; b=GgxJJKaE4mWxYz5rVQVR5dQkoQznD4q4A74oW6WfGKLNjYe9If2Vnqm2wl74EpTqUg SaItrN2UTYj/CSGwyHuwUoDuuou8Wu1RhUWt1n1Jx0dkVszRqnTLUH8RefsJmOtPOnzF SWhfbEh7GX+17MpDhWzGoXh6bqjipUcJZzr5il0llEs3G2SUB1FwolwzotBnkiFmZuuz +qDm08DtYPim7wz5RMvE2M9tgU3rOThKMcscvXREzETkePj0ILD6UB2ZzFUZuSFIIYMg w0lL3SjJh1ZmOaLhlgqI/jgRIwz0jdzDQ7MtX4afMrA8xU31b/v8jniMYymhHdPvQqaV QQgA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=KWAyxR0P1SelFxL/jAWkpeot6DvJbS6DVpjN+zhCWtE=; fh=sQqBbbKTxXN//6bP79Ie+091u0u7tXztTvdB6qJ1p1A=; b=qY6t9Ig9txkAp/qwSp6wHHUx48MY5UgAPgAKvPnNbNIcJoORsgtYiYAdTR82bfoqF/ glr76DuVdAOcr3HPkUQVS4qoxaWFR2Rhwi45CWZhJ7IZUV4oo+qzbclPVaterVOb4VK6 iVdqpRL+kLhHfTrIg5AdCrkThvYeNuGHYnb4pYEPdpF0mCBVNtO7t7Dcrvk2tTsH29/w gevRFudg1rgIFgAY44OUfkA8FoUTkIBh8v68WjaVqpXhEUhzMSZyieAWGeeLp7C3c46z gWQYvnkrWmfbJOvBEPGCG/e8na8xGwX7L8j9Ap9w9CpC951XEHq4uisSd0F+UVX5cPLP bLrQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=RwRk8WPH; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-70439-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-70439-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id b17-20020a05620a271100b00785600855a0si4710671qkp.17.2024.02.18.08.15.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Feb 2024 08:15:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-70439-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=RwRk8WPH; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-70439-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-70439-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 49D251C209A1 for ; Sun, 18 Feb 2024 16:15:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5856A6D1CD; Sun, 18 Feb 2024 16:14:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RwRk8WPH" Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 233A76D1B6; Sun, 18 Feb 2024 16:14:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708272893; cv=none; b=sec4xB145XUpPS3Nkrd9H/uZA52bRZCgnrw35C4xa1uTo7LvCzZxZ7duDi/dAcvh5m5ZgSsE5NJselWM+El1xaSU9UGsGcgEAvo735Xbr+32huRYamycFxiDihOwqINSPtll/2Ces5w/GNNG+0q1nDym+JAWz8UhxDX/K7HaqO8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708272893; c=relaxed/simple; bh=KWAyxR0P1SelFxL/jAWkpeot6DvJbS6DVpjN+zhCWtE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RxpnsOkhm2+MlMV3RFsc8KPPzbnKst+N4OozwXFMJ8vqfN2RzJ1MjDq3Nn57wgQqcS88UTW6C9KPFEbEha8qwTvoPVlhRKSWSCYaTT9Fah5qjMMsn0hHtbULYxM99Xk3LcamgmQMPsfySHGAWM+Xh41ECTxLsLribd7WjoQYEBY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RwRk8WPH; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1d934c8f8f7so33919655ad.2; Sun, 18 Feb 2024 08:14:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708272891; x=1708877691; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KWAyxR0P1SelFxL/jAWkpeot6DvJbS6DVpjN+zhCWtE=; b=RwRk8WPH/i3z6RoeKvDL00pBLEHZTh09vA1nbuD7dpx9RR81jH9DgurrwSPXN9jCK4 nlYD6tLiZEVtHyIlTtPgXb2sWL5WcpMEiZ4HxpMHfvipQH6us+kKeS5OsYbBaZaroRx0 O3K6A8UnmfRBPxpS0jZxI7zghl9jlydFVB6ejRz7jQ/MT4XU/t9B7mBIhh0dJcf6uiC6 DXDnpITY42WSS5y4ZWWtp7w1J/4qi7iR6K2WwbwkIyrqxJQ8564WS4DLB+FnsxCMk/BK i9jDFZ7UEkhJ+0FvFql1i/d3WBNzz8E5SRy6/troaE9w4PC9JQ8RXcZ0bvIxAnRluWK8 lPkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708272891; x=1708877691; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KWAyxR0P1SelFxL/jAWkpeot6DvJbS6DVpjN+zhCWtE=; b=GKhpEjau6rWpePl0Hn1Xnb45pp3vJj4OgcU5m3ZJxp+tb44JLj3BiDfKyRYhWcAsFu DbKi2+h0mAiXdhjgqBVQ31jLR+ELBRmTZXqlUGF/4Vy2l7Z9nboN0nvRgltZ7hxzXqu+ xTrQsGSSTpBW0EkhPdX0HTlVtj9iiPQg4x7MiLIFSmWXA6nyuThpvArkC8FqRxp837Sg Gyd4RSnNC74KTIqxuQ2lo9qJcGESFDDXfi+0wXLz8WTZw7TtV87T6EeiGD54JzDV3+f2 Bz/W+EBDEUmLv7FigV564jJzYzCjuyQIb/4WvhRjFfMnY/KDHaD2+S5dRbvuyTUHMAYB 4ufA== X-Forwarded-Encrypted: i=1; AJvYcCWUJW8ytqaaJDAgsW6SlRCbr2aVNOlYbEdGP6FUfzoMDK9feZlE8Uc6fWFbO0y16qNkiNEf1zCNdmvSAPJipeKKeiCuQTcQDqwJ/ke/PDhMKBgMo0LR8hlm72Q9asdEy8Ay0fcvYsrOe35ZU5UFFzTHqDeGXkKSU1qc+TX3G42girGp/OJE3mkylqUMiz3+tY6Y+X/tEnTItOGwEFZvcaj/0Un+ X-Gm-Message-State: AOJu0YzJU5w6Xd4CJf8fChUXAyv9ZJ6p6kf2JteiXSVi/M3455j3U8GT e5YeHlk9oySKxezdTfQLuMVWnyX4lzjnDXZF50mpOYoce9vTjO4X X-Received: by 2002:a17:902:c40e:b0:1db:5b41:c5ac with SMTP id k14-20020a170902c40e00b001db5b41c5acmr11689188plk.68.1708272891272; Sun, 18 Feb 2024 08:14:51 -0800 (PST) Received: from localhost.localdomain ([2406:3003:2000:500f:a246:8a16:bee7:140f]) by smtp.gmail.com with ESMTPSA id je20-20020a170903265400b001db4caef8d6sm2849500plb.161.2024.02.18.08.14.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Feb 2024 08:14:50 -0800 (PST) From: Lucas Lee Jing Yi To: rafael@kernel.org Cc: Perry.Yuan@amd.com, Xiaojian.Du@amd.com, alexander.deucher@amd.com, bp@alien8.de, deepak.sharma@amd.com, li.meng@amd.com, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-pm@vger.kernel.org, mario.limonciello@amd.com, nathan.fontenot@amd.com, oleksandr@natalenko.name, rafael.j.wysocki@intel.com, ray.huang@amd.com, shimmer.huang@amd.com, skhan@linuxfoundation.org, viresh.kumar@linaro.org, x86@kernel.org Subject: Re: [PATCH V14 0/7] amd-pstate preferred core Date: Mon, 19 Feb 2024 00:10:30 +0800 Message-ID: <20240218161435.38312-1-lucasleeeeeeeee@gmail.com> X-Mailer: git-send-email 2.43.2 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Dear all, I have found an issue with the patchset when applying on 6.7, leading to a large degradation in performance. On my 7840HS on *STOCK* 6.7 highest_perf is reported as 196, not 166 as assumed in the patchset. Applying the patchset causes highest_perf to be misreported and hence a misreported maximum frequency as well, at 4.35GHz instead of 5.14GHz, leading to the degradation in performance. However, On my 5950X, highest_perf is indeed reported as 166 before and after applying the patchset. Hence, I propose the following patch (should be attached). I do apologize for any mistakes as I am new to this and this is my first email on the mailing list. Cheers! Lucas