Received-SPF: pass (google.com: domain of linux-kernel+bounces-70472-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Sun, 18 Feb 2024 19:01:05 +0100
From: Pavel Machek <pavel@ucw.cz>
To: Sasha Levin <sashal@kernel.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	Dan Carpenter <dan.carpenter@linaro.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Niklas Cassel <cassel@kernel.org>,
	Ilpo =?iso-8859-1?Q?J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	jingoohan1@gmail.com, gustavo.pimentel@synopsys.com,
	lpieralisi@kernel.org, kw@linux.com, linux-pci@vger.kernel.org
Subject: Re: [PATCH AUTOSEL 6.1 23/28] PCI: dwc: Clean up
 dw_pcie_ep_raise_msi_irq() alignment
Message-ID: <ZdJF4fpSn/0goBqb@duo.ucw.cz>
References: <20240213002235.671934-1-sashal@kernel.org>
 <20240213002235.671934-23-sashal@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="oOSR12Xp1ziJzYR1"
Content-Disposition: inline
In-Reply-To: <20240213002235.671934-23-sashal@kernel.org>


--oOSR12Xp1ziJzYR1
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

> From: Dan Carpenter <dan.carpenter@linaro.org>
>=20
> [ Upstream commit 67057f48df79a3d73683385f521215146861684b ]
>=20
> I recently changed the alignment code in dw_pcie_ep_raise_msix_irq().  The
> code in dw_pcie_ep_raise_msi_irq() is similar, so update it to match, just
> for consistency.  (No effect on runtime, just a cleanup).

Just a cleanup, we don't need it in stable.

Best regards,
									Pavel
								=09
> +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c
> @@ -528,9 +528,10 @@ int dw_pcie_ep_raise_msi_irq(struct dw_pcie_ep *ep, =
u8 func_no,
>  		reg =3D ep_func->msi_cap + func_offset + PCI_MSI_DATA_32;
>  		msg_data =3D dw_pcie_readw_dbi(pci, reg);
>  	}
> -	aligned_offset =3D msg_addr_lower & (epc->mem->window.page_size - 1);
> -	msg_addr =3D ((u64)msg_addr_upper) << 32 |
> -			(msg_addr_lower & ~aligned_offset);
> +	msg_addr =3D ((u64)msg_addr_upper) << 32 | msg_addr_lower;
> +
> +	aligned_offset =3D msg_addr & (epc->mem->window.page_size - 1);
> +	msg_addr =3D ALIGN_DOWN(msg_addr, epc->mem->window.page_size);
>  	ret =3D dw_pcie_ep_map_addr(epc, func_no, 0, ep->msi_mem_phys, msg_addr,
>  				  epc->mem->window.page_size);
>  	if (ret)

--=20
People of Russia, stop Putin before his war on Ukraine escalates.

--oOSR12Xp1ziJzYR1
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCZdJF4QAKCRAw5/Bqldv6
8vf4AJ4o/jGq/kmWV+QMUeG3I4szSZ4hlgCgiBDLYKaidLZEgsXTlmoz+/hUa8o=
=pFQ8
-----END PGP SIGNATURE-----

--oOSR12Xp1ziJzYR1--