Received-SPF: pass (google.com: domain of linux-kernel+bounces-70477-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Sun, 18 Feb 2024 19:07:28 +0100
From: Greg KH <gregkh@linuxfoundation.org>
To: Kees Cook <keescook@chromium.org>
Cc: "Tobin C. Harding" <me@tobin.cc>, Tycho Andersen <tycho@tycho.pizza>,
	Guixiong Wei <guixiongwei@gmail.com>,
	linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leaking_addresses: Provide mechanism to scan binary files
Message-ID: <2024021819-sacrament-violator-428d@gregkh>
References: <20240218173809.work.286-kees@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240218173809.work.286-kees@kernel.org>

On Sun, Feb 18, 2024 at 09:38:12AM -0800, Kees Cook wrote:
> Introduce --kallsyms argument for scanning binary files for known symbol
> addresses. This would have found the exposure in /sys/kernel/notes:
> 
> $ scripts/leaking_addresses.pl --kallsyms=<(sudo cat /proc/kallsyms)
> /sys/kernel/notes: hypercall_page @ 156
> /sys/kernel/notes: xen_hypercall_set_trap_table @ 156
> /sys/kernel/notes: startup_xen @ 132
> 
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> Cc: "Tobin C. Harding" <me@tobin.cc>
> Cc: Tycho Andersen <tycho@tycho.pizza>
> Cc: Greg KH <gregkh@linuxfoundation.org>
> Cc: Guixiong Wei <guixiongwei@gmail.com>
> Cc: linux-hardening@vger.kernel.org
> ---
>  scripts/leaking_addresses.pl | 53 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 53 insertions(+)

Nice!

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>