Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp785575rdb; Sun, 18 Feb 2024 11:35:55 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXgSx9G7wBNs/ovf0hKBq/f9ScojNXhERFoiwzD1z2c8r7kU5uh+I6d3QTNW2RhJysQljT3EO7gZtetQtVtYd1yipL6zfGM3u1zPf86HA== X-Google-Smtp-Source: AGHT+IEbtRdDzUijpQIUll2hf62xRx7T/uh5ETJbmtXndRyF/+ZlIL1rgj/bEFT/5ibwQfm5Nt+H X-Received: by 2002:a81:b243:0:b0:5fb:da77:af07 with SMTP id q64-20020a81b243000000b005fbda77af07mr8972485ywh.32.1708284955512; Sun, 18 Feb 2024 11:35:55 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708284955; cv=pass; d=google.com; s=arc-20160816; b=U737uw2+ySZJngDLNeYSIFvtsCz0v980N/kBNfR9FaW3X14EI60Uuwf/qAF3CXV8v2 ayuvCdUm8ZqDkVFX78AshYU45n7pInME0BnhycC6ZHoKaUHiMX+B2NSEdCX9tV0hrBCl h/c+Pfw7brczF+S4VfHKk9pnYJ8pGgSoxEZO4O/qb1gyMbHkZLK4/Cg2c/I+/kWgP2dc Chlw9AVvG5fQXOOSmTDCzHdC7116lqbAWHpvcclwpHrcaSU7m9ggIyQfcjMRaekpxpvS 9vTjxRvpJcvO9QTwtuMSg9xOVJO4WznfZ7XrgUy3vxx33hjUcIihklTFrzzT4tGKkCtt mOUQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date:dkim-signature; bh=kP93Q1m5tjAZqLrYzqmBsZVmIXS8VDSyfvhf3lGrLcU=; fh=WShH+suyGbda4YO6qJqxEouz6obFAAWUE7m5ZpSuZOw=; b=r4El1GNeWDixOuyPfkCSIlKyjU22aCeTnmsjDmQPMNgd9FKX9HD5KWyN1MQVk4vDCd yZOORZIcAU5c/KjYRhk/uSLpPhBv698eK4FR/cavQRzCzj8EljFY2kvdvXQHqIoP4KS8 IfFSyFLyjuJNM++BHtzynIqOlaHJO838UGgzM2MC/EfnPgD+kkXY5nWSS20Fp2pnHp5t fxtAjw4fRGjLSderFDiJMMTHVO9DiOPSCEW7l3epd9SG/lW1KcriEKuOOQER+0NLrpUS PSwrroTNan+7Ot6NWuoJojUbAUgfhtKeqGGI7ELkW8TJ1KBIwGVM1iTOR4E+11zqQQXP Sb4w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=Hlrl7vMg; arc=pass (i=1 dkim=pass dkdomain=armlinux.org.uk dmarc=pass fromdomain=armlinux.org.uk); spf=pass (google.com: domain of linux-kernel+bounces-70552-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-70552-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id x10-20020a05620a14aa00b0078730b26229si4866583qkj.210.2024.02.18.11.35.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Feb 2024 11:35:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-70552-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=Hlrl7vMg; arc=pass (i=1 dkim=pass dkdomain=armlinux.org.uk dmarc=pass fromdomain=armlinux.org.uk); spf=pass (google.com: domain of linux-kernel+bounces-70552-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-70552-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 4627F1C210A5 for ; Sun, 18 Feb 2024 19:35:55 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D93D071B42; Sun, 18 Feb 2024 19:35:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="Hlrl7vMg" Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9832383A3; Sun, 18 Feb 2024 19:35:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708284947; cv=none; b=if+EdiR1Ps6P0fS8hXBd3d68Fw0tbOhr6PoRzejWSuMuD6bfkIA9ASeM6Ywp0Y1zlBmMWyXQLH6yvY8TtX+PIkff/q1vKJaW+IKms6/hRGOkSf84g66IBkvOoYq578imITWsv86UbBaqiRbKKRAyGLyCuBPy2yAvHvnLkFgk4Nc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708284947; c=relaxed/simple; bh=iCJNjC0YeEXkUS/DQGwV/OAvF2cLq0aBfrb0k5dMU/k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=r1HcDnoK9drlgcwWixcNsUF9lBI8OQ2+BWXkHwVR3gNjrPoFBUqnjOuVwd3MIbkrOOans0V5MZSi4DbP4IavRzMiG6U5+x5VEOnB6pLbLaTu8A9rAU1j5nx91MLeiMF1uhQgTW/Ik5e+u6eiEvW6d4Vfe1lnXJMQSAA2obJFj7Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=Hlrl7vMg; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=kP93Q1m5tjAZqLrYzqmBsZVmIXS8VDSyfvhf3lGrLcU=; b=Hlrl7vMgSWjf0d4k1EPg0rzsf9 k/CQwX5IZgggyzwf2/FmkA+8o5WBQ7JfSPeAelJAi7WpAY8qCQOjvXsjKkux/n9xb4iHyB8j4kqQk 41Q9CoWV57SuNTDLy5SNenxvo2FC2FYqOhAauY2wc3/WzOB/wJWlSvwuNu8BQKksa7oN4IA5BjHr1 I2NZB/JKvLpiLVyWoj2qn1UtEZRBOZo0p9sI2eoETn0oOFQ+lBagpuqSLhkOmO0OqOGOwj7cWKvck +IHXXUj88j7XT5t1yEUQ9e5WKkmsBU2OpP17yIqoqVplBuQqMyR9e7smKOp8r9/6RCrzYqsYQVV7o dpPDMwjQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:58462) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rbmwm-0003TZ-06; Sun, 18 Feb 2024 19:35:32 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1rbmwk-0007ec-Hp; Sun, 18 Feb 2024 19:35:30 +0000 Date: Sun, 18 Feb 2024 19:35:30 +0000 From: "Russell King (Oracle)" To: Christian Marangi Cc: Andrew Lunn , Heiner Kallweit , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Florian Fainelli , Broadcom internal kernel review list , Robert Marko , Greg Kroah-Hartman , Pieter Jansen van Vuuren , Nipun Gupta , Andy Shevchenko , Puneet Gupta , Abhijit Gangurde , Umang Jain , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [net-next RFC PATCH 2/6] net: phy: fill phy_id with C45 PHY Message-ID: References: <20240218190034.15447-1-ansuelsmth@gmail.com> <20240218190034.15447-3-ansuelsmth@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240218190034.15447-3-ansuelsmth@gmail.com> Sender: Russell King (Oracle) On Sun, Feb 18, 2024 at 08:00:28PM +0100, Christian Marangi wrote: > With C45 PHYs that provide PHY ID in C45 Package regs, PHY device > .phy_id is not filled. Intentionally so. Clause 45 PHYs don't have a single ID. Marvell 88X3310 is a case in point - there are at least two different vendor IDs in this PHY. Trying to squash Clause 45 PHY IDs down to a single identifier is not sensible. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!