Received-SPF: pass (google.com: domain of linux-kernel+bounces-70644-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240217185202.1754750-1-megi@xff.cz> <20240218205908.GA12766@pendragon.ideasonboard.com>
 <pftafukuzq7qzbhlvwtmeg3mburnttylgy4246timlghtrdgx4@r6munvmj6oqt>
In-Reply-To: <pftafukuzq7qzbhlvwtmeg3mburnttylgy4246timlghtrdgx4@r6munvmj6oqt>
From: Adam Ford <aford173@gmail.com>
Date: Sun, 18 Feb 2024 20:09:01 -0600
Message-ID: <CAHCN7x+zi3WxnY-mxZFKePs1cS=-DprEmh_CnypJ4XK7xBzjMQ@mail.gmail.com>
Subject: Re: [PATCH] media: rkisp1: Allow higher input resolution
To: =?UTF-8?Q?Ond=C5=99ej_Jirman?= <megi@xff.cz>, 
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>, linux-kernel@vger.kernel.org, 
	Dafna Hirschfeld <dafna@fastmail.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, 
	Heiko Stuebner <heiko@sntech.de>, 
	"open list:ROCKCHIP ISP V1 DRIVER" <linux-media@vger.kernel.org>, 
	"open list:ROCKCHIP ISP V1 DRIVER" <linux-rockchip@lists.infradead.org>, 
	"moderated list:ARM/Rockchip SoC support" <linux-arm-kernel@lists.infradead.org>, 
	Paul Elder <paul.elder@ideasonboard.com>, Umang Jain <umang.jain@ideasonboard.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, Feb 18, 2024 at 3:02=E2=80=AFPM Ond=C5=99ej Jirman <megi@xff.cz> wr=
ote:
>
> On Sun, Feb 18, 2024 at 10:59:08PM +0200, Laurent Pinchart wrote:
> > Hi Ondrej,
> >
> > (CC'ing Paul and Umang)
> >
> > Thank you for the patch.
> >
> > On Sat, Feb 17, 2024 at 07:51:58PM +0100, Ond=C5=99ej Jirman wrote:
> > > From: Ondrej Jirman <megi@xff.cz>
> > >
> > > In BSP driver, it is allowed, and it works in practice. Tested on
> > > Pinephone Pro/RK3399 with IMX258 at full res.
> >
> > Paul, Umang, do I recall correctly that you have a similar change ?
> > Could you review and test this (especially on the i.MX8MP) ?
>
> It's also a limit from the datasheet, so the change should not be that
> controversial:
>
>   https://megous.com/dl/tmp/d2b333043ecebaf3.png
>
> (so that it doesn't sound like I just copied the BSP values)
>

From what I see in the i.MX8M Plus reference manual, it has a max
resolution of 4096x3072, so it might be necessary to move this off
from a #define into a structure that varies by product family.

adam
> regards,
>         o.
>
> > > Signed-off-by: Ondrej Jirman <megi@xff.cz>
> > > ---
> > >  drivers/media/platform/rockchip/rkisp1/rkisp1-common.h | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h b=
/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h
> > > index 4b6b28c05b89..74098ddbeeb3 100644
> > > --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h
> > > +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h
> > > @@ -33,8 +33,8 @@ struct dentry;
> > >  #define RKISP1_ISP_SD_SINK                 BIT(1)
> > >
> > >  /* min and max values for the widths and heights of the entities */
> > > -#define RKISP1_ISP_MAX_WIDTH                       4032
> > > -#define RKISP1_ISP_MAX_HEIGHT                      3024
> > > +#define RKISP1_ISP_MAX_WIDTH                       4416
> > > +#define RKISP1_ISP_MAX_HEIGHT                      3312
> > >  #define RKISP1_ISP_MIN_WIDTH                       32
> > >  #define RKISP1_ISP_MIN_HEIGHT                      32
> > >
> >
> > --
> > Regards,
> >
> > Laurent Pinchart
>