Received-SPF: pass (google.com: domain of linux-kernel+bounces-70685-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 19 Feb 2024 12:46:35 +0900
From: Hojin Nam <hj96.nam@samsung.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Robert Moore <robert.moore@intel.com>, "Rafael J . Wysocki"
	<rafael.j.wysocki@intel.com>, Len Brown <lenb@kernel.org>,
	linux-acpi@vger.kernel.org, acpica-devel@lists.linux.dev,
	linux-kernel@vger.kernel.org, ks0204.kim@samsung.com, wj28.lee@samsung.com,
	alison.schofield@intel.com
Subject: Re: [PATCH] ACPI: Fix CXL 3.0 structure (RDPAS) in the CEDT table
Message-ID: <ZdLPG2J0jVgRo5/s@calab-Precision-7920-Tower>
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <CAJZ5v0gusbAKRQVCgbvK7A6G8KQ5piNdUS=Sm3H2tWiSp-beGQ@mail.gmail.com>
Content-Type: multipart/mixed;
	boundary="----BUp_ENxb-nhquF.XJ9b44EtHNmvLAWOaNa9oXIBU2Tjzxkvf=_e9aa1_"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <CGME20240216072906epcas2p407a2f85aca1b9b8677fb8aa458c53aa6@epcas2p4.samsung.com>
	<20240216072931.34305-1-hj96.nam@samsung.com>
	<CAJZ5v0gusbAKRQVCgbvK7A6G8KQ5piNdUS=Sm3H2tWiSp-beGQ@mail.gmail.com>

------BUp_ENxb-nhquF.XJ9b44EtHNmvLAWOaNa9oXIBU2Tjzxkvf=_e9aa1_
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Content-Disposition: inline

On Fri, Feb 16, 2024 at 07:39:15PM +0100, Rafael J. Wysocki wrote:
> On Fri, Feb 16, 2024 at 8:29 AM <hj96.nam@samsung.com> wrote:
> >
> > From: Hojin Nam <hj96.nam@samsung.com>
> >
> > struct acpi_cedt_rdpas does not match with CXL r3.0 9.17.1.5
> > Table 9-24. reserved1 and length fields are already added by
> > struct acpi_cedt_header.
> >
> > Signed-off-by: Hojin Nam <hj96.nam@samsung.com>
> > ---
> >  include/acpi/actbl1.h | 2 --
> 
> This file is part of ACPICA which is a separate project whose code is
> used by the Linux kernel.  In order to make changes in the ACPICA
> code, please submit a pull request to the upstream ACPICA project on
> GitHub.  Once this pull request is merged, you can send a
> corresponding Linux patch with a Link: tag pointing to it.  However,
> it is not necessary to do so, as the changes will be automatically
> included into the ACPICA code in the kernel once a new version of
> ACPICA is out.
>

I submitted PR to the ACPICA project on Github[1].
Thanks for the guide!

Link: https://github.com/acpica/acpica/pull/928 [1]
 
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h
> > index a33375e055ad..7aff8c39dbd6 100644
> > --- a/include/acpi/actbl1.h
> > +++ b/include/acpi/actbl1.h
> > @@ -571,8 +571,6 @@ struct acpi_cedt_cxims {
> >
> >  struct acpi_cedt_rdpas {
> >         struct acpi_cedt_header header;
> > -       u8 reserved1;
> > -       u16 length;
> >         u16 segment;
> >         u16 bdf;
> >         u8 protocol;
> >
> > base-commit: d37e1e4c52bc60578969f391fb81f947c3e83118
> > --
> > 2.34.1
> >
> 

------BUp_ENxb-nhquF.XJ9b44EtHNmvLAWOaNa9oXIBU2Tjzxkvf=_e9aa1_
Content-Type: text/plain; charset="utf-8"


------BUp_ENxb-nhquF.XJ9b44EtHNmvLAWOaNa9oXIBU2Tjzxkvf=_e9aa1_--