Received-SPF: pass (google.com: domain of linux-kernel+bounces-70706-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <7a34f233-7de6-4e3e-bf16-4cbd8dd22a6a@amd.com>
Date: Mon, 19 Feb 2024 09:53:30 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] platform/x86/amd/pmf: Fix a suspend hang on Framework 13
Content-Language: en-US
To: Hans de Goede <hdegoede@redhat.com>,
 Mario Limonciello <mario.limonciello@amd.com>
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org,
 Linux regressions mailing list <regressions@lists.linux.dev>,
 Trolli Schmittlauch <t.schmittlauch@orlives.de>
References: <20240217005216.113408-1-mario.limonciello@amd.com>
 <f6cced34-087a-4593-b510-a8a728deab97@redhat.com>
From: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
In-Reply-To: <f6cced34-087a-4593-b510-a8a728deab97@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WDJiM1BYTmFBZk9RTFhwS2pJa21sOUVHY3ZFOWFIZ2pEUlVDVkxGRVFrd2NB?=
 =?utf-8?B?aXhBOUFJeEE3M0dyeUJvakVMcHlubmdLQ05rTW4zTC80WHlnUTVVQ1pUYTNo?=
 =?utf-8?B?RlBpVUZlOXVWanpTMjkvUFlnMnNMMm5ybTZWQVdsSGU0bHNzeU1VUEMrcWJ6?=
 =?utf-8?B?OXF1d3F3Ri9XSFV1NU9Ba25QYzlWeGdUVWV0clVuOGcrRURFWFpDMWpNWjNY?=
 =?utf-8?B?L0E1WVJKRk1CR1FHbGVmb3J3bVJ0U3cyYmw3cXZZU0t3TnJlTDdUK0FZcUJo?=
 =?utf-8?B?SWtwbDZqTlVCNTl0cERYKzB1MXBRTlRwWnVrNjhzKzVBMzVhNFovR3RzYm9U?=
 =?utf-8?B?T3dVMGVGUFRtM3Y4N3J6NjNBOU91ZnFsREVjR1ppd2xlY1N6Q2tuV3gwQWQr?=
 =?utf-8?B?ZkY0clBuNUNVQnorMWpwZWhJMWxzMmJydnhibEFnOE8xZE1EekUzeFJJMHZU?=
 =?utf-8?B?bnhjSERKTXkvNVVDU0Vpd1lHYmlXLzhmRzA4TlZCZ0VhUXRFaGVrU2NacEVu?=
 =?utf-8?B?L2QvbHZXYjFEV3Fma1NweDlka2g3WTBHblRqS0hOV0RkRERoK1NpQ21tanVs?=
 =?utf-8?B?akFEYjdkR0tnbWcwdnIrZ3M1c24xNzFtenVvQ2YzcVg3V1hRbW1sZFdxM1Rj?=
 =?utf-8?B?RjdIcW9SMzYyNHJCL01MNERJV0E1VWMvZjRZNFVLUE5ndU8wSTJsaEp4Mitn?=
 =?utf-8?B?aW8xOHhSZDVFanlxVHZOUEJJNUdzRUZxN2MxdVlHVzFPS0pnaTkxQURxTDFn?=
 =?utf-8?B?K2kwMU82blBsL3V5dk9ZdTRzV0k1Z3l0bXZSc2FqcXI3OFlIL3FQK2ZMVVAz?=
 =?utf-8?B?dnBpalFyeG1iQWgwaFgrN1QyMmZUYmlzRUtDKzNxbmFxdkV0LzNMY2c4a2JB?=
 =?utf-8?B?dDlHNWJOczRpcWRHTE5tNmYyQUFZc1Y4b3VwWlp0c0RZd1d3YUY4YlExd3Jz?=
 =?utf-8?B?aEJVS2dxNEdoWFEvNnlhd2RyNkR5SjNLdHpwOUdaWUFSZnZwUCt1UjBwb3NS?=
 =?utf-8?B?S01QMmYxdkVIUGNHQURwM3VUNGpHUEtLUWRYSTBvUXRmdEhSOG9qMVRxQTRp?=
 =?utf-8?B?VzJqcUQvQnVkWTJqQlVxdXpVa0xOelJ1S1lCdGVNaStGZzlvU3o2V3hsQWZC?=
 =?utf-8?B?dTBvck1maXN6TjNFa1UyN2oyRUFLdm1mZzkrazFHSEFJR0hQVGRhWWN2dEpN?=
 =?utf-8?B?Rlk3SU4vdmgvZmp2VlBVTEtncVJyL2lsRloxbTl1WmlRWmFRaXZSNVA5Zm1v?=
 =?utf-8?B?d05kdWVNVlJWbzFjZFl0OHk2UGdOK2ppRVh3NVBRNUN4Z3N4Nk1mWThsK3FQ?=
 =?utf-8?B?bEYxcWVFNndpSEFnM0xHUHBUdEZibUxjOUpKRml1ZVdCQkxFMlhHRS9HMWFt?=
 =?utf-8?B?d1dmeEJrcXNPa1J4ZjhieUp2TUd5eTQ5ODdxSFFvUlNSd3FUSTBOL0Y1NkNs?=
 =?utf-8?B?bE9qUjJLdEQwTVpCU2xMUDFTOVNFS3VYVUtEei9rNXBmamliU2wrZU1SRkhI?=
 =?utf-8?B?RytzL0pRYWhoWTJUdFdxeFB3Vkp0aXBKNDdKL25qU0k2b1ZyWmdObnBYVW1P?=
 =?utf-8?B?dFhJTzFoWm5XUDhUd0hEallaNE0vb29rWldpOHhhbGdZZHlkR1hkU0hxOHl3?=
 =?utf-8?B?U1M0YzdlWHpzQ1FSWFo3WTlJSGVtdzJVakxDUVpHZ1pIanFUYWRkRDlFTE5W?=
 =?utf-8?B?U3ExOE5LUnpoUWRDaTcxczdJYWwyMFpCRjhETnFWVHFRNUFIUzVuSm1Qbk1l?=
 =?utf-8?B?bmhUK3hNQmFETHJFK1dmTjlLT05VMjdUa2dKVWNETmMzUDBlc1JnTzA0N1Fu?=
 =?utf-8?B?czIwdVFONE1nZmdLdEN1bFk1V2ptSDlpR3FnV2gwYlVIRVVDVVpIN1FCMmNO?=
 =?utf-8?B?S0RWNTZmT2E0Sk1Xc1N1MXFFOWErZHY3cTZjL2NISXlmcWQwS0JYWWFBVytj?=
 =?utf-8?B?dnJXNVo3UEZnbzZmdEtjV2N6bVpSdkl3YUhvcXd2V2Z3dHRHd0JnOGhkNmVD?=
 =?utf-8?B?ano4R001NmtoRmNic2RiSGlQdDNMQjhJNzF0UDVXQVZqRVBValRvLzRZWmpN?=
 =?utf-8?B?UHIxODRHQnRhY0pNd0svdDVYUHcvSEh0eEJqdDlGRG1YbWxlZVYxbGhRVExq?=
 =?utf-8?Q?eB5t2HBX8xVJrMULXlNiysctd?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8775bb05-2010-47b0-8371-08dc31028b0c
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5176.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Feb 2024 04:23:37.5324
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AfJszquQq/+RFai6mKO04fskO3iPbPXoK9Dg3kk9yDJqqg7G6/WyoSa/g+NP0t0Tt7Khnt2cFTsWXKVaU9FNSg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6011

Hi Mario,

This was super quick! Thank you for the help. Seems like lot of action
happened over the weekend :-)

Hi Hans,


On 2/18/2024 15:56, Hans de Goede wrote:
> Hi,
> 
> On 2/17/24 01:52, Mario Limonciello wrote:
>> The buffer is cleared in the suspend handler but used in
>> the delayed work for amd_pmf_get_metrics().
>>
>> Stop clearing it to fix the hang.
>>
>> Reported-by: Trolli Schmittlauch <t.schmittlauch@orlives.de>
>> Closes: https://lore.kernel.org/regressions/ed2226ff-257b-4cfd-afd6-bf3be9785474@localhost/
>> Closes: https://community.frame.work/t/kernel-6-8-rc-system-freezes-after-resuming-from-suspend-reproducers-wanted/45381
>> Fixes: 2b3a7f06caaf ("platform/x86/amd/pmf: Change return type of amd_pmf_set_dram_addr()")
>> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> 
> Ugh, I should have caught this during review. I especially asked
> for the alloc parameter to amd_pmf_set_dram_addr() to be added
> for this. Ah well ...
> 
> Thanks, patch looks good to me:

Thank you for the support!

Thanks,
Shyam

> 
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> 
> Regards,
> 
> Hans
> 
> 
> 
>> ---
>>  drivers/platform/x86/amd/pmf/core.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/platform/x86/amd/pmf/core.c b/drivers/platform/x86/amd/pmf/core.c
>> index 853158933510..4f734e049f4a 100644
>> --- a/drivers/platform/x86/amd/pmf/core.c
>> +++ b/drivers/platform/x86/amd/pmf/core.c
>> @@ -299,8 +299,6 @@ static int amd_pmf_suspend_handler(struct device *dev)
>>  	if (pdev->smart_pc_enabled)
>>  		cancel_delayed_work_sync(&pdev->pb_work);
>>  
>> -	kfree(pdev->buf);
>> -
>>  	return 0;
>>  }
>>  
>