Received-SPF: pass (google.com: domain of linux-kernel+bounces-70709-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <6146eb3b-720a-4523-bcc7-8e2656aeafef@gmail.com>
Date: Sun, 18 Feb 2024 20:26:29 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [net-next RFC PATCH 6/6] net: phy: bcm7xxx: rework phy_driver
 table to new multiple PHY ID format
Content-Language: en-US
To: Christian Marangi <ansuelsmth@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
 Heiner Kallweit <hkallweit1@gmail.com>, Russell King
 <linux@armlinux.org.uk>, "David S. Miller" <davem@davemloft.net>,
 Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,
 Paolo Abeni <pabeni@redhat.com>,
 Florian Fainelli <florian.fainelli@broadcom.com>,
 Broadcom internal kernel review list
 <bcm-kernel-feedback-list@broadcom.com>, Robert Marko <robimarko@gmail.com>,
 "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@amd.com>,
 Nipun Gupta <nipun.gupta@amd.com>,
 Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
 Puneet Gupta <puneet.gupta@amd.com>,
 Abhijit Gangurde <abhijit.gangurde@amd.com>,
 Umang Jain <umang.jain@ideasonboard.com>, netdev@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <20240218190034.15447-1-ansuelsmth@gmail.com>
 <20240218190034.15447-7-ansuelsmth@gmail.com>
From: Florian Fainelli <f.fainelli@gmail.com>
In-Reply-To: <20240218190034.15447-7-ansuelsmth@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 2/18/2024 11:00 AM, Christian Marangi wrote:
> Rework bcm7xxx PHY driver table to new multiple PHY format
> implementation to reduce code duplication and final size of the compiled
> module.

I like the idea of sharing as much code as possible and creating a 
smaller module, however by changing the name, you are creating an 
user-space ABI change, we rely upon the exact PHY name being shown under 
/sys/class/mdio_bus/*/* and this change will break that.

Thanks!
-- 
Florian