Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp934133rdb; Sun, 18 Feb 2024 20:39:47 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCU3Ux0Mbu9Bb1HxP97VjOR4OMmBYTejqc+XB0AFH7mXimJ5KBFsNOeAAnAUlyZ87fxZ6sZNtSF23uwYzqrzs7QWLhSLPvlrx6y+XY5eew== X-Google-Smtp-Source: AGHT+IE90eR4K3Oe0UwJ3wirHGKAjvmgBhVgbCs0eolkFdqWlEbQpjPnhtL+T/brwrpO9/7FgtTv X-Received: by 2002:a05:6a21:1583:b0:19c:9219:f3eb with SMTP id nr3-20020a056a21158300b0019c9219f3ebmr14357406pzb.37.1708317587309; Sun, 18 Feb 2024 20:39:47 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708317587; cv=pass; d=google.com; s=arc-20160816; b=uj43gtZ3BuM9DcGeR1Yj8U3rRrAg/YJi2DItyXU9+Kd1U0aA8FfWwObjJBh/ZUKu5U UaYuP4orX59r5dnBV88wqaPwdk8qBOvdz55XRXzEmzaumsRe1rl96QFNDmakee+w73kX d0Vzr/W+c5s8FBxUur5uts11M2qyH/zv6sOS+E33yYLqVshI26e+p5CYmmpXMrPGGsBf ElSe+ekNHbyoPV7yJeTV/ttzFr4YyAuyG2AcgN+b/8AMscS/v8tl5MYZDX1em9K2gfls m5CrYBiGh37gTXslviM+CiY34VLwH1tXLM9PFw9uX5nkct+r9O5vWodJbyBDTIipEnA0 y7UA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=zdNwOk35Zc4yLcZkronDrKEG/Pad3CGoQyORwvnBAjY=; fh=aRTVb1Hw62RuwnRAV1ANHJ6Q8sBG4/9kk4iZy9SbuM8=; b=TC5j00r64xzpQ5JmR120pEwVE6eFy6l3/9HDrSRcHcuuzoqcl1XrYvJjCw8K2djrXR CltNp6d7I4DCduDqvHcVsrFabkEQfdd+y+kcFlrHnTZmjGy+0cW5H6zGqM9JZ53oKu6o F6JOZz3uVpWmetbOmtxtx8YMMNUktvyVLc4HP+Og5LSz0L2153fuxw7Ll0E/p+BQor/m 06h1jMVC7zFC3Wuotwz/Qkb2xOF8Y6VTwhMR41BUP5tiFHlwre/FJ6Pv9tbh/zeE2FEe dJQ8FP4C6BSPGcP8fsAPT8kF63Onfmpzvx/SZcfVudWhFzF3q2L9N41/eG3R7NW5nqbB jL2Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=F1GF5uBY; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-70711-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-70711-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id mw18-20020a17090b4d1200b00299785035dcsi2220299pjb.107.2024.02.18.20.39.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Feb 2024 20:39:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-70711-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=F1GF5uBY; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-70711-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-70711-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 6F73EB21D25 for ; Mon, 19 Feb 2024 04:39:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 574361CD0A; Mon, 19 Feb 2024 04:39:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="F1GF5uBY" Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F8983C26 for ; Mon, 19 Feb 2024 04:39:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708317577; cv=none; b=ig4UfN7VQ9DNmYRIePSIItDwuPiAKlRjbnaHo9mAKkjRFj+sSexoxf/vQMkMOILMxUzQvoUXmRMRGai7NMFMW8o+jqQtYu3390agCOU5pReLi/wr2mFI577RjuNyAIzPLjMjjhg1BmUYIQ1ZypTkQkl7kkWBRzUYABpC+xwPA9s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708317577; c=relaxed/simple; bh=jNce4zGsBXTcpAYg6spprQg+FOqejy9WtcVsfsPW6Qc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=C73u0cgKEHyqioiZ3ml+UNEX5IEx8/q1DkdjQf8Er3/KDrI0s92UewTGEciGTzud8Bwp8ZYS9HdRgU1vPZ6MCiqvkCX0rWFmKIlv3OUj9ZDyrq+l/fPlTRzJbErMSOiNeR9c9di12KnUH7Ja0hqnNwSQXnj9hPq8iaGcwoSqxGI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=F1GF5uBY; arc=none smtp.client-ip=209.85.215.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-5d8ddbac4fbso3303534a12.0 for ; Sun, 18 Feb 2024 20:39:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1708317575; x=1708922375; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zdNwOk35Zc4yLcZkronDrKEG/Pad3CGoQyORwvnBAjY=; b=F1GF5uBYoyeDTEOKgtlot2lsN1nN1lqmiZgqLjQTmkyxCAkz/lVZFENNNy8lPCYUV1 EHyHMyOPE1GQJr/25VXLWMj1mPfajUoO409uY0rJxRB+/xpHEonMlohlYvPMVcRuq/X8 WZ5z1cP63t+E+Q49D4TkyQRDZ2YHn55O9pf6E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708317575; x=1708922375; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zdNwOk35Zc4yLcZkronDrKEG/Pad3CGoQyORwvnBAjY=; b=Tuob02BvHEouSUXbU79K7ZhxuHtxHO42dpRUe+wBhfWi7kjhLT7ssfEkLmoO51qwPz MlAX1mpBFJkOXEEk/9tBsz5Xnkkz1uUUCAjOA6uDmAcqpL8hMoPEMLMIrR8ydb1fZF2L 8Mh08k/6r7V6TS2PvX3XlAlIELmEe3RKx5osJREDHAkzwhCPdXNCJq79F+uhnsE7vltr BEzXoRLYeW/QzC359Kdh/k5G5lw3dsm0Ko1kMj8b1a60rYrfzR2Ew1d3llwB9n3jTfgr sH61ict2EXs7shB1xV9aC+6m3joFEFXn+q0ILeWf0tH2b1eRf8KZGE51xQqGkB5nib+g 7law== X-Forwarded-Encrypted: i=1; AJvYcCXgUizL9NEUryZHnC0p1HYQiAvZJOjIlv1hAtpbxpSbp3X19XEcSX4ZufxfVoPPrAVtPzXbEWSulVF+3bzoZkiWn6sUA08EgCu+lVdl X-Gm-Message-State: AOJu0Yye7gmS57MUKkQA2iAv2rVK/uYyiDyiKUMga8AV6tT7tbeKwPse qb1BCOiNJ9RuHDyBQAV90nYMgYydJP9qFMB3E6cYj6Q/jqXBMkEPlmC7GfWyPq335z+tB2nEV4k = X-Received: by 2002:a17:902:db11:b0:1db:f03b:6f5b with SMTP id m17-20020a170902db1100b001dbf03b6f5bmr2992719plx.56.1708317575412; Sun, 18 Feb 2024 20:39:35 -0800 (PST) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id h4-20020a170902eec400b001d911dd145esm3425695plb.219.2024.02.18.20.39.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Feb 2024 20:39:34 -0800 (PST) From: Kees Cook To: Julia Lawall , Jacob Keller Cc: Kees Cook , "Gustavo A . R . Silva" , cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org Subject: Re: [PATCH] coccinelle: semantic patch to check for potential struct_size calls Date: Sun, 18 Feb 2024 20:38:37 -0800 Message-Id: <170831751501.1712410.1795028010127344315.b4-ty@chromium.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230227202428.3657443-1-jacob.e.keller@intel.com> References: <20230227202428.3657443-1-jacob.e.keller@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Mon, 27 Feb 2023 12:24:28 -0800, Jacob Keller wrote: > include/linux/overflow.h includes helper macros intended for calculating > sizes of allocations. These macros prevent accidental overflow by > saturating at SIZE_MAX. > > In general when calculating such sizes use of the macros is preferred. Add > a semantic patch which can detect code patterns which can be replaced by > struct_size. > > [...] If this needs tweaking, we can go from this one. Applied to for-next/hardening, thanks! [1/1] coccinelle: semantic patch to check for potential struct_size calls https://git.kernel.org/kees/c/39fc2f86ae6a Take care, -- Kees Cook