Received-SPF: pass (google.com: domain of linux-kernel+bounces-70717-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Vamsi Krishna Attunuru <vattunuru@marvell.com>
To: Greg KH <gregkh@linuxfoundation.org>
CC: "arnd@arndb.de" <arnd@arndb.de>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [EXT] Re: [PATCH v2 1/1] misc: mrvl-cn10k-dpi: add Octeon CN10K
 dpi driver
Thread-Topic: [EXT] Re: [PATCH v2 1/1] misc: mrvl-cn10k-dpi: add Octeon CN10K
 dpi driver
Thread-Index: AQHaYMOArP5lpoMc+EmpN3Y/GmE2K7EOMPIAgALrHhA=
Date: Mon, 19 Feb 2024 05:03:38 +0000
Message-ID: 
 <MW4PR18MB52448A9E37DCDB04F84C2013A6512@MW4PR18MB5244.namprd18.prod.outlook.com>
References: 
 <MW4PR18MB5244844411A57790287068E5A64E2@MW4PR18MB5244.namprd18.prod.outlook.com>
 <20240216103225.1255684-1-vattunuru@marvell.com>
 <2024021713-corrode-landline-e186@gregkh>
In-Reply-To: <2024021713-corrode-landline-e186@gregkh>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?5rDBdkLWFHDsat0jgoc8FPbDFocDKV5+nMyCxlNGGRPNFtS4NCa50drP9XER?=
 =?us-ascii?Q?RKjupQ1rJoT/TvsSfKMbT10oRZ+I2zIV7kd8ydl4grNP1GZ0B/5+5MV2cl8b?=
 =?us-ascii?Q?Kd/glMvfHKbNDXe/InSm8us2VWOw47TmNmCnWZg0nrE9kkCPFQXmZkEZwpRl?=
 =?us-ascii?Q?ksbfqLrODO4enxi+0NA4vn7eYxxt4skCLEvQEXAlZMUtEE+u1YFG25jwpJ76?=
 =?us-ascii?Q?05/w0DMa6Dh5ntDBRCXvefupijt+x9vV5L0JLA0ykLJbV42HpdTKIKVwQx0D?=
 =?us-ascii?Q?ZwaexZPigTeKGl+5fJ71pXsrTvLn1dDt8r08YANLnlXfwb0LPK6sU07BxdXq?=
 =?us-ascii?Q?DqHR3ZySggPeiBk37us85THGll6DtfMtznQfsEdbcOzKDnWgdmuUIm1hz6gl?=
 =?us-ascii?Q?G8oX3pxQRo+9lcUy6TpSIoWHX05Te5urW0OIkg+akTQ2Rw31imlUqIOZjHIL?=
 =?us-ascii?Q?bPJubRibjqHd66pN/sURcbqMw/1KN8JNYCrDLJF/nfFiYt4lHek0tFam4Ynt?=
 =?us-ascii?Q?PZMdmiIZ9IcPMxuyDkL2TnzNDfbvb03Xg3y7YYPGKGQC3bZSz+6IYcoiNorv?=
 =?us-ascii?Q?wzGe63KNbXjE923Kb5Zf5aZSjHEuHaW/Bc0K3GG+FTfjmG3M90hScVJD4Yg3?=
 =?us-ascii?Q?RZApC7FW+RaqzAWdBMGtqa3gqSzqdcJWkVtwXP4mW80i+f8i8qd/X1VCoQsA?=
 =?us-ascii?Q?da5SWizehnTI2iuum+kK22hXMOVVUFWB2v29/XqlqCr47UT45SOnAncU2vZD?=
 =?us-ascii?Q?qv4eUGGzih8EH89kYTnbMIj1kGe+fAzGIlL/GHq3wwTlIM7tEaXMk5wmll/4?=
 =?us-ascii?Q?hLVA7wMoirQGJwxE0S0C1RcLKElLZbi+gln6sBE2Z1KDcmevWlZWJf/o2TSo?=
 =?us-ascii?Q?nYHu5akS414K4ns9rGWp6b8/+pzWSDn0bncI3hI+BaXTMezy6fDtVpzZi4qy?=
 =?us-ascii?Q?+NnsHG12R4iaK49K0FZWqw97s5Un16xIWHgSRV1BWZAEXJmGTAWnTBJQiSyw?=
 =?us-ascii?Q?3wzXrAanOzwtrIPFVIG/ReumapJnyTlh6ygMfK8fJPQ77vE0CqFxE2QFGxVG?=
 =?us-ascii?Q?u+W6QHFQb56BJdyek7Uy2seNp3LmPdMNZSsFxgR38UgFWS36zZy4tN1fvOJn?=
 =?us-ascii?Q?SeIgLJTC/DzwpEUu0vM5pOUQ9CXxZeM/0oVHY2Ws/nY21Hdo6at2ofkYiAGH?=
 =?us-ascii?Q?m9kyg4I21aWWdHuI9cx1uAgIea2Qx98n2so04U9oo2Hb03DG0qPfUcBBLlYg?=
 =?us-ascii?Q?TLknTBd5kYuu6HruP73l5vD2QzLvW5ciWKAtaASiymdQtLP8c8g3yYFQlgLe?=
 =?us-ascii?Q?S0tvZcLZiuiKwxajwsdxDqvhJ1GrV8HBDb05xizV2G0HuzeX5ADQYifg4Ve2?=
 =?us-ascii?Q?TAmz8KJVDChM7maVBU/qgGe5eJmulWMjU2NMD7FIwBZYR7sLJwDh5/mi/YD8?=
 =?us-ascii?Q?0JohAEuSOiJbY4NL005p+fh4pZc3BqD28IO4MVHaitrL3Waf3YnTMN26q5n8?=
 =?us-ascii?Q?jTkuawWluE2nkuYqJfUoz0wNksKGWd4ig7/tD3Zr74NDHAXxWsijwYJ8VaIk?=
 =?us-ascii?Q?kDHU6pCY2Izew/LgfIrdk4hT4XYY0Pum1LrUGdGQ0gfSCHdaSTOVs+xH76QU?=
 =?us-ascii?Q?Q+6AVMPMhzRT8z771kCYxghNOeVDE6b8Mcd6gknyrB6l?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW4PR18MB5244.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a1e4315e-b22c-492d-ea7c-08dc31082250
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Feb 2024 05:03:38.4653
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: T43NTXnRzz5Omt+udHk5Eez63B2nvrnpxcuUfkAQU/XpMp8yTORfqqTlLaQyRLrIElf9yNIhSxz5QR22hCMHmA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR18MB3882
X-Proofpoint-GUID: dvSldjwwFlVV6s2giMIACeBS26G7bTF1
X-Proofpoint-ORIG-GUID: dvSldjwwFlVV6s2giMIACeBS26G7bTF1
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-19_02,2024-02-16_01,2023-05-22_02


> -----Original Message-----
> From: Greg KH <gregkh@linuxfoundation.org>
> Sent: Saturday, February 17, 2024 1:44 PM
> To: Vamsi Krishna Attunuru <vattunuru@marvell.com>
> Cc: arnd@arndb.de; linux-kernel@vger.kernel.org
> Subject: [EXT] Re: [PATCH v2 1/1] misc: mrvl-cn10k-dpi: add Octeon CN10K
> dpi driver
>=20
> External Email
>=20
> ----------------------------------------------------------------------
> On Fri, Feb 16, 2024 at 02:32:25AM -0800, Vamsi Attunuru wrote:
> > Adds a driver for Marvell CN10K DPI(DMA Engine) device's physical
> > function which initializes DPI DMA hardware's global configuration and
> > enables hardware mailbox channels between physical function (PF) and
> > it's virtual functions (VF). VF device drivers (User space drivers)
> > use this hw mailbox to communicate any required device configuration
> > on it's respective VF device. Accordingly, this DPI PF driver provision=
 the VF
> device resources.
> >
> > At the hardware level, the DPI physical function (PF) acts as a
> > management interface to setup the VF device resources, VF devices are
> > only provisioned to handle or control the actual DMA Engine's data tran=
sfer
> capabilities.
> >
> > Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
> > ---
> >
> > Changes V1 -> V2:
> > - Fixed return values and busy-wait loops
> > - Merged .h file into .c file
> > - Fixed directory structure
> > - Removed module params
> > - Registered the device as misc device
>=20
> Why register as a misc device if you don't actually use it at all?  That =
feels
> pointless and extra code and confusion for everyone as you have created a
> device node in the system that will just fail all operations made on it.
>=20
> confused,
>=20

Module params are removed in V2, planning to use device node to pass the de=
vice configuration tuning parameters and other ops, can you please also sha=
re other v2 review comments, I will plan to address it in V3.

> greg k-h