Received-SPF: pass (google.com: domain of linux-kernel+bounces-70731-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <413e23b5-2b81-4278-907c-a5b9f6992e6a@quicinc.com>
Date: Mon, 19 Feb 2024 10:46:58 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3] arm64: dts: qcom: sc7280: add slimbus DT node
To: Bjorn Andersson <andersson@kernel.org>
CC: <konrad.dybcio@linaro.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
        <linux-arm-sm@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <quic_msavaliy@quicinc.com>,
        <quic_vtanuku@quicinc.com>, <quic_cchiluve@quicinc.com>,
        <quic_anupkulk@quicinc.com>
References: <20240215090910.30021-1-quic_vdadhani@quicinc.com>
 <wkbz5ska66c4kil67k4csqzm3anusskza7ysisaupfaqak3x77@wb3pqlngyzcd>
Content-Language: en-US
From: Viken Dadhaniya <quic_vdadhani@quicinc.com>
In-Reply-To: <wkbz5ska66c4kil67k4csqzm3anusskza7ysisaupfaqak3x77@wb3pqlngyzcd>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 2/17/2024 4:49 AM, Bjorn Andersson wrote:
> On Thu, Feb 15, 2024 at 02:39:10PM +0530, Viken Dadhaniya wrote:
> 
> You've misspelled "linux-arm-msm" in the mailing list address, so this
> was not in my review queue. Please switch to using b4 for preparing and
> sending future patches, to avoid such mistakes.

Corrected mailing list address and submitted V4.

> 
> Regards,
> Bjorn
> 
>> Populate the DTSI node for slimbus instance to be
>> used by bluetooth FM audio case.
>>
>> Signed-off-by: Viken Dadhaniya <quic_vdadhani@quicinc.com>
>> ---
>> v2 -> v3:
>> - Fix patch title by adding "PATCH" string.
>> - Update commit log.
>>
>> v1 -> v2:
>> - change 0x0 -> 0 to reg property.
>> - reorder the DT property.
>> - change node tag slim_msm to slim.
>> ---
>> ---
>>   arch/arm64/boot/dts/qcom/sc7280.dtsi | 25 +++++++++++++++++++++++++
>>   1 file changed, 25 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> index 581818676a4c..1d6afde915aa 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> @@ -2672,6 +2672,31 @@
>>   			status = "disabled";
>>   		};
>>   
>> +		slimbam: dma-controller@3a84000 {
>> +			compatible = "qcom,bam-v1.7.0";
>> +			reg = <0 0x03a84000 0 0x20000>;
>> +			interrupts = <GIC_SPI 164 IRQ_TYPE_LEVEL_HIGH>;
>> +			#dma-cells = <1>;
>> +			qcom,controlled-remotely;
>> +			num-channels  = <31>;
>> +			qcom,ee = <1>;
>> +			qcom,num-ees = <2>;
>> +			iommus = <&apps_smmu 0x1826 0x0>;
>> +			status = "disabled";
>> +		};
>> +
>> +		slim: slim-ngd@3ac0000 {
>> +			compatible = "qcom,slim-ngd-v1.5.0";
>> +			reg = <0 0x03ac0000 0 0x2c000>;
>> +			interrupts = <GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>;
>> +			dmas = <&slimbam 3>, <&slimbam 4>;
>> +			dma-names = "rx", "tx";
>> +			iommus = <&apps_smmu 0x1826 0x0>;
>> +			#address-cells = <1>;
>> +			#size-cells = <0>;
>> +			status = "disabled";
>> +		};
>> +
>>   		lpass_hm: clock-controller@3c00000 {
>>   			compatible = "qcom,sc7280-lpasshm";
>>   			reg = <0 0x03c00000 0 0x28>;
>> -- 
>> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
>> of Code Aurora Forum, hosted by The Linux Foundation
>>