Received-SPF: pass (google.com: domain of linux-kernel+bounces-70740-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <ZdDUlGdqH7Qv3SDu@standask-GA-A55M-S2HP>
In-Reply-To: <ZdDUlGdqH7Qv3SDu@standask-GA-A55M-S2HP>
From: Chunyan Zhang <zhang.lyra@gmail.com>
Date: Mon, 19 Feb 2024 13:40:52 +0800
Message-ID: <CAAfSe-sTARE6pr3g-vQ2MuaSLhWg8_bNhMcfosYjFxrAikwHHg@mail.gmail.com>
Subject: Re: [PATCH] dt-bindings: watchdog: sprd,sp9860-wdt: convert to YAML
To: Stanislav Jakubek <stano.jakubek@gmail.com>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>, Guenter Roeck <linux@roeck-us.net>, 
	Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, 
	Conor Dooley <conor+dt@kernel.org>, Orson Zhai <orsonzhai@gmail.com>, 
	Baolin Wang <baolin.wang7@gmail.com>, Baolin Wang <baolin.wang@linux.alibaba.com>, 
	linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"

On Sat, 17 Feb 2024 at 23:45, Stanislav Jakubek <stano.jakubek@gmail.com> wrote:
>
> Convert Spreadtrum SP9860 watchdog timer bindings to DT schema.
> Adjust file name to match compatible.
>
> Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com>

Thanks for the patch.

Acked-by: Chunyan Zhang <zhang.lyra@gmail.com>

> ---
>  .../bindings/watchdog/sprd,sp9860-wdt.yaml    | 64 +++++++++++++++++++
>  .../devicetree/bindings/watchdog/sprd-wdt.txt | 19 ------
>  2 files changed, 64 insertions(+), 19 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/watchdog/sprd,sp9860-wdt.yaml
>  delete mode 100644 Documentation/devicetree/bindings/watchdog/sprd-wdt.txt
>
> diff --git a/Documentation/devicetree/bindings/watchdog/sprd,sp9860-wdt.yaml b/Documentation/devicetree/bindings/watchdog/sprd,sp9860-wdt.yaml
> new file mode 100644
> index 000000000000..730d9a3a3cc5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/sprd,sp9860-wdt.yaml
> @@ -0,0 +1,64 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/watchdog/sprd,sp9860-wdt.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Spreadtrum SP9860 watchdog timer
> +
> +maintainers:
> +  - Orson Zhai <orsonzhai@gmail.com>
> +  - Baolin Wang <baolin.wang7@gmail.com>
> +  - Chunyan Zhang <zhang.lyra@gmail.com>
> +
> +allOf:
> +  - $ref: watchdog.yaml#
> +
> +properties:
> +  compatible:
> +    const: sprd,sp9860-wdt
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 2
> +
> +  clock-names:
> +    items:
> +      - const: enable
> +      - const: rtc_enable
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clocks
> +  - clock-names
> +  - timeout-sec
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/sprd,sc9860-clk.h>
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    soc {
> +        #address-cells = <2>;
> +        #size-cells = <2>;
> +
> +        watchdog@40310000 {
> +            compatible = "sprd,sp9860-wdt";
> +            reg = <0 0x40310000 0 0x1000>;
> +            interrupts = <GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>;
> +            clocks = <&aon_gate CLK_APCPU_WDG_EB>, <&aon_gate CLK_AP_WDG_RTC_EB>;
> +            clock-names = "enable", "rtc_enable";
> +            timeout-sec = <12>;
> +        };
> +    };
> +...
> diff --git a/Documentation/devicetree/bindings/watchdog/sprd-wdt.txt b/Documentation/devicetree/bindings/watchdog/sprd-wdt.txt
> deleted file mode 100644
> index aeaf3e0caf47..000000000000
> --- a/Documentation/devicetree/bindings/watchdog/sprd-wdt.txt
> +++ /dev/null
> @@ -1,19 +0,0 @@
> -Spreadtrum SoCs Watchdog timer
> -
> -Required properties:
> -- compatible : Should be "sprd,sp9860-wdt".
> -- reg : Specifies base physical address and size of the registers.
> -- interrupts : Exactly one interrupt specifier.
> -- timeout-sec : Contain the default watchdog timeout in seconds.
> -- clock-names : Contain the input clock names.
> -- clocks : Phandles to input clocks.
> -
> -Example:
> -       watchdog: watchdog@40310000 {
> -               compatible = "sprd,sp9860-wdt";
> -               reg = <0 0x40310000 0 0x1000>;
> -               interrupts = <GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>;
> -               timeout-sec = <12>;
> -               clock-names = "enable", "rtc_enable";
> -               clocks = <&clk_aon_apb_gates1 8>, <&clk_aon_apb_rtc_gates 9>;
> -       };
> --
> 2.34.1
>