Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp966491rdb; Sun, 18 Feb 2024 22:35:42 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUw2Pej+jDtluyPGXGXZ8VAUjmlDhyyAYL2+L7BZyN40x+/xghKUzu4uNMFZJpyIFRyk8leY8kK92+h5ubME6inAXeSP1r/qJ4ULgWohg== X-Google-Smtp-Source: AGHT+IHgrkrfbaE5xPSmDDjqy0SGnYnnN/Zj9TK0N7j6qCuBM0/ccE8D4ide919zg7lE5JKkCUkr X-Received: by 2002:a05:620a:2496:b0:787:6fa6:7c9d with SMTP id i22-20020a05620a249600b007876fa67c9dmr211231qkn.29.1708324542141; Sun, 18 Feb 2024 22:35:42 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708324542; cv=pass; d=google.com; s=arc-20160816; b=kPDgIIAhrSugR9guD6yY5i1mBlQHXC/ju3qYRkqamuH90CmODkYXDLABTzQz7iZ6mG 6Ld2mzoJKgJZGXO92f4LoJDtxfmi3bg3w+uLqeYh5x9AZXN9NFv07YcjbEX85F+BOpPq 1s8D8EcuXyJ58bJ3huhY7uoYQBOJtzEJUhtpSACrg42nUkqFPgSiuF3Es+4UilZhh2bU CRFnFM8fpr3m0a2JZkTzYgXOVhool47bqsLEssEjaNTKf7EWRV7dBKjaz81EgA25LIGD 2xU3koUZoRbO8jPLRDgipPmKdn86fRitjh/12cX7QBhca3qQdkPqPlCJz1l6/8y8VOrj 9sNw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date; bh=zhw5EoxdG998oNOn9nNA1GsopziKNyNewDBX98w7SXE=; fh=Pt/vLgYoachKTmrGCk8iX6cxHu3EQKHMuGxf+QrSHvI=; b=iFz4kGiClsnfIdnDAeJik417UVSdDlcu1t+Uz5MlHjsWkPYZrWEUQ8GXzl9cwGYZvN dxdD10cscdZ3YeKjaC/uasVn7F+ZSITVVnL5d7NHptxZth6EfBXXM3TRxxifaSe8+zx3 pRWPNX4CMPep/FNNk8sS1bktJWuGyoTBZyQtes+ZntfiwObcggEq2sLy11LwFBmVpmAP qznNzEYOYA8gBE4+4pK4JhbR81tBLbWBjXem7vJhCNpr54+SRPFPa2oFRsyW1INFIIkU C3ZhXfwQfTZX1JKsoBX2jkWs0HhOaC98tilqQSh9ESaE16OJ/zqNMNaeMIpPuVhn9o5h f2Ag==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=lst.de); spf=pass (google.com: domain of linux-kernel+bounces-70777-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-70777-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id k5-20020a05620a0b8500b007876995029dsi1394112qkh.685.2024.02.18.22.35.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Feb 2024 22:35:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-70777-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=lst.de); spf=pass (google.com: domain of linux-kernel+bounces-70777-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-70777-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id E011D1C20E16 for ; Mon, 19 Feb 2024 06:35:41 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 70D6D20303; Mon, 19 Feb 2024 06:35:34 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73A8F1E48A for ; Mon, 19 Feb 2024 06:35:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708324534; cv=none; b=RJH7OYL5DyIiZXJgjAVqz4ggK2tHH17rem0kEVV0ifu0vj9cuJMHbWDiqg/MSszjuba2xLgyKh9YvAPBKssmOd1jg6Ox6QBDKzVPqvOqhMZnjghW/NcekEIU9EjvQ+TKvRI7DOgxLCu/FtJ3HwNYcSVl3mM3TORuj41i1aAmXoc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708324534; c=relaxed/simple; bh=uEXLqa25VC0NldNYu9Ew/bpWyKhDFlg+0FNj4WPr+ZI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QbafmHXbqcv6oxMhM1hg+hwI2chE5+FOfcMCfaGLPzZGOZ6l0XHz9Z3qRLA3Nlc+6+uBnNnbAjS/4nIlnN6GUBKAdyJ0kK6nE+5m8KbbC8agHMbNXfb+jaO+ocqyef09o5jdy044k8kWKfuxMBQ6vtRSwBgnBBXI/8+nAcnGJcw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 0E12268AFE; Mon, 19 Feb 2024 07:35:28 +0100 (CET) Date: Mon, 19 Feb 2024 07:35:27 +0100 From: Christoph Hellwig To: Will Deacon Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, iommu@lists.linux.dev, Christoph Hellwig , Marek Szyprowski , Robin Murphy , Petr Tesarik , Dexuan Cui Subject: Re: [PATCH v3 0/3] Fix double allocation in swiotlb_alloc() Message-ID: <20240219063527.GA4580@lst.de> References: <20240205190127.20685-1-will@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240205190127.20685-1-will@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) Robin and Petr, does this looks good to you now? On Mon, Feb 05, 2024 at 07:01:24PM +0000, Will Deacon wrote: > Hi all, > > This is version three of the patches I posted recently: > > v1: https://lore.kernel.org/r/20240126151956.10014-1-will@kernel.org > v2: https://lore.kernel.org/r/20240131122543.14791-1-will@kernel.org > > Thanks to Robin for the comments on the most recent version. > > Changes since v2 include: > > - Restore missing 'continue' statement that got accidentally dropped > while addressing the initial round of review feedback. > > - Reword the commit message in patch #1 > > - Add a Fixes: tag to the last patch > > Cheers, > > Will > > Cc: iommu@lists.linux.dev > Cc: Christoph Hellwig > Cc: Marek Szyprowski > Cc: Robin Murphy > Cc: Petr Tesarik > Cc: Dexuan Cui > > --->8 > > Will Deacon (3): > swiotlb: Fix double-allocation of slots due to broken alignment > handling > swiotlb: Enforce page alignment in swiotlb_alloc() > swiotlb: Honour dma_alloc_coherent() alignment in swiotlb_alloc() > > kernel/dma/swiotlb.c | 38 ++++++++++++++++++++++++-------------- > 1 file changed, 24 insertions(+), 14 deletions(-) > > -- > 2.43.0.594.gd9cf4e227d-goog ---end quoted text---