Received-SPF: pass (google.com: domain of linux-kernel+bounces-70791-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Received-SPF: Pass (protection.outlook.com: domain of topic.nl designates
 20.93.157.195 as permitted sender) receiver=protection.outlook.com;
 client-ip=20.93.157.195; helo=westeu11-emailsignatures-cloud.codetwo.com;
 pr=C
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=topic.nl;
Message-ID: <c386a274-fae3-42ea-a2ab-a1c194ca2449@topic.nl>
Date: Mon, 19 Feb 2024 07:56:49 +0100
User-Agent: Mozilla Thunderbird
From: Mike Looijmans <mike.looijmans@topic.nl>
Subject: Re: [PATCH v5 2/2] iio: adc: ti-ads1298: Add driver
To: Jonathan Cameron <jic23@kernel.org>
CC: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
 devicetree@vger.kernel.org, linux-iio@vger.kernel.org,
 Arnd Bergmann <arnd@kernel.org>, Lars-Peter Clausen <lars@metafoo.de>,
 Liam Beguin <liambeguin@gmail.com>, Liam Girdwood <lgirdwood@gmail.com>,
 Maksim Kiselev <bigunclemax@gmail.com>,
 Marcus Folkesson <marcus.folkesson@gmail.com>,
 Marius Cristea <marius.cristea@microchip.com>,
 Mark Brown <broonie@kernel.org>, Niklas Schnelle <schnelle@linux.ibm.com>,
 Okan Sahin <okan.sahin@analog.com>, linux-kernel@vger.kernel.org
References: <Zc-E3-MNe9dG9tdW@smile.fi.intel.com>
 <fb7d41fc-328a-4ce1-88ad-5ce22ee158e4@topic.nl>
 <20240216171921.5a6b6b20@jic23-huawei>
Content-Language: en-US, nl
Organization: Topic
In-Reply-To: <20240216171921.5a6b6b20@jic23-huawei>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0
X-Microsoft-Antispam-Message-Info-Original:
 bUU7U5tw7l6kQ0qvLshGZxgBsOFNvDt/yK49IXtBwg0RvVpQx8ZQ/+vJcLzo9Bv7V86CufwIv/FgZbgqsKwEig7hPlu61ewZB9FyOroBiFM8u8uBjx3xrmeG6alFF8ZHCPawSzNutAhEgXxPRwVDxRh5pA1js7uYXDx6R6neTds5QXb9uXNdFOkEkJTffGB3cr7zI1fKVR+N8saMZvkvMO0aYkLb+BqDywrf06UWaDjkt8TWVPnP+jxGN/oH1Ud+8Rjv0uY5dbNDtp0oNvxI2F4+3fGN7PMuq7cucNa8y6EACncYP/CRihMTIdatybUkzR4dKxqS6yyDGhKB1CQbxHNUAyCbMojaJhYP1AkEFdHect32Dq7FbFWxx9pQQUH4lfth+oehA2HYU4mg57LNR1Ub5mXEE33Xtuh8e7iiaVU9k02/U4q4AYziPY96dihR49Hp4mTVbAl4c+xBMtpEA3uFs0Qk6KJ7SBQrwxpyML5ANnaLgVdzvCwDcrBLAwAjbEmCbLxkZjWWo33wkX3lv1/FKbb9p3QpGw20kEFMKs9yiXkaKYbI69r8ylNsi8xbMzCZVlDL2Q1H4QTD0FbsCGS7w3MkMM5NmOkO9oQnwHc=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8644.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(376002)(136003)(366004)(39830400003)(396003)(230922051799003)(1800799012)(186009)(64100799003)(451199024)(31686004)(54906003)(316002)(5660300002)(7416002)(44832011)(2906002)(4326008)(6916009)(8676002)(8936002)(31696002)(86362001)(66946007)(41300700001)(66476007)(66556008)(6506007)(53546011)(52116002)(6486002)(478600001)(36916002)(6512007)(38350700005)(36756003)(2616005)(26005)(83380400001)(15974865002)(38100700002);DIR:OUT;SFP:1102;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7769
X-CodeTwo-MessageID: ac9f4b86-d101-4816-adb7-94b073a112ab.20240219065652@westeu11-emailsignatures-cloud.codetwo.com
X-CodeTwoProcessed: true
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AMS0EPF0000019D.eurprd05.prod.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	dee7e3e3-f022-449c-1d6f-08dc3117f2b7
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	rkgPznuWSbfH1csF9iRdlCacaWaJuCoJFQ1byTZ+rFaFeRqFRw1j7ErRpe7Z8eDyAoTdqF6OZc+P8FNRm/05hnIHtEkQzKDkOiwu/Sf5eSfcDeLKnXXpeB4n3a7z3hLHv0unJLRT10jTZStAA1DB/brpz68tZ0w2pvLIyLNUutVYAv8DIyh7D+OQltvnajkR0TOJBxgTHUtAP2PL9UchPvnbKRjQWuN+uA5yuOk4ctZfdMyH2Timnb4YTwoZ4QIktDgRhEj9xhdSFpenvyebn7VWRm8jZ8Ldd0lXdvYyHtDKK1VcNzBgmxiKvfB+tDiACQhGRdB0VEyK8qvje6E4SvJqj5rYn8OWzldGKJ9ZikIbN2a1eBov6VcMjziKkGikzml9LeEjuisrH1RKs3MuU2jLs8lP+I1H16qmWRJikxeiUOsf30shKBPK5Nkk7tpX7mroQ61CeA+yUEzucynGKGr6J/Dj6m9LdP64dacDaqSQgSXLL/tJRUXl1+Q/umoN6N9lkyOoqCFmdt44UWRHjWOr4FkXL3dwJ8JBFCwyMXB2gjfKybsISYUHuYeQMkz/fry2SB/Sf6c9g4ebYgol5a+FYxrNys5e1BX+b79f+J6GreyZkem7w2ztfdE+gA0rKi2hPK9mKHubukAKoLMgfw==
X-Forefront-Antispam-Report:
	CIP:20.93.157.195;CTRY:NL;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:westeu11-emailsignatures-cloud.codetwo.com;PTR:westeu11-emailsignatures-cloud.codetwo.com;CAT:NONE;SFS:(13230031)(4636009)(396003)(346002)(39830400003)(136003)(376002)(230922051799003)(186009)(64100799003)(1800799012)(451199024)(36860700004)(82310400011)(46966006)(2906002)(6512007)(6506007)(6486002)(44832011)(15974865002)(36756003)(7416002)(26005)(70206006)(31696002)(70586007)(53546011)(54906003)(36916002)(336012)(478600001)(5660300002)(83380400001)(316002)(4326008)(8936002)(41300700001)(356005)(86362001)(7596003)(2616005)(8676002)(6916009)(7636003)(31686004);DIR:OUT;SFP:1102;
X-OriginatorOrg: topic.nl
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Feb 2024 06:56:53.4610
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 491e2fc3-1cd0-482c-e9b7-08dc3117f474
X-MS-Exchange-CrossTenant-Id: 449607a5-3517-482d-8d16-41dd868cbda3
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=449607a5-3517-482d-8d16-41dd868cbda3;Ip=[20.93.157.195];Helo=[westeu11-emailsignatures-cloud.codetwo.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AMS0EPF0000019D.eurprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8240

On 16-02-2024 18:19, Jonathan Cameron wrote:
> On Fri, 16 Feb 2024 17:07:49 +0100
> Mike Looijmans <mike.looijmans@topic.nl> wrote:
>
>> On 16-02-2024 16:53, Andy Shevchenko wrote:
>>
>> ...
>>
>> +       if (reset_gpio) {
>> +               /*
>> +                * Deassert reset now that clock and power are active.
>> +                * Minimum reset pulsewidth is 2 clock cycles.
>> +                */
>> +               udelay(ADS1298_CLOCKS_TO_USECS(2));
>>
>> This is sleeping context and you are calling unsleeping function. I have=
n't
>> checked the macro implementation and I have no idea what is the maximum =
it may
>> give, but making code robust just use fsleep() call.
>>
>> It'll actually delay for 1 us (the "clock" is ~2MHz). So fsleep will com=
pile to udelay anyway, which is fine, fsleep might get smarter in future an=
d this would then profit.
>>
>>
>>
>> +               gpiod_set_value_cansleep(reset_gpio, 0);
>> +       } else {
>> +               ret =3D ads1298_write_cmd(priv, ADS1298_CMD_RESET);
>> +               if (ret)
>> +                       return dev_err_probe(dev, ret, "RESET failed\n")=
;
>> +       }
>> +       /* Wait 18 clock cycles for reset command to complete */
>> +       udelay(ADS1298_CLOCKS_TO_USECS(18));
>>
>> Ditto.
>>
>> ...
>>
>>
>> If it's the only issue I think Jonathan can modify when applying
>> (no new patch version would be needed).
>>
>> That'd be nice.
> ok.  As this is still the top of my tree I'll just tweak it.
>
> Does anyone else read fsleep as femtosecond sleep every time? :)
> Maybe computers will go that fast one day.
>
> Jonathan

Noticed this triggered a kernel test robot report. Sent a v6 that fixes=20
the bug.

Can also make it a separate patch if you prefer, in that case ignore v6.


--=20
Mike Looijmans
System Expert

TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands

T: +31 (0) 499 33 69 69
E: mike.looijmans@topic.nl
W: www.topic.nl