Received-SPF: pass (google.com: domain of linux-kernel+bounces-70799-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Vamsi Krishna Attunuru <vattunuru@marvell.com>
To: Greg KH <gregkh@linuxfoundation.org>
CC: "arnd@arndb.de" <arnd@arndb.de>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [EXT] Re: [PATCH v2 1/1] misc: mrvl-cn10k-dpi: add Octeon CN10K
 dpi driver
Thread-Topic: [EXT] Re: [PATCH v2 1/1] misc: mrvl-cn10k-dpi: add Octeon CN10K
 dpi driver
Thread-Index: AQHaYMOArP5lpoMc+EmpN3Y/GmE2K7EOMPIAgALrHhCAABlcAIAADF/w
Date: Mon, 19 Feb 2024 07:03:51 +0000
Message-ID: 
 <MW4PR18MB52449D4CCC0994747D8A316EA6512@MW4PR18MB5244.namprd18.prod.outlook.com>
References: 
 <MW4PR18MB5244844411A57790287068E5A64E2@MW4PR18MB5244.namprd18.prod.outlook.com>
 <20240216103225.1255684-1-vattunuru@marvell.com>
 <2024021713-corrode-landline-e186@gregkh>
 <MW4PR18MB52448A9E37DCDB04F84C2013A6512@MW4PR18MB5244.namprd18.prod.outlook.com>
 <2024021913-aftermost-footnote-cd6e@gregkh>
In-Reply-To: <2024021913-aftermost-footnote-cd6e@gregkh>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?baj+hVAF9fU/5itpfD9LRLPiZPr6bJHQ2LwexOdpfz7yY+/r6sg1wXtZ+2k1?=
 =?us-ascii?Q?r2yHBmABXs51WyoAPgWPI+SzAU1niyUbF3w5rX8gSF7Fsg/sPTM2NEMOKtN4?=
 =?us-ascii?Q?JBLG5ojV8NgiofV6MnRarjCmvcrFfP+BolC0scIGccCdT0Mxrj52uilD1/X9?=
 =?us-ascii?Q?YS1TFvS80Whzt/tPWrnbZU8RuxE5XHs5pzMLxRZCtuCJ3vtWk54U+hL/44uh?=
 =?us-ascii?Q?03bRgBSlN52N2sWopWqGjGgGYspZiWOvuJ7Ia6J9YhsGW7ET6CVyt+isXJCj?=
 =?us-ascii?Q?OKT8UawNv0FA+8GE2YpwUlm/1Sob5wnJFPYXsxIYZv6JHWwVgwpy7mbNFzyO?=
 =?us-ascii?Q?aex6rl+KCJfISgGsWn7z6g6gZJ6Vvzcrd/Vk+QlkMPgDmeQBwjhji9eCulDf?=
 =?us-ascii?Q?WEq60h7+LakYcTKjjyrxW3Xw+Z+NPiViOl750/sG2pfXtgT0zZOAHHCgdwSP?=
 =?us-ascii?Q?Sh6JxmcpnU6rSmXbRwiOAgqXIpdPv1B98HblUivVflOrdV9SxSv1rb7S91dc?=
 =?us-ascii?Q?gr0Mswhgs79UjBh114MUCSEHDzETFrMQ0UIL4ppEiA0r1kdK3ONSKK+8vX/p?=
 =?us-ascii?Q?BC5FBav2RZRc3mNyfSc8srQtuS7Wz+JETAAdJRhjCy9eDvFSP5ER2ilHYSmH?=
 =?us-ascii?Q?DiVzDEEtf18ub/HtTKglmVZX9qrX5IWprh8c/k5Vqh5siXMccZ7BDhpSJkC9?=
 =?us-ascii?Q?lqf80ygSRc/WGT5IN3jrNrNz+W+5KnvVK2RsOEBcSQ+D3gRDR7wBRTClSN3/?=
 =?us-ascii?Q?aU7QLcFWI9eMvyAOg0wzOnunYGm2x26kZrtZk2DrivV1LWv7cAITHaXtqV0A?=
 =?us-ascii?Q?Zur/aQfUSqOYj+fyZn6zH+B2tvSaP8z37j+SannclTzOUK0gBGhb5UQO8Use?=
 =?us-ascii?Q?r1630cKE7XEWlx7f3dgMjDA/a3QyARrWuljTI0bVVUHHhr29OTzpwCpnr9S+?=
 =?us-ascii?Q?RxvduFU1Mlmwr8fi+aC+J6z6F9e3wVXIjY7O/EAEidZN0ZOuGy7aTrb8AEOA?=
 =?us-ascii?Q?WI7xganqWGTmGv+q+GwGNipD2NBF/N+U7lExPfR8ovCSEamtQICJkv0UC3w1?=
 =?us-ascii?Q?cKl8yRvj4kG2WSNwpGmstmlHF2OGQ+z0oRqRQBNJld+BQ9shp18f3A7xPR8f?=
 =?us-ascii?Q?CHl6nF08Lu01gtjcYmKs9rlnNnaXX1yFVw/LWrOH+DVnM8kMdEzLw3qzh8sm?=
 =?us-ascii?Q?IOKv+bkQsHJXqyRI0DEMi5/ufZh4iUG8XHqRMzp50lghOuga5tOOq7Kl/cat?=
 =?us-ascii?Q?6/6NEXJIgUBx+YgpXr84KxOywJ/TIe9CGYI86FFkjie7g/eM9Si7Ve7kYbtU?=
 =?us-ascii?Q?C5UIgXdvCiqG4J91+vJZiKymU5caiVQMbILmInSIobIhjCwAoJ5o3YxGU9p+?=
 =?us-ascii?Q?Y2RwcPbzJBAgTHMQ3G0O55KLWrRKUSD1pS6FmV11ICzNM4QMt1Jywp7Gp8be?=
 =?us-ascii?Q?eQ7y3DRsNSjYGiPd/ksu292/b6OrZxVf9A1S0GkyNKXov+Uvd1AOeaPqtcz1?=
 =?us-ascii?Q?f1hN51gST5Y0HvBXBZTGxP83SzrQnFNVd8bzga8yafEeGcSj6+aQMrVkFWaH?=
 =?us-ascii?Q?c+It4Feys5GrybjjrKZaLeQOl58xm7iTA1aKrX9irAKd7ECRNxOVHe6POTe8?=
 =?us-ascii?Q?Y5WLNGoAXNwBmp7wsK++sfcsQkZTvOXVaDaxZPhh9tIk?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW4PR18MB5244.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3b68d1d6-a535-493e-326e-08dc3118ed81
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Feb 2024 07:03:51.3133
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: JCn4tIvGCts0BhG2W1NaMZgGmaISgNDERg5K368dGilmeeahyIHXrDVKzRkBrtW+PO/LDI4hzTIDtkOnKlrv7g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR18MB5561
X-Proofpoint-GUID: AwMnCRv-VD59uIhtil-8M6V869XEhvs-
X-Proofpoint-ORIG-GUID: AwMnCRv-VD59uIhtil-8M6V869XEhvs-
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-19_04,2024-02-16_01,2023-05-22_02


> -----Original Message-----
> From: Greg KH <gregkh@linuxfoundation.org>
> Sent: Monday, February 19, 2024 11:49 AM
> To: Vamsi Krishna Attunuru <vattunuru@marvell.com>
> Cc: arnd@arndb.de; linux-kernel@vger.kernel.org
> Subject: Re: [EXT] Re: [PATCH v2 1/1] misc: mrvl-cn10k-dpi: add Octeon
> CN10K dpi driver
>=20
> On Mon, Feb 19, 2024 at 05:03:38AM +0000, Vamsi Krishna Attunuru wrote:
> > > -----Original Message-----
> > > From: Greg KH <gregkh@linuxfoundation.org>
> > > Sent: Saturday, February 17, 2024 1:44 PM
> > > To: Vamsi Krishna Attunuru <vattunuru@marvell.com>
> > > Cc: arnd@arndb.de; linux-kernel@vger.kernel.org
> > > Subject: [EXT] Re: [PATCH v2 1/1] misc: mrvl-cn10k-dpi: add Octeon
> > > CN10K dpi driver
>=20
> Why is this here?
>=20
> > > External Email
> > >
> > > --------------------------------------------------------------------
> > > -- On Fri, Feb 16, 2024 at 02:32:25AM -0800, Vamsi Attunuru wrote:
> > > > Adds a driver for Marvell CN10K DPI(DMA Engine) device's physical
> > > > function which initializes DPI DMA hardware's global configuration
> > > > and enables hardware mailbox channels between physical function
> > > > (PF) and it's virtual functions (VF). VF device drivers (User
> > > > space drivers) use this hw mailbox to communicate any required
> > > > device configuration on it's respective VF device. Accordingly,
> > > > this DPI PF driver provision the VF
> > > device resources.
> > > >
> > > > At the hardware level, the DPI physical function (PF) acts as a
> > > > management interface to setup the VF device resources, VF devices
> > > > are only provisioned to handle or control the actual DMA Engine's
> > > > data transfer
> > > capabilities.
> > > >
> > > > Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
> > > > ---
> > > >
> > > > Changes V1 -> V2:
> > > > - Fixed return values and busy-wait loops
> > > > - Merged .h file into .c file
> > > > - Fixed directory structure
> > > > - Removed module params
> > > > - Registered the device as misc device
> > >
> > > Why register as a misc device if you don't actually use it at all?
> > > That feels pointless and extra code and confusion for everyone as
> > > you have created a device node in the system that will just fail all
> operations made on it.
> > >
> > > confused,
> > >
> >
> > Module params are removed in V2, planning to use device node to pass th=
e
> device configuration tuning parameters and other ops, can you please also
> share other v2 review comments, I will plan to address it in V3.
>=20
> How is a reviewer supposed to know that you are going to use unused code
> sometime in the future when you do not say that here?
>=20
> What would you do if you had to review such code?  You would stop there
> and wait for it all to make sense.
>=20
> Please try to get some internal review next time before you send out your
> next version so that you don't waste other's time reviewing dead code lik=
e
> this.

Sure, sorry for the inconvenience.=20
>=20
> thanks,
>=20
> greg k-h