Received-SPF: pass (google.com: domain of linux-kernel+bounces-70806-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 19 Feb 2024 08:11:00 +0100
From: Thorsten Scherer <T.Scherer@eckelmann.de>
To: Raag Jadav <raag.jadav@intel.com>
Cc: u.kleine-koenig@pengutronix.de, jarkko.nikula@linux.intel.com, 
	mika.westerberg@linux.intel.com, andriy.shevchenko@linux.intel.com, lakshmi.sowjanya.d@intel.com, 
	linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/4] pwm: dwc: drop redundant error check
Message-ID: <m57yqdldszy3s44p5rdxd6kwii5tqzqa44aaevpe7bep2yyeuo@wls3ad3gcl7y>
References: <20240219033835.11369-1-raag.jadav@intel.com>
 <20240219033835.11369-3-raag.jadav@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240219033835.11369-3-raag.jadav@intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?fJmohRM+HEuhJ58/c/GoMHNgqV+Bqp1nNPfKx3bqet35zlJyW5DzhdVs8gGP?=
 =?us-ascii?Q?R4UpDcDH5Wkq37w3awHNegdlZHjwJx1hKJ3tuCxCnYelhtP8uN1FzrFN0PR3?=
 =?us-ascii?Q?U0E8tUroi8vkJ/x++Ku/zyTh682ErTa3orAMaA3zHaPE9rMy4YiTxkEmTwas?=
 =?us-ascii?Q?xSy4De53svJf8YG6TXPAi/2Cl45kXypnHXm8w5UpWOzjD/a/508i1hMw0uN6?=
 =?us-ascii?Q?AtfaV3121sy4BCaO1TLskZoVniLnPhDf+FHL3N9GDemtVF6QOQtTxLF99r2F?=
 =?us-ascii?Q?z4iU+L4da7IuWpj4bCUe+yfQuKZZSVYuxKn2vxwQWcxaG4NQZ6bKWqM5oLsh?=
 =?us-ascii?Q?Llx+9wpiY0ne1O3wTb6ydYRdXqcATYn7+94JpaKaG98kyk2f9RSarZVBucv+?=
 =?us-ascii?Q?KiouBYapwTdsX/2cr4pAIld/kT+be4oV/VH5bmaulprecnuiMcVzlaT0HswI?=
 =?us-ascii?Q?Ux4NmzlAPBYkDwVBCnEg+A8YUP33HcD+uTWLNZ8L7GCZWaGCHda1uYbNRNJT?=
 =?us-ascii?Q?+I6uqcGb0sy2KtUhGKnygRO7xDNMML3C2yrXamkAIzMMmPzD39ZB77UJuSLN?=
 =?us-ascii?Q?Ff++F6N9H6Sk44LsMDTU7voER6nV22r/4bRrSguSH3F0/5ZMGzwWZYlJQnbv?=
 =?us-ascii?Q?QYRzB6Uaee9ze2mRosHEQy7z2X4/ar+0ZFmPIG5Y6mfFxdcpgqBr7BnhFRDV?=
 =?us-ascii?Q?45m9xvBp4grhmNcGW3exRPxupLj8skkhAMQTCrUEOeHRGv2gpHhIWyPgweOM?=
 =?us-ascii?Q?YaQKC5iTyPEF4+Usm/xu0hB5LKvPzxhqpCdnBaWQoxDAcYQYCYKK9VQFxS9C?=
 =?us-ascii?Q?6INww/6y61hJqLafPOczZPwfvBneMElFJGE7BdNM7suu5ejh38pLT6oF1wEn?=
 =?us-ascii?Q?nVN+n2js3uWB8MAT6j8vybVbOb2/sZIppeXehQe4HrICbDpZh14p3vcThm9f?=
 =?us-ascii?Q?AsOh6LpqztvZ5yaDEbdtDXigYFNyQX58Mx/WtIaDB8FL/1s2VCxlDYzc8UVQ?=
 =?us-ascii?Q?mxH5TISFcEE82060rrFNNLn4x9JwMrdQDvqDEH1mbligJUfINylKtNQvEdgJ?=
 =?us-ascii?Q?8JJN5uofopuEJSxsjafoUsJCFqyjKewIVC6vsUdQBuv2NWYHAwv6vy++r97w?=
 =?us-ascii?Q?tY+x76Tw7TMXBwb2gziq3Om67BvDoMV9E/qJzeGHsAeIy3+ZoWa3aTXWmujl?=
 =?us-ascii?Q?kBZMmYtvioOydpTf9KpgtvBDFjdA082/ET/foihk3nCU4HhfTF+WeDao2Iuv?=
 =?us-ascii?Q?IJdVHbmDfoh2AriBPkRAgupyjuEgtxMTmeUc58Qd3RqjEFH361zTeYIzQKOT?=
 =?us-ascii?Q?esNR06EjSSnWBx83QHgS5E15zBLZHRF+WHgsvo9hrBWPmA63TTsShhHO5fJP?=
 =?us-ascii?Q?qyD+mqUA/HM7Ah2g0jiK0YZwXLMmhsSzzxiX4+euS/lv3rbeYfvckF0qcZEE?=
 =?us-ascii?Q?0eCsyXfdcF1DjgGRewnA10EMpeInTqy6CC0fnRrYPef9Zkc+pyiYq310bZto?=
 =?us-ascii?Q?LxIQGhXD5W9iWNGvBXc5JbAADeYM0WJiHcB0QUeMt9TOMzGYnEl8C4o5vK6P?=
 =?us-ascii?Q?WarUvTL5Ky2KChVxo1x/NEEjVnVaFig0Q0urYkTok5MFhK/wfSH5BfVk+49I?=
 =?us-ascii?Q?lfdwY54j1+Yh9EW87RCt0xcKyLcrYUmulHjGRCOCW1vagyvnQyInn/dmZXPX?=
 =?us-ascii?Q?Y6vZ3w=3D=3D?=
X-OriginatorOrg: eckelmann.de
X-MS-Exchange-CrossTenant-Network-Message-Id: acd817f3-6742-4813-a63b-08dc3119ed95
X-MS-Exchange-CrossTenant-AuthSource: FR4P281MB3510.DEUP281.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Feb 2024 07:11:01.1215
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 62e24f58-823c-4d73-8ff2-db0a5f20156c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: owZn8EPZm+pGsYYyMrqx86nnJiJruGTJ0riEOesZGE+JWekrzPk7zbUzpQsDB8hW8qNV8erjFs04KQ4FS4Jkuw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: FR2P281MB1853

Hello,

On Mon, Feb 19, 2024 at 09:08:33AM +0530, Raag Jadav wrote:
> pcim_iomap_table() fails only if pcim_iomap_regions() fails. No need to
> check for failure if the latter is already successful.
> 
> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> Tested-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> ---
>  drivers/pwm/pwm-dwc.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/pwm/pwm-dwc.c b/drivers/pwm/pwm-dwc.c
> index c0e586688e57..7dbb72c80ef5 100644
> --- a/drivers/pwm/pwm-dwc.c
> +++ b/drivers/pwm/pwm-dwc.c
> @@ -51,11 +51,8 @@ static int dwc_pwm_probe(struct pci_dev *pci, const struct pci_device_id *id)
>  		return ret;
>  	}
>  
> +	/* No need to check for failure, pcim_iomap_regions() does it for us. */

IMHO this comment could be omitted.

>  	dwc->base = pcim_iomap_table(pci)[0];
> -	if (!dwc->base) {
> -		dev_err(dev, "Base address missing\n");
> -		return -ENOMEM;
> -	}
>  
>  	ret = devm_pwmchip_add(dev, chip);
>  	if (ret)
> -- 
> 2.35.3
> 
> 

Best regards
Thorsten