Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752876AbXL1T70 (ORCPT ); Fri, 28 Dec 2007 14:59:26 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751997AbXL1T7S (ORCPT ); Fri, 28 Dec 2007 14:59:18 -0500 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:36356 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751988AbXL1T7S (ORCPT ); Fri, 28 Dec 2007 14:59:18 -0500 Date: Fri, 28 Dec 2007 19:57:24 +0000 From: Russell King To: Adrian Bunk Cc: Mathieu Desnoyers , Randy Dunlap , phil.el@wanadoo.fr, oprofile-list@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [2.6.24 patch] restore ARMv6 OProfile support Message-ID: <20071228195724.GA22797@flint.arm.linux.org.uk> References: <20071228185636.GA4738@stusta.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071228185636.GA4738@stusta.de> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1807 Lines: 61 On Fri, Dec 28, 2007 at 08:56:36PM +0200, Adrian Bunk wrote: > This patch restores the ARMv6 OProfile support that was killed by > commit 09cadedbdc01f1a4bea1f427d4fb4642eaa19da9. > > Signed-off-by: Adrian Bunk Given where we are in the release cycle, I think this "cleanup" patch should be reverted. Once the issues with it are resolved (why was it never even CC'd to the arch maintainers for review?) then it can go into mainline. Note that it also looks like (from the commitdiff) that the above mentioned commit also removes: CONFIG_HARDWARE_PM (blackfin) CONFIG_OPROFILE_CELL (powerpc) So they're probably subtly broken as well. Linus, what do you think? Should 09cadedbdc01f1a4bea1f427d4fb4642eaa19da9 be reverted? > > --- > > kernel/Kconfig.instrumentation | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > 7fc221ef169610b5eac98e2ddd641811c0d53e4a > diff --git a/kernel/Kconfig.instrumentation b/kernel/Kconfig.instrumentation > index 468f47a..4453187 100644 > --- a/kernel/Kconfig.instrumentation > +++ b/kernel/Kconfig.instrumentation > @@ -29,2 +29,17 @@ config OPROFILE > > +config OPROFILE_ARMV6 > + bool > + depends on OPROFILE && ARM && CPU_V6 && !SMP > + default y > + select OPROFILE_ARM11_CORE > + > +config OPROFILE_MPCORE > + bool > + depends on OPROFILE && ARM && CPU_V6 && SMP > + default y > + select OPROFILE_ARM11_CORE > + > +config OPROFILE_ARM11_CORE > + bool > + > config KPROBES -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/