Received-SPF: pass (google.com: domain of linux-kernel+bounces-70903-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Mon, 19 Feb 2024 09:00:33 +0100
From: Thorsten Scherer <T.Scherer@eckelmann.de>
To: Raag Jadav <raag.jadav@intel.com>
Cc: u.kleine-koenig@pengutronix.de, jarkko.nikula@linux.intel.com, 
	mika.westerberg@linux.intel.com, andriy.shevchenko@linux.intel.com, lakshmi.sowjanya.d@intel.com, 
	linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/4] pwm: dwc: drop redundant error check
Message-ID: <arjrsej4vylprpevarvzufj5fp77hy7m4cotjubc7ufteegqxu@b5btt5aqjz65>
References: <20240219033835.11369-1-raag.jadav@intel.com>
 <20240219033835.11369-3-raag.jadav@intel.com>
 <m57yqdldszy3s44p5rdxd6kwii5tqzqa44aaevpe7bep2yyeuo@wls3ad3gcl7y>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <m57yqdldszy3s44p5rdxd6kwii5tqzqa44aaevpe7bep2yyeuo@wls3ad3gcl7y>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?vCJxgJA6LyAifvVZFjXuIpf2XIatoIPt2ge9emoPnPA1LxxrJ75Zfzwqh7kV?=
 =?us-ascii?Q?036AGLGmOFCVwrO0wy2jf7kBW4yQZYXz+oiYQWQdX5sRYw4G38lfBip4cL8Z?=
 =?us-ascii?Q?svsafA7CWn8aJu/c+jfiS/zZhU6qbz+kbhWbAxDOywbQuRl6zydxrCL1lBdO?=
 =?us-ascii?Q?CPW+udwYxIc+TbhWmqybJBfe9WZ3VT+HjF6m+7oHmFO3xIiLh9svw0+ceWPm?=
 =?us-ascii?Q?+mZ3OF34gALxp8ZREBK/NmYYLjpXjwR0Ht/o4a/2/stWRqzC7dCTwAZO/u+N?=
 =?us-ascii?Q?bW3AmBtDC9O6TocmfvWbyqy/YbDtvs7XXrJa/UOnhMX7ppNk76zB1gTrAOWU?=
 =?us-ascii?Q?Tb1axOL+279qiO0is86PHLSZHnOK6TyQQjqvRhPmMzTd+3vdNU2kMLGN11Hf?=
 =?us-ascii?Q?C6pToWjqCmSfZ/pnLD0PFs5SQ6dK3OLR8PczklQbCsIG9ifiIoCkDE9Hf7Ki?=
 =?us-ascii?Q?umfDAOLBp5BBPqq1WYo0ob7zHaIyhx6WkDF3bQyujoxJjeYDbqBtr7Opnl9o?=
 =?us-ascii?Q?h1et5wCtoWry3noS9bVwHE7j8twg/u5RPeMEsCKIWSRuGMXJqpotTkGcswI6?=
 =?us-ascii?Q?nJIhyV9NTfE4YgbJP2jfxO4hx0eJEU4TmELS3izz4O+t1bmN23/yy0AH7Vjo?=
 =?us-ascii?Q?uI7KPT5M64c+x4fLaloscqe/8ves2teKXQP2yMj4bbPfMF4yT9fdgADfTVP7?=
 =?us-ascii?Q?LRF3GNcJX6obR2TfxSMN+vY8nvgoF58Sd4vvSab1jIws0isLscVrRe2vbxAI?=
 =?us-ascii?Q?UYd43SNlCnBgVu4og6cwGir95hFS5azDJ5E1+aY77RMnT+W5CdMKUK1mVqM4?=
 =?us-ascii?Q?Rq9GANW1HmRg4rsQm6E5KWaSZdnmKAkrSrzOnBBPfz9RrhJTgfqD7u/TkWfW?=
 =?us-ascii?Q?k+1LYTzfBrPjZVbNzQE0V1+DQx2z0uxBNYoWhHz4qvSh83pR6W5NnfB7BDAP?=
 =?us-ascii?Q?8QOV77Uo/TVx7LU6oNj5voQHqxspg4rx21yJEftuaLcUfSpfJk0OR9sW2Rg4?=
 =?us-ascii?Q?Bjh4ZQEB+aEer70taZzqis03zqNzip3G8mJjUHBVclV5nfzEJ6fGa+wJNVLI?=
 =?us-ascii?Q?hm9rF/+agZSka6atLAwDWjMbfO4Jay7Tc3TfzTB8rXPyCuSstrCJzOX+uOZJ?=
 =?us-ascii?Q?oA/RzzOjhVKgjtDwRMWrdLYEz/u/uplrj4rpkg+eaLIqijkeDNOxQNcyKug6?=
 =?us-ascii?Q?OqlmJ+/j3NGJHUG2NUJTBCFyn70WbrKmGILRQU0DJI+tgMoSGGkTB23royC8?=
 =?us-ascii?Q?/v8Mrrzl0XJe+ojc1Cq2wDLUhLOYwzZn78NWWSbc6C/OuTp/zQELw1ZmQ3YX?=
 =?us-ascii?Q?TCeDkCg0fjFHcZ+KWcQ/p5CnQ3Tj36urj+T1OfoeyTJWz9+p5HkHK/o5Ww6Y?=
 =?us-ascii?Q?hppcFVfUmnf69cgPP5Rt78Ar+mb58Pb3qaMdDHT3CmmD9cy7DoaWKDlALVEw?=
 =?us-ascii?Q?eESLARVxKxeigH8R1JWy7om6C7MlypW0qIYW7RgSn2IEUEf3gATXBlT09MpW?=
 =?us-ascii?Q?YF+NsE4VD8hq4lYzL3UV28ZuzgN6/1cNBp4TYL/9Isg89SOf2/LdTrqfWN7B?=
 =?us-ascii?Q?2RZGHrq4Tr8WLovFH/BUgHI8ZblHaUiNatwKqJU4DIaMQ+G7CILSerS1122G?=
 =?us-ascii?Q?Lj8HFU21IdIvnnIRdGS0LkMieSAGxYdsX6GQNA055yrXTSS1OauIghUvOfFh?=
 =?us-ascii?Q?yoN7WA=3D=3D?=
X-OriginatorOrg: eckelmann.de
X-MS-Exchange-CrossTenant-Network-Message-Id: 9923abdf-7227-48cd-09ba-08dc3120d9cf
X-MS-Exchange-CrossTenant-AuthSource: FR4P281MB3510.DEUP281.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Feb 2024 08:00:34.5991
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 62e24f58-823c-4d73-8ff2-db0a5f20156c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sQt+9tcK9DZoC2ZHj9yY/xKD4sF/Z8xgXcuRArBO0Xw7ayTaILwQ+oe75K7R6BER3LArVnwNrtFFhSpdTIXsdA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: FR2P281MB2379

Hello,

On Mon, Feb 19, 2024 at 08:11:01AM +0100, Thorsten Scherer wrote:
> Hello,
> 
> On Mon, Feb 19, 2024 at 09:08:33AM +0530, Raag Jadav wrote:
> > pcim_iomap_table() fails only if pcim_iomap_regions() fails. No need to
> > check for failure if the latter is already successful.
> > 
> > Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> > Tested-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> > ---
> >  drivers/pwm/pwm-dwc.c | 5 +----
> >  1 file changed, 1 insertion(+), 4 deletions(-)
> > 
> > diff --git a/drivers/pwm/pwm-dwc.c b/drivers/pwm/pwm-dwc.c
> > index c0e586688e57..7dbb72c80ef5 100644
> > --- a/drivers/pwm/pwm-dwc.c
> > +++ b/drivers/pwm/pwm-dwc.c
> > @@ -51,11 +51,8 @@ static int dwc_pwm_probe(struct pci_dev *pci, const struct pci_device_id *id)
> >  		return ret;
> >  	}
> >  
> > +	/* No need to check for failure, pcim_iomap_regions() does it for us. */
> 
> IMHO this comment could be omitted.

I somehow overlooked the discussion in the v2.  Please ignore my
previous mail.

> >  	dwc->base = pcim_iomap_table(pci)[0];
> > -	if (!dwc->base) {
> > -		dev_err(dev, "Base address missing\n");
> > -		return -ENOMEM;
> > -	}
> >  
> >  	ret = devm_pwmchip_add(dev, chip);
> >  	if (ret)
> > -- 
> > 2.35.3
> > 
> > 
> 
> Best regards
> Thorsten

Best regards
Thorsten