Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp998140rdb; Mon, 19 Feb 2024 00:13:28 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWtt1tL+fkyKcjNMiC8znx7Vu2qP2UVGxL7sjV5PYG4jVkWJS9u6gmpy1BmhYYW+IdzXcR2f0WgrFjhU8rPQy4FAGRVWZaOJ1MmSLzQOg== X-Google-Smtp-Source: AGHT+IGFoJXp5h1O3nqx32USmeqzw3UcLwG8agnFmZ4OTkKowmhTMdSBPKJzDUpx1iUfngVxr0+z X-Received: by 2002:a17:902:ed15:b0:1db:ccd1:415d with SMTP id b21-20020a170902ed1500b001dbccd1415dmr5795454pld.44.1708330407851; Mon, 19 Feb 2024 00:13:27 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708330407; cv=pass; d=google.com; s=arc-20160816; b=jKqSN6nPtwQkHzoI+VkoBHhi1H7dYMUwYFCrjYCxsI7plyIABURxa+CMT/7i113Bog wwSrX+FETsoHYboWidWB1aGUgAu9MDKvaj6SbXI2xSHHzEbl/p1iX2vS7Leu/L05Rjkc U5OV8DjDQheRFb8AWK1217PxnrpPQwZZ4HcnbvLpxMT1nXiaO7mnIC+I3watqwRD1Uj+ 5L2XIqW7WNBBdC4ARC8NxlABebunN5jHEuuIinE1kxlbE+uoc7v0RU9q4Uo4+20XJQk0 1mwsy5BsRSeJJCRsFltKW568mh3kORd59KlbiHE5kS/QIkq33bkLLpjwMfmie1+aJX0j OGEg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:cc:to:from:dkim-signature; bh=Q0aCKU1ByxCw5C39SMUmqmAOatUcjigwqAYRZukWqI8=; fh=Bo7Evh0bjuCfHYv8kZucnQQ4z1eqgJLgefYKC3az4/8=; b=fjb1m1e/3RKwqnOhXjGVOFwrrJ0PxFIHuLMmhx5AsF/4AQU4uYGkOQ4lnPqGkoYpAa 69LFaC7DscKeUcCEDu4ThhILFfnMaDvolSJzu82XZoPerXhWvFq6w+DrPPGN1oUCHHcz b3UlGPIQgcsTdODMzySEtdlTcOvwN51Z3W9ZaGZW5YpG8giKBwJ4M3kqH40pf3NxA/i0 bK48X+XMHEtEwZZtPqAhJB3dSJuV0woB7+dMDWTt10nM0G33jW/Ge9dXfltVGuM4AZE5 4vnMtpdZoQj+sBPt2yLmcd6Vjx9wMdZp24ecq8EBfCiILBUJ/IOHK+5Ie8ksZo7KJzW/ D11Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gjrlE+Ss; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-70896-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-70896-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id y9-20020a17090264c900b001dbe5c1f2eesi2062886pli.223.2024.02.19.00.13.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 00:13:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-70896-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gjrlE+Ss; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-70896-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-70896-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id DB4C0B23886 for ; Mon, 19 Feb 2024 08:01:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 65B07219E9; Mon, 19 Feb 2024 07:51:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gjrlE+Ss" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8352121362; Mon, 19 Feb 2024 07:51:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708329070; cv=none; b=Sw5wQzA+D4pAxLx+hIHvkDHnxI9rInzOsprjiFNpa095TepBkz6h5NFife8Z5XpmCtikGBNO7MpWsTnccDsWylBUHV+L180gZS+cZhJOgQApoW8sHbvjcatyz31dIlSktjQtvJMbMe5TazQI26L6tit4PAMHSiIRVS1yrcor8pE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708329070; c=relaxed/simple; bh=fA+T8609KxuswGMZQTjV7L0OA2N8nSYotcC+2v27Kno=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=oLYJnstiJGhYUMgsd06DRv7E34ShM5Tr7vky79lA3R0UGymZ0CfI+B5p5jpS/6EnNDnnvjQbITlD7jgYXHiHr8A6Z6/DozKRFGQMm6rt0H/6JJtLu9q2yI8xeB3W6AbtUfVshH2A7DILwWmxzsxKdJsIAQufhGPz2B1wra7WIW0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gjrlE+Ss; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 990B4C433F1; Mon, 19 Feb 2024 07:51:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708329070; bh=fA+T8609KxuswGMZQTjV7L0OA2N8nSYotcC+2v27Kno=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=gjrlE+Ssx3BNKrZ8MMisPkU0bG9kzSaWcts+gbj6uRZx13oqpX+KMJZz0kEmx3F2D mAtTIb+N4mWlJg/9sPEyk/xzpub7xJ8pqMxje18y5IiSzIU0FfyyHMOdnWEL/M/E7A tZOn8Ds9I8bMU/Fj0ejQsR9LSaYNAE5fd9l32vCUU8dhh93mC/20Fb1QP221+VblA4 nGA4f+uZWort0Hu4VfAstLRlgmRVHWFwwNnV7yrX2QT7u2Tt5T3eiasL/6LFosMG9B Y+R/XOBjdCOn3m78zdutFk44XG4BW9NYjr3j4Dj3s8fcPwmVZXLYRkUcxKDC+QcCHW Kn+Zz96pOEjxA== From: Leon Romanovsky To: jgg@ziepe.ca, Junxian Huang Cc: linux-rdma@vger.kernel.org, linuxarm@huawei.com, linux-kernel@vger.kernel.org In-Reply-To: <20240219061805.668170-1-huangjunxian6@hisilicon.com> References: <20240219061805.668170-1-huangjunxian6@hisilicon.com> Subject: Re: [PATCH for-next] RDMA/hns: Fix mis-modifying default congestion control algorithm Message-Id: <170832906579.134605.15025302107615338247.b4-ty@kernel.org> Date: Mon, 19 Feb 2024 09:51:05 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.12-dev-a055d On Mon, 19 Feb 2024 14:18:05 +0800, Junxian Huang wrote: > Commit 27c5fd271d8b ("RDMA/hns: The UD mode can only be configured > with DCQCN") adds a check of congest control alorithm for UD. But > that patch causes a problem: hr_dev->caps.congest_type is global, > used by all QPs, so modifying this field to DCQCN for UD QPs causes > other QPs unable to use any other algorithm except DCQCN. > > Revert the modification in commit 27c5fd271d8b ("RDMA/hns: The UD > mode can only be configured with DCQCN"). Add a new field cong_type > to struct hns_roce_qp and configure DCQCN for UD QPs. > > [...] Applied, thanks! [1/1] RDMA/hns: Fix mis-modifying default congestion control algorithm https://git.kernel.org/rdma/rdma/c/d20a7cf9f714f0 Best regards, -- Leon Romanovsky